)]}'
{"tempest/api/network/test_security_groups.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"4b823b017e650339f18ef2a218291ce83be060be","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        sg_id \u003d group_create_body[\u0027security_group\u0027][\u0027id\u0027]"},{"line_number":172,"context_line":"        direction \u003d \u0027ingress\u0027"},{"line_number":173,"context_line":"        protocol \u003d \u0027icmp\u0027"},{"line_number":174,"context_line":"        icmp_type_codes \u003d [(3, 2), (3, 0), (8, 0), (0, 0), (2, None)]"},{"line_number":175,"context_line":"        for icmp_type, icmp_code in icmp_type_codes:"},{"line_number":176,"context_line":"            self._create_verify_security_group_rule(sg_id, direction,"},{"line_number":177,"context_line":"                                                    self.ethertype, protocol,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_b4ae692c","line":174,"updated":"2015-02-25 07:54:45.000000000","message":"not sure whether (2, None) is \"real\" in any way","commit_id":"e73c08eca282cdc58d5b0b45d6530762322f2eab"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"e13b70b7936a2ae11ea5da4454bf1b496b56c5d0","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        sg_id \u003d group_create_body[\u0027security_group\u0027][\u0027id\u0027]"},{"line_number":172,"context_line":"        direction \u003d \u0027ingress\u0027"},{"line_number":173,"context_line":"        protocol \u003d \u0027icmp\u0027"},{"line_number":174,"context_line":"        icmp_type_codes \u003d [(3, 2), (3, 0), (8, 0), (0, 0), (2, None)]"},{"line_number":175,"context_line":"        for icmp_type, icmp_code in icmp_type_codes:"},{"line_number":176,"context_line":"            self._create_verify_security_group_rule(sg_id, direction,"},{"line_number":177,"context_line":"                                                    self.ethertype, protocol,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_4257fa25","line":174,"in_reply_to":"ba7be1f8_3b3888ee","updated":"2015-02-26 09:12:27.000000000","message":"Which ICMP spec ?\nIt is Unassigned.\n\nPlease switch to For example 11 or to any specified one.","commit_id":"e73c08eca282cdc58d5b0b45d6530762322f2eab"},{"author":{"_account_id":12024,"name":"Tong Liu","email":"tongl@vmware.com","username":"tong101"},"change_message_id":"4152af0259db41e0006689742169fee6c4235af2","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        sg_id \u003d group_create_body[\u0027security_group\u0027][\u0027id\u0027]"},{"line_number":172,"context_line":"        direction \u003d \u0027ingress\u0027"},{"line_number":173,"context_line":"        protocol \u003d \u0027icmp\u0027"},{"line_number":174,"context_line":"        icmp_type_codes \u003d [(3, 2), (3, 0), (8, 0), (0, 0), (2, None)]"},{"line_number":175,"context_line":"        for icmp_type, icmp_code in icmp_type_codes:"},{"line_number":176,"context_line":"            self._create_verify_security_group_rule(sg_id, direction,"},{"line_number":177,"context_line":"                                                    self.ethertype, protocol,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_b3234aa6","line":174,"in_reply_to":"ba7be1f8_4257fa25","updated":"2015-02-27 23:24:57.000000000","message":"RFC 792\n\nIf it is unassigned. What\u0027s the point of testing (2, 11) since it is platform dependent as the backend may not implement this?","commit_id":"e73c08eca282cdc58d5b0b45d6530762322f2eab"},{"author":{"_account_id":12024,"name":"Tong Liu","email":"tongl@vmware.com","username":"tong101"},"change_message_id":"cde6c16c015ee0e2f2c183f97b368a7ffe81adcd","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        sg_id \u003d group_create_body[\u0027security_group\u0027][\u0027id\u0027]"},{"line_number":172,"context_line":"        direction \u003d \u0027ingress\u0027"},{"line_number":173,"context_line":"        protocol \u003d \u0027icmp\u0027"},{"line_number":174,"context_line":"        icmp_type_codes \u003d [(3, 2), (3, 0), (8, 0), (0, 0), (2, None)]"},{"line_number":175,"context_line":"        for icmp_type, icmp_code in icmp_type_codes:"},{"line_number":176,"context_line":"            self._create_verify_security_group_rule(sg_id, direction,"},{"line_number":177,"context_line":"                                                    self.ethertype, protocol,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_3b3888ee","line":174,"in_reply_to":"ba7be1f8_b4ae692c","updated":"2015-02-25 19:40:59.000000000","message":"2, None is a valid one per ICMP spec","commit_id":"e73c08eca282cdc58d5b0b45d6530762322f2eab"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"2344d642f4f12016716f4ac9c9cfb5f64c1a1aff","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        sg_id \u003d group_create_body[\u0027security_group\u0027][\u0027id\u0027]"},{"line_number":172,"context_line":"        direction \u003d \u0027ingress\u0027"},{"line_number":173,"context_line":"        protocol \u003d \u0027icmp\u0027"},{"line_number":174,"context_line":"        icmp_type_codes \u003d [(3, 2), (3, 0), (8, 0), (0, 0), (2, None)]"},{"line_number":175,"context_line":"        for icmp_type, icmp_code in icmp_type_codes:"},{"line_number":176,"context_line":"            self._create_verify_security_group_rule(sg_id, direction,"},{"line_number":177,"context_line":"                                                    self.ethertype, protocol,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_af78d6c4","line":174,"in_reply_to":"ba7be1f8_b4ae692c","updated":"2015-02-25 08:32:11.000000000","message":"For example: you can specify iptables rules just with the type: http://ipset.netfilter.org/iptables-extensions.man.html","commit_id":"e73c08eca282cdc58d5b0b45d6530762322f2eab"}]}