)]}'
{"tempest/api/object_storage/base.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"af85f57366263a40826be91650d3a15d704defce","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            cls.__name__, network_resources\u003dcls.network_resources)"},{"line_number":48,"context_line":"        # Get isolated creds for normal user"},{"line_number":49,"context_line":"        cls.os \u003d clients.Manager(cls.isolated_creds.get_creds_by_roles("},{"line_number":50,"context_line":"            [CONF.object_storage.operator_role]))"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @classmethod"},{"line_number":53,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":23,"id":"9a80dd14_df92b69e","line":50,"updated":"2015-03-04 12:09:16.000000000","message":"Nice cleanup.\nThis way we avoid creating / locking admin credentials for nothing.","commit_id":"1314e6411dcaf0a2e3f4ba894856acb57fb1518c"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"9b3fa0098d3c8326beb92c0f77b40d3420fc390d","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    @classmethod"},{"line_number":77,"context_line":"    def resource_cleanup(cls):"},{"line_number":78,"context_line":"        cls.data.teardown_all()"},{"line_number":79,"context_line":"        cls.isolated_creds.clear_isolated_creds()"},{"line_number":80,"context_line":"        super(BaseObjectTest, cls).resource_cleanup()"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a80dd14_561f1508","side":"PARENT","line":79,"updated":"2015-03-06 14:44:23.000000000","message":"It looks to me like clear_isolated_creds already gets called in the tear down process in the base class so unless I am wrong this method  could be removed in another patch.","commit_id":"976e8dfaebf514d31e99b8a0dcb7788059d3127b"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"5cbfece790f24417e8a1ba3e92095ac5b22e8a81","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    @classmethod"},{"line_number":77,"context_line":"    def resource_cleanup(cls):"},{"line_number":78,"context_line":"        cls.data.teardown_all()"},{"line_number":79,"context_line":"        cls.isolated_creds.clear_isolated_creds()"},{"line_number":80,"context_line":"        super(BaseObjectTest, cls).resource_cleanup()"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a80dd14_f7d2b15a","side":"PARENT","line":79,"in_reply_to":"9a80dd14_561f1508","updated":"2015-03-06 21:08:40.000000000","message":"Yeah that\u0027s true we can remove this in a cleanup patch.","commit_id":"976e8dfaebf514d31e99b8a0dcb7788059d3127b"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"b29bb718d954b261a8bf11dcb8e2335ebb7b09b2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        if not CONF.service_available.swift:"},{"line_number":33,"context_line":"            skip_msg \u003d (\"%s skipped as swift is not available\" % cls.__name__)"},{"line_number":34,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":35,"context_line":"        if not CONF.auth.allow_tenant_isolation and \\"},{"line_number":36,"context_line":"            not CONF.auth.locking_credentials_provider:"},{"line_number":37,"context_line":"            skip_msg \u003d (\"%s skipped because a credential provider able to \""},{"line_number":38,"context_line":"                        \"provide credentials by role is needed\" % cls.__name__)"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a80dd14_927b5027","line":35,"updated":"2015-03-06 16:32:04.000000000","message":"This will cause a skip even in the default credentials case where the default user has the needed roles. This is not so easy to fix so I guess we should say that running without tenant isolation and with default creds does not work 100%.","commit_id":"8f26829e939a695732cd5a242dddf63a9a84ecb8"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"5cbfece790f24417e8a1ba3e92095ac5b22e8a81","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        if not CONF.service_available.swift:"},{"line_number":33,"context_line":"            skip_msg \u003d (\"%s skipped as swift is not available\" % cls.__name__)"},{"line_number":34,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":35,"context_line":"        if not CONF.auth.allow_tenant_isolation and \\"},{"line_number":36,"context_line":"            not CONF.auth.locking_credentials_provider:"},{"line_number":37,"context_line":"            skip_msg \u003d (\"%s skipped because a credential provider able to \""},{"line_number":38,"context_line":"                        \"provide credentials by role is needed\" % cls.__name__)"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a80dd14_974a5524","line":35,"in_reply_to":"9a80dd14_927b5027","updated":"2015-03-06 21:08:40.000000000","message":"Yeah this is the general case. I think we can make this a bit more specific in the future, but that will require some additional helper methods in the cred providers. I will work on that in a follow-up patch.","commit_id":"8f26829e939a695732cd5a242dddf63a9a84ecb8"}]}