)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"a5b3eae229d4d9bd5b07680a9c5c10daf7999eff","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add Neutron subnetpool creating, listing, updating, and deleting"},{"line_number":10,"context_line":"via REST API."},{"line_number":11,"context_line":"Add Neutron subnet creating with subnetpool via REST API."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ica3c3b3cbe534ec2dc77f16a4de844c4de996ced"},{"line_number":14,"context_line":"Partially-Implements: blueprint subnet-allocation"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"9a80dd14_0540e0a3","line":12,"updated":"2015-03-13 15:22:27.000000000","message":"I suggested adding a \"Depends-on: I88c6b15aab258069758f1a9423d6616ceb4a33c4\" to ensure this is tested with the API patch from neutron [1].\n\n[1] https://review.openstack.org/#/c/148698/","commit_id":"37f5ee917801b8c3c257fbf54a97731b4155a85d"}],"tempest/api/network/test_subnetpools.py":[{"author":{"_account_id":9194,"name":"Emily Hugenbruch","email":"ekhugenbruch@us.ibm.com","username":"ekhugen"},"change_message_id":"fec463b8ec514f315fd88646baf322a1a13e761a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ba7be1f8_aca2cbab","updated":"2015-03-02 21:25:30.000000000","message":"Should split out the resource_setup into skip_checks, setup_credentials and setup_clients.","commit_id":"0aaf855c706b8b8a85b865e2a730e09f5e02ed5f"},{"author":{"_account_id":12524,"name":"Zengfa Gao","email":"zengfa.gao@hp.com","username":"zengfagao"},"change_message_id":"5f91a4cb79bd6da0f20c692ebd43fd268e5b6027","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ba7be1f8_8ddfc1d5","in_reply_to":"ba7be1f8_aca2cbab","updated":"2015-03-02 22:32:39.000000000","message":"I was trying to following all other api/network/admin tests, which all put skip_checks and setup_credentials as part of resource_setup()","commit_id":"0aaf855c706b8b8a85b865e2a730e09f5e02ed5f"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"7dc2db9ae9b0b69d21dd2151a5d8c3d5492ff701","unresolved":false,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":228,"context_line":"    @test.idempotent_id(\u002786b86189-9789-4582-9c3b-7e2bfe5735ee\u0027)"},{"line_number":229,"context_line":"    def test_create_subnet_from_pool_with_cidr_wildcard(self):"},{"line_number":230,"context_line":"        pool_name, pool_id \u003d self._create_subnetpool(self.client)"},{"line_number":231,"context_line":"        subnet_name \u003d data_utils.rand_name(SUBNETPOOL_NAME)"},{"line_number":232,"context_line":"        network \u003d self.create_network()"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_dfcd8432","line":229,"updated":"2015-03-09 22:49:21.000000000","message":"Something to watch out for here (maybe in another test) is the behavior of the system when \u0027prefixlen\u0027 is supplied with a wildcard CIDR.  As the code exists in review today, when a wildcard CIDR is supplied \u0027prefixlen\u0027 is simply ignored.  As long as prefixlen is non-negative, passing both prefixlen and cidr together causes prefixlen to be ignored in favor of the prefix length specified by the CIDR. This may change based on review feedback, but that\u0027s how it works for now. This is behavior we may want to assert.","commit_id":"1b1129bd3581b454a0f5e853bd36f2512625dc48"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"a8e4bda287395d3bfebf536dec9f3490afcadd1c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_e3d092f9","line":1,"updated":"2015-03-11 17:57:19.000000000","message":"This is somewhat outdated","commit_id":"35f9c8127960ffd7b4b9b6a6740a2029e104fd13"},{"author":{"_account_id":12524,"name":"Zengfa Gao","email":"zengfa.gao@hp.com","username":"zengfagao"},"change_message_id":"6db23ee69027079578801288788aab2d10f7cb8a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_91663728","line":1,"in_reply_to":"9a80dd14_e3d092f9","updated":"2015-03-11 20:25:43.000000000","message":"Done","commit_id":"35f9c8127960ffd7b4b9b6a6740a2029e104fd13"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"a8e4bda287395d3bfebf536dec9f3490afcadd1c","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from tempest import test"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"CONF \u003d config.CONF"},{"line_number":23,"context_line":"SUBNETPOOL_NAME \u003d \u0027smoke-subnetpool-\u0027"},{"line_number":24,"context_line":"SUBNET_NAME \u003d \u0027smoke-subnet-\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_032126fc","line":23,"updated":"2015-03-11 17:57:19.000000000","message":"The trailing \u0027-\u0027 is useless because it\u0027s already added by data_utils.rand_name()\n\nMore importantly, you don\u0027t need module constant here. Better to make this a class property.","commit_id":"35f9c8127960ffd7b4b9b6a6740a2029e104fd13"},{"author":{"_account_id":12524,"name":"Zengfa Gao","email":"zengfa.gao@hp.com","username":"zengfagao"},"change_message_id":"6db23ee69027079578801288788aab2d10f7cb8a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from tempest import test"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"CONF \u003d config.CONF"},{"line_number":23,"context_line":"SUBNETPOOL_NAME \u003d \u0027smoke-subnetpool-\u0027"},{"line_number":24,"context_line":"SUBNET_NAME \u003d \u0027smoke-subnet-\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_d170afde","line":23,"in_reply_to":"9a80dd14_032126fc","updated":"2015-03-11 20:25:43.000000000","message":"Done","commit_id":"35f9c8127960ffd7b4b9b6a6740a2029e104fd13"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"a8e4bda287395d3bfebf536dec9f3490afcadd1c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            raise cls.skipException(msg)"},{"line_number":64,"context_line":"        cls.admin_client \u003d cls.os_adm.network_client"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @classmethod"},{"line_number":67,"context_line":"    def _create_subnetpool(self, client, shared\u003dFalse, overlap\u003dFalse):"},{"line_number":68,"context_line":"        name \u003d data_utils.rand_name(SUBNETPOOL_NAME)"},{"line_number":69,"context_line":"        subnetpool_data \u003d copy.deepcopy(self._subnetpool_data)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_0384c6af","line":66,"updated":"2015-03-11 17:57:19.000000000","message":"All your class methods should be @staticmethod","commit_id":"35f9c8127960ffd7b4b9b6a6740a2029e104fd13"},{"author":{"_account_id":12524,"name":"Zengfa Gao","email":"zengfa.gao@hp.com","username":"zengfagao"},"change_message_id":"6db23ee69027079578801288788aab2d10f7cb8a","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            raise cls.skipException(msg)"},{"line_number":64,"context_line":"        cls.admin_client \u003d cls.os_adm.network_client"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @classmethod"},{"line_number":67,"context_line":"    def _create_subnetpool(self, client, shared\u003dFalse, overlap\u003dFalse):"},{"line_number":68,"context_line":"        name \u003d data_utils.rand_name(SUBNETPOOL_NAME)"},{"line_number":69,"context_line":"        subnetpool_data \u003d copy.deepcopy(self._subnetpool_data)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_ac77629e","line":66,"in_reply_to":"9a80dd14_0384c6af","updated":"2015-03-11 20:25:43.000000000","message":"As SubnetPoolsTestV6 extend SubnetPoolsTest, staticmethod doesnot work.","commit_id":"35f9c8127960ffd7b4b9b6a6740a2029e104fd13"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"a8e4bda287395d3bfebf536dec9f3490afcadd1c","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        return name, subnetpool_id"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @classmethod"},{"line_number":81,"context_line":"    def _delete_subnetpool(self, client, pool_id):"},{"line_number":82,"context_line":"        client.delete_subnetpool(pool_id)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_3e8e3dd1","line":81,"updated":"2015-03-11 17:57:19.000000000","message":"You don\"t need this one line function","commit_id":"35f9c8127960ffd7b4b9b6a6740a2029e104fd13"},{"author":{"_account_id":12524,"name":"Zengfa Gao","email":"zengfa.gao@hp.com","username":"zengfagao"},"change_message_id":"6db23ee69027079578801288788aab2d10f7cb8a","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        return name, subnetpool_id"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @classmethod"},{"line_number":81,"context_line":"    def _delete_subnetpool(self, client, pool_id):"},{"line_number":82,"context_line":"        client.delete_subnetpool(pool_id)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_117247e3","line":81,"in_reply_to":"9a80dd14_3e8e3dd1","updated":"2015-03-11 20:25:43.000000000","message":"Done","commit_id":"35f9c8127960ffd7b4b9b6a6740a2029e104fd13"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"a8e4bda287395d3bfebf536dec9f3490afcadd1c","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        client.delete_subnetpool(pool_id)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @classmethod"},{"line_number":85,"context_line":"    def _new_min_prefixlen(self):"},{"line_number":86,"context_line":"        return \u002728\u0027"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_6331020b","line":85,"updated":"2015-03-11 17:57:19.000000000","message":"You don\u0027t need a method here. Just make this a property. You can override properties in child class.","commit_id":"35f9c8127960ffd7b4b9b6a6740a2029e104fd13"},{"author":{"_account_id":12524,"name":"Zengfa Gao","email":"zengfa.gao@hp.com","username":"zengfagao"},"change_message_id":"6db23ee69027079578801288788aab2d10f7cb8a","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        client.delete_subnetpool(pool_id)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @classmethod"},{"line_number":85,"context_line":"    def _new_min_prefixlen(self):"},{"line_number":86,"context_line":"        return \u002728\u0027"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_517cbfb5","line":85,"in_reply_to":"9a80dd14_6331020b","updated":"2015-03-11 20:25:43.000000000","message":"Done","commit_id":"35f9c8127960ffd7b4b9b6a6740a2029e104fd13"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"a8e4bda287395d3bfebf536dec9f3490afcadd1c","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    def test_create_list_delete_subnetpool(self):"},{"line_number":114,"context_line":"        name, pool_id \u003d self._create_subnetpool(self.client)"},{"line_number":115,"context_line":"        body \u003d self.client.list_subnetpools()"},{"line_number":116,"context_line":"        self._delete_subnetpool(self.client, pool_id)"},{"line_number":117,"context_line":"        subnetpools \u003d body[\u0027subnetpools\u0027]"},{"line_number":118,"context_line":"        self.assertNotEmpty(subnetpools, \u0027We should get list of subnetpools\u0027)"},{"line_number":119,"context_line":"        for n in subnetpools:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_de88c1c8","line":116,"updated":"2015-03-11 17:57:19.000000000","message":"So here you delete the subnet pool and later on you look for it in the list of subnetpools. Is that it ?","commit_id":"35f9c8127960ffd7b4b9b6a6740a2029e104fd13"},{"author":{"_account_id":12524,"name":"Zengfa Gao","email":"zengfa.gao@hp.com","username":"zengfagao"},"change_message_id":"6db23ee69027079578801288788aab2d10f7cb8a","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    def test_create_list_delete_subnetpool(self):"},{"line_number":114,"context_line":"        name, pool_id \u003d self._create_subnetpool(self.client)"},{"line_number":115,"context_line":"        body \u003d self.client.list_subnetpools()"},{"line_number":116,"context_line":"        self._delete_subnetpool(self.client, pool_id)"},{"line_number":117,"context_line":"        subnetpools \u003d body[\u0027subnetpools\u0027]"},{"line_number":118,"context_line":"        self.assertNotEmpty(subnetpools, \u0027We should get list of subnetpools\u0027)"},{"line_number":119,"context_line":"        for n in subnetpools:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_5153df38","line":116,"in_reply_to":"9a80dd14_de88c1c8","updated":"2015-03-11 20:25:43.000000000","message":"Yes, I want to make sure the list will get created subnetpool back.","commit_id":"35f9c8127960ffd7b4b9b6a6740a2029e104fd13"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"a8e4bda287395d3bfebf536dec9f3490afcadd1c","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        for n in subnetpools:"},{"line_number":120,"context_line":"            if n[\u0027name\u0027] \u003d\u003d name and n[\u0027id\u0027] \u003d\u003d pool_id:"},{"line_number":121,"context_line":"                return"},{"line_number":122,"context_line":"        self.assertFalse(True, \u0027We should be able to list \u0027"},{"line_number":123,"context_line":"                         \u0027subnetpool we created\u0027)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_3ee0fd95","line":122,"updated":"2015-03-11 17:57:19.000000000","message":"You probably want self.fail() here.","commit_id":"35f9c8127960ffd7b4b9b6a6740a2029e104fd13"},{"author":{"_account_id":12524,"name":"Zengfa Gao","email":"zengfa.gao@hp.com","username":"zengfagao"},"change_message_id":"6db23ee69027079578801288788aab2d10f7cb8a","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        for n in subnetpools:"},{"line_number":120,"context_line":"            if n[\u0027name\u0027] \u003d\u003d name and n[\u0027id\u0027] \u003d\u003d pool_id:"},{"line_number":121,"context_line":"                return"},{"line_number":122,"context_line":"        self.assertFalse(True, \u0027We should be able to list \u0027"},{"line_number":123,"context_line":"                         \u0027subnetpool we created\u0027)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_7131c30a","line":122,"in_reply_to":"9a80dd14_3ee0fd95","updated":"2015-03-11 20:25:43.000000000","message":"Done","commit_id":"35f9c8127960ffd7b4b9b6a6740a2029e104fd13"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"a8e4bda287395d3bfebf536dec9f3490afcadd1c","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        subnetpools \u003d body[\u0027subnetpools\u0027]"},{"line_number":196,"context_line":"        for n in subnetpools:"},{"line_number":197,"context_line":"            if n[\u0027id\u0027] and n[\u0027id\u0027] \u003d\u003d pool_id:"},{"line_number":198,"context_line":"                self.assertFalse(\"True\", \"Tenant user cannot get \""},{"line_number":199,"context_line":"                                 \"notshared admin subnetpool\")"},{"line_number":200,"context_line":"        self._delete_subnetpool(self.admin_client, pool_id)"},{"line_number":201,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_3e539d3a","line":198,"updated":"2015-03-11 17:57:19.000000000","message":"This looks wrong. AssertFalse(\"True\") ?","commit_id":"35f9c8127960ffd7b4b9b6a6740a2029e104fd13"},{"author":{"_account_id":12524,"name":"Zengfa Gao","email":"zengfa.gao@hp.com","username":"zengfagao"},"change_message_id":"6db23ee69027079578801288788aab2d10f7cb8a","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        subnetpools \u003d body[\u0027subnetpools\u0027]"},{"line_number":196,"context_line":"        for n in subnetpools:"},{"line_number":197,"context_line":"            if n[\u0027id\u0027] and n[\u0027id\u0027] \u003d\u003d pool_id:"},{"line_number":198,"context_line":"                self.assertFalse(\"True\", \"Tenant user cannot get \""},{"line_number":199,"context_line":"                                 \"notshared admin subnetpool\")"},{"line_number":200,"context_line":"        self._delete_subnetpool(self.admin_client, pool_id)"},{"line_number":201,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_4c6266d9","line":198,"in_reply_to":"9a80dd14_3e539d3a","updated":"2015-03-11 20:25:43.000000000","message":"Moved to subnetpool_negative tests.","commit_id":"35f9c8127960ffd7b4b9b6a6740a2029e104fd13"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"a8e4bda287395d3bfebf536dec9f3490afcadd1c","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        body \u003d self.client.create_subnet_based_pool(subnet_data)"},{"line_number":217,"context_line":"        created_subnet \u003d body[\u0027subnet\u0027]"},{"line_number":218,"context_line":"        cidr \u003d str(created_subnet[\u0027cidr\u0027])"},{"line_number":219,"context_line":"        self.assertTrue(True)"},{"line_number":220,"context_line":"        self.assertEqual(subnet_name, created_subnet[\u0027name\u0027])"},{"line_number":221,"context_line":"        self.assertEqual(network_id, created_subnet[\u0027network_id\u0027])"},{"line_number":222,"context_line":"        self.assertEqual(pool_id, created_subnet[\u0027subnetpool_id\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_fe1f456e","line":219,"updated":"2015-03-11 17:57:19.000000000","message":"Huhu ?","commit_id":"35f9c8127960ffd7b4b9b6a6740a2029e104fd13"},{"author":{"_account_id":12524,"name":"Zengfa Gao","email":"zengfa.gao@hp.com","username":"zengfagao"},"change_message_id":"6db23ee69027079578801288788aab2d10f7cb8a","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        body \u003d self.client.create_subnet_based_pool(subnet_data)"},{"line_number":217,"context_line":"        created_subnet \u003d body[\u0027subnet\u0027]"},{"line_number":218,"context_line":"        cidr \u003d str(created_subnet[\u0027cidr\u0027])"},{"line_number":219,"context_line":"        self.assertTrue(True)"},{"line_number":220,"context_line":"        self.assertEqual(subnet_name, created_subnet[\u0027name\u0027])"},{"line_number":221,"context_line":"        self.assertEqual(network_id, created_subnet[\u0027network_id\u0027])"},{"line_number":222,"context_line":"        self.assertEqual(pool_id, created_subnet[\u0027subnetpool_id\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_b13b3bea","line":219,"in_reply_to":"9a80dd14_fe1f456e","updated":"2015-03-11 20:25:43.000000000","message":"Done","commit_id":"35f9c8127960ffd7b4b9b6a6740a2029e104fd13"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"a60d53088e82604db00cd1b9c56a36c37bd4f3e0","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        self.assertEqual(prefixlen, subnetpool[\u0027default_prefixlen\u0027])"},{"line_number":121,"context_line":"        self.assertFalse(subnetpool[\u0027shared\u0027])"},{"line_number":122,"context_line":"        self.assertFalse(subnetpool[\u0027allow_overlap\u0027])"},{"line_number":123,"context_line":"        self.client.delete_subnetpool(pool_id)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":126,"context_line":"    @test.idempotent_id(\u0027764f1b93-1c4a-4513-9e7b-6c2fc5e9270c\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_2aad7b31","line":123,"updated":"2015-03-16 08:09:21.000000000","message":"It is better to use self.addCleanup(self.client.delete_subnetpool, pool_id)","commit_id":"d44f897ae0d6b391355c7b21c5c532f56904b304"},{"author":{"_account_id":12524,"name":"Zengfa Gao","email":"zengfa.gao@hp.com","username":"zengfagao"},"change_message_id":"cd2fa86aa074995cf3014ff2a6098ca5867522bc","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        self.assertEqual(prefixlen, subnetpool[\u0027default_prefixlen\u0027])"},{"line_number":121,"context_line":"        self.assertFalse(subnetpool[\u0027shared\u0027])"},{"line_number":122,"context_line":"        self.assertFalse(subnetpool[\u0027allow_overlap\u0027])"},{"line_number":123,"context_line":"        self.client.delete_subnetpool(pool_id)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":126,"context_line":"    @test.idempotent_id(\u0027764f1b93-1c4a-4513-9e7b-6c2fc5e9270c\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_c328ee35","line":123,"in_reply_to":"9a80dd14_2aad7b31","updated":"2015-03-17 19:49:41.000000000","message":"Will use self.addCleanup","commit_id":"d44f897ae0d6b391355c7b21c5c532f56904b304"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"a60d53088e82604db00cd1b9c56a36c37bd4f3e0","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        self.assertEqual(subnetpool_data[\u0027subnetpool\u0027][\u0027max_prefixlen\u0027],"},{"line_number":139,"context_line":"                         subnetpool[\u0027max_prefixlen\u0027])"},{"line_number":140,"context_line":"        self.assertFalse(subnetpool[\u0027shared\u0027])"},{"line_number":141,"context_line":"        self.client.delete_subnetpool(pool_id)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":144,"context_line":"    @test.idempotent_id(\u0027a0524150-3139-42eb-b3ce-d0ee2f2026e5\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_aa688bf5","line":141,"updated":"2015-03-16 08:09:21.000000000","message":"the same","commit_id":"d44f897ae0d6b391355c7b21c5c532f56904b304"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"a60d53088e82604db00cd1b9c56a36c37bd4f3e0","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        self.assertEqual(subnetpool_data[\u0027subnetpool\u0027][\u0027max_prefixlen\u0027],"},{"line_number":158,"context_line":"                         subnetpool[\u0027max_prefixlen\u0027])"},{"line_number":159,"context_line":"        self.assertFalse(subnetpool[\u0027shared\u0027])"},{"line_number":160,"context_line":"        self.admin_client.delete_subnetpool(pool_id)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":163,"context_line":"    @test.idempotent_id(\u00274b496082-c992-4319-90be-d4a7ce646290\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_ca6bffee","line":160,"updated":"2015-03-16 08:09:21.000000000","message":"the same","commit_id":"d44f897ae0d6b391355c7b21c5c532f56904b304"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"a60d53088e82604db00cd1b9c56a36c37bd4f3e0","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        self.client.update_subnetpool(pool_id, subnetpool_data)"},{"line_number":170,"context_line":"        body \u003d self.client.get_subnetpool(pool_id)"},{"line_number":171,"context_line":"        prefixes \u003d body[\u0027subnetpool\u0027][\u0027prefixes\u0027]"},{"line_number":172,"context_line":"        self.assertTrue(self.new_prefixes[0] in prefixes)"},{"line_number":173,"context_line":"        self.assertTrue(old_prefixes[0] in prefixes)"},{"line_number":174,"context_line":"        self.client.delete_subnetpool(pool_id)"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_aa4fab90","line":172,"updated":"2015-03-16 08:09:21.000000000","message":"why not check this using  assertIn?","commit_id":"d44f897ae0d6b391355c7b21c5c532f56904b304"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"a60d53088e82604db00cd1b9c56a36c37bd4f3e0","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        self.assertTrue(self.new_prefixes[0] in prefixes)"},{"line_number":173,"context_line":"        self.assertTrue(old_prefixes[0] in prefixes)"},{"line_number":174,"context_line":"        self.client.delete_subnetpool(pool_id)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":177,"context_line":"    @test.idempotent_id(\u00272cae5d6a-9d32-42d8-8067-f13970ae13bb\u0027)"},{"line_number":178,"context_line":"    def test_update_subnetpool_prefixes_extend(self):"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_4a7f0fab","line":175,"updated":"2015-03-16 08:09:21.000000000","message":"the same","commit_id":"d44f897ae0d6b391355c7b21c5c532f56904b304"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"a60d53088e82604db00cd1b9c56a36c37bd4f3e0","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        body \u003d self.client.get_subnetpool(pool_id)"},{"line_number":185,"context_line":"        prefixes \u003d body[\u0027subnetpool\u0027][\u0027prefixes\u0027]"},{"line_number":186,"context_line":"        self.assertTrue(self.larger_prefixes[0] in prefixes)"},{"line_number":187,"context_line":"        self.assertTrue(old_prefixes[0] not in prefixes)"},{"line_number":188,"context_line":"        self.client.delete_subnetpool(pool_id)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_8a33c712","line":187,"updated":"2015-03-16 08:09:21.000000000","message":"Could be used assertNotIn","commit_id":"d44f897ae0d6b391355c7b21c5c532f56904b304"},{"author":{"_account_id":12524,"name":"Zengfa Gao","email":"zengfa.gao@hp.com","username":"zengfagao"},"change_message_id":"cd2fa86aa074995cf3014ff2a6098ca5867522bc","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        body \u003d self.client.get_subnetpool(pool_id)"},{"line_number":185,"context_line":"        prefixes \u003d body[\u0027subnetpool\u0027][\u0027prefixes\u0027]"},{"line_number":186,"context_line":"        self.assertTrue(self.larger_prefixes[0] in prefixes)"},{"line_number":187,"context_line":"        self.assertTrue(old_prefixes[0] not in prefixes)"},{"line_number":188,"context_line":"        self.client.delete_subnetpool(pool_id)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_031a0618","line":187,"in_reply_to":"9a80dd14_8a33c712","updated":"2015-03-17 19:49:41.000000000","message":"Will change","commit_id":"d44f897ae0d6b391355c7b21c5c532f56904b304"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"a60d53088e82604db00cd1b9c56a36c37bd4f3e0","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        prefixes \u003d body[\u0027subnetpool\u0027][\u0027prefixes\u0027]"},{"line_number":186,"context_line":"        self.assertTrue(self.larger_prefixes[0] in prefixes)"},{"line_number":187,"context_line":"        self.assertTrue(old_prefixes[0] not in prefixes)"},{"line_number":188,"context_line":"        self.client.delete_subnetpool(pool_id)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":191,"context_line":"    @test.idempotent_id(\u002762f7c43b-bff1-4def-8bb7-4754b840aaad\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_0a60b7ff","line":188,"updated":"2015-03-16 08:09:21.000000000","message":"the same comments as above","commit_id":"d44f897ae0d6b391355c7b21c5c532f56904b304"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"a60d53088e82604db00cd1b9c56a36c37bd4f3e0","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        prefixes \u003d body[\u0027subnetpool\u0027][\u0027prefixes\u0027]"},{"line_number":200,"context_line":"        self.assertTrue(self.smaller_prefixes[0] not in prefixes)"},{"line_number":201,"context_line":"        self.assertTrue(old_prefixes[0] in prefixes)"},{"line_number":202,"context_line":"        self.client.delete_subnetpool(pool_id)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":205,"context_line":"    @test.idempotent_id(\u0027d70c6c35-913b-4f24-909f-14cd0d29b2d2\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_8a1ae77a","line":202,"updated":"2015-03-16 08:09:21.000000000","message":"the same comments as above","commit_id":"d44f897ae0d6b391355c7b21c5c532f56904b304"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"a60d53088e82604db00cd1b9c56a36c37bd4f3e0","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        self.assertEqual(name, subnetpool[\u0027name\u0027])"},{"line_number":214,"context_line":"        self.assertTrue(subnetpool[\u0027shared\u0027])"},{"line_number":215,"context_line":"        self.assertTrue(subnetpool[\u0027allow_overlap\u0027])"},{"line_number":216,"context_line":"        self.admin_client.delete_subnetpool(pool_id)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":219,"context_line":"    @test.idempotent_id(\u00271362ed7d-3089-42eb-b3a5-d6cb8398ee77\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_6a285397","line":216,"updated":"2015-03-16 08:09:21.000000000","message":"the same comments as above","commit_id":"d44f897ae0d6b391355c7b21c5c532f56904b304"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"a60d53088e82604db00cd1b9c56a36c37bd4f3e0","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        self.assertEqual(pool_id, created_subnet[\u0027subnetpool_id\u0027])"},{"line_number":236,"context_line":"        self.assertTrue(cidr.endswith(str(self.max_prefixlen)))"},{"line_number":237,"context_line":"        self.client.delete_network(network_id)"},{"line_number":238,"context_line":"        self.client.delete_subnetpool(pool_id)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":241,"context_line":"    @test.idempotent_id(\u002786b86189-9789-4582-9c3b-7e2bfe5735ee\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_ea136362","line":238,"updated":"2015-03-16 08:09:21.000000000","message":"the same comments as above","commit_id":"d44f897ae0d6b391355c7b21c5c532f56904b304"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"a60d53088e82604db00cd1b9c56a36c37bd4f3e0","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":241,"context_line":"    @test.idempotent_id(\u002786b86189-9789-4582-9c3b-7e2bfe5735ee\u0027)"},{"line_number":242,"context_line":"    def test_create_subnet_from_pool_with_subnet_cidr(self):"},{"line_number":243,"context_line":"        pool_name, pool_id \u003d self._create_subnetpool(self.client)"},{"line_number":244,"context_line":"        subnet_name \u003d data_utils.rand_name(SUBNETPOOL_NAME)"},{"line_number":245,"context_line":"        network \u003d self.create_network()"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_b52b8c80","line":242,"updated":"2015-03-16 08:09:21.000000000","message":"Could this test be combined somehow with the previous one? Maybe could be created a help function that will get different subnet_data.","commit_id":"d44f897ae0d6b391355c7b21c5c532f56904b304"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"a60d53088e82604db00cd1b9c56a36c37bd4f3e0","unresolved":false,"context_lines":[{"line_number":252,"context_line":"        body \u003d self.client.create_subnet_based_pool(subnet_data)"},{"line_number":253,"context_line":"        created_subnet \u003d body[\u0027subnet\u0027]"},{"line_number":254,"context_line":"        cidr \u003d str(created_subnet[\u0027cidr\u0027])"},{"line_number":255,"context_line":"        self.assertTrue(True)"},{"line_number":256,"context_line":"        self.assertEqual(subnet_name, created_subnet[\u0027name\u0027])"},{"line_number":257,"context_line":"        self.assertEqual(network_id, created_subnet[\u0027network_id\u0027])"},{"line_number":258,"context_line":"        self.assertEqual(pool_id, created_subnet[\u0027subnetpool_id\u0027])"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_95012807","line":255,"updated":"2015-03-16 08:09:21.000000000","message":"what is this checking? :)","commit_id":"d44f897ae0d6b391355c7b21c5c532f56904b304"},{"author":{"_account_id":12524,"name":"Zengfa Gao","email":"zengfa.gao@hp.com","username":"zengfagao"},"change_message_id":"cd2fa86aa074995cf3014ff2a6098ca5867522bc","unresolved":false,"context_lines":[{"line_number":252,"context_line":"        body \u003d self.client.create_subnet_based_pool(subnet_data)"},{"line_number":253,"context_line":"        created_subnet \u003d body[\u0027subnet\u0027]"},{"line_number":254,"context_line":"        cidr \u003d str(created_subnet[\u0027cidr\u0027])"},{"line_number":255,"context_line":"        self.assertTrue(True)"},{"line_number":256,"context_line":"        self.assertEqual(subnet_name, created_subnet[\u0027name\u0027])"},{"line_number":257,"context_line":"        self.assertEqual(network_id, created_subnet[\u0027network_id\u0027])"},{"line_number":258,"context_line":"        self.assertEqual(pool_id, created_subnet[\u0027subnetpool_id\u0027])"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_83d5161d","line":255,"in_reply_to":"9a80dd14_95012807","updated":"2015-03-17 19:49:41.000000000","message":"Will change to check cidr.","commit_id":"d44f897ae0d6b391355c7b21c5c532f56904b304"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"a60d53088e82604db00cd1b9c56a36c37bd4f3e0","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        self.assertEqual(pool_id, created_subnet[\u0027subnetpool_id\u0027])"},{"line_number":259,"context_line":"        self.assertTrue(cidr.endswith(str(self.max_prefixlen)))"},{"line_number":260,"context_line":"        self.client.delete_network(network_id)"},{"line_number":261,"context_line":"        self.client.delete_subnetpool(pool_id)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"class SubnetPoolsTestV6(SubnetPoolsTest):"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_0a0ef73a","line":261,"updated":"2015-03-16 08:09:21.000000000","message":"the same comments as above","commit_id":"d44f897ae0d6b391355c7b21c5c532f56904b304"}],"tempest/api/network/test_subnetpools_negative.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"a8e4bda287395d3bfebf536dec9f3490afcadd1c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 Huawei Technologies Co.,LTD."},{"line_number":2,"context_line":"# Copyright 2012 OpenStack Foundation"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_2990c994","line":1,"updated":"2015-03-11 17:57:19.000000000","message":"I am not sure we want to add company copyright anymore. Plus you seem to be an HP employee.","commit_id":"35f9c8127960ffd7b4b9b6a6740a2029e104fd13"},{"author":{"_account_id":12524,"name":"Zengfa Gao","email":"zengfa.gao@hp.com","username":"zengfagao"},"change_message_id":"6db23ee69027079578801288788aab2d10f7cb8a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 Huawei Technologies Co.,LTD."},{"line_number":2,"context_line":"# Copyright 2012 OpenStack Foundation"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_8c37feaf","line":1,"in_reply_to":"9a80dd14_2990c994","updated":"2015-03-11 20:25:43.000000000","message":"Done","commit_id":"35f9c8127960ffd7b4b9b6a6740a2029e104fd13"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"a8e4bda287395d3bfebf536dec9f3490afcadd1c","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            raise cls.skipException(msg)"},{"line_number":53,"context_line":"        cls.admin_client \u003d cls.os_adm.network_client"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @classmethod"},{"line_number":56,"context_line":"    def _create_subnetpool(self, client, shared\u003dFalse):"},{"line_number":57,"context_line":"        subnetpool_data \u003d copy.deepcopy(self._subnetpool_data)"},{"line_number":58,"context_line":"        if shared:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_c923ada5","line":55,"updated":"2015-03-11 17:57:19.000000000","message":"This could be a static method.","commit_id":"35f9c8127960ffd7b4b9b6a6740a2029e104fd13"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"a8e4bda287395d3bfebf536dec9f3490afcadd1c","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027, \u0027smoke\u0027])"},{"line_number":95,"context_line":"    @test.idempotent_id(\u0027e6cd6d87-6173-45dd-bf04-c18ea7ec7537\u0027)"},{"line_number":96,"context_line":"    def test_update_subnetpool_not_modifiable_shared(self):"},{"line_number":97,"context_line":"        pool_id \u003d self._create_subnetpool(self.admin_client)"},{"line_number":98,"context_line":"        subnetpool_data \u003d {\u0027subnetpool\u0027: {\u0027shared\u0027: True}}"},{"line_number":99,"context_line":"        self.assertRaises(lib_exc.BadRequest, self.client.update_subnetpool,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_096305de","line":96,"updated":"2015-03-11 17:57:19.000000000","message":"Could you add a docstring here. What is this test supposed to do, why should we expect a failure etc...","commit_id":"35f9c8127960ffd7b4b9b6a6740a2029e104fd13"},{"author":{"_account_id":12524,"name":"Zengfa Gao","email":"zengfa.gao@hp.com","username":"zengfagao"},"change_message_id":"6db23ee69027079578801288788aab2d10f7cb8a","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027, \u0027smoke\u0027])"},{"line_number":95,"context_line":"    @test.idempotent_id(\u0027e6cd6d87-6173-45dd-bf04-c18ea7ec7537\u0027)"},{"line_number":96,"context_line":"    def test_update_subnetpool_not_modifiable_shared(self):"},{"line_number":97,"context_line":"        pool_id \u003d self._create_subnetpool(self.admin_client)"},{"line_number":98,"context_line":"        subnetpool_data \u003d {\u0027subnetpool\u0027: {\u0027shared\u0027: True}}"},{"line_number":99,"context_line":"        self.assertRaises(lib_exc.BadRequest, self.client.update_subnetpool,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_f10bf328","line":96,"in_reply_to":"9a80dd14_096305de","updated":"2015-03-11 20:25:43.000000000","message":"Done","commit_id":"35f9c8127960ffd7b4b9b6a6740a2029e104fd13"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"a8e4bda287395d3bfebf536dec9f3490afcadd1c","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        self.admin_client.delete_subnetpool(pool_id)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027, \u0027smoke\u0027])"},{"line_number":104,"context_line":"    @test.idempotent_id(\u0027d7f2458c-c4e5-4f03-9622-b933706c09ae\u0027)"},{"line_number":105,"context_line":"    def test_update_subnetpool_not_modifiable_overlap(self):"},{"line_number":106,"context_line":"        pool_id \u003d self._create_subnetpool(self.admin_client)"},{"line_number":107,"context_line":"        subnetpool_data \u003d {\u0027subnetpool\u0027: {\u0027allow_overlap\u0027: True}}"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_699ba1c9","line":104,"updated":"2015-03-11 17:57:19.000000000","message":"Same here. Thanks","commit_id":"35f9c8127960ffd7b4b9b6a6740a2029e104fd13"},{"author":{"_account_id":12524,"name":"Zengfa Gao","email":"zengfa.gao@hp.com","username":"zengfagao"},"change_message_id":"6db23ee69027079578801288788aab2d10f7cb8a","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        self.admin_client.delete_subnetpool(pool_id)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027, \u0027smoke\u0027])"},{"line_number":104,"context_line":"    @test.idempotent_id(\u0027d7f2458c-c4e5-4f03-9622-b933706c09ae\u0027)"},{"line_number":105,"context_line":"    def test_update_subnetpool_not_modifiable_overlap(self):"},{"line_number":106,"context_line":"        pool_id \u003d self._create_subnetpool(self.admin_client)"},{"line_number":107,"context_line":"        subnetpool_data \u003d {\u0027subnetpool\u0027: {\u0027allow_overlap\u0027: True}}"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_1107a71e","line":104,"in_reply_to":"9a80dd14_699ba1c9","updated":"2015-03-11 20:25:43.000000000","message":"Done","commit_id":"35f9c8127960ffd7b4b9b6a6740a2029e104fd13"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"a60d53088e82604db00cd1b9c56a36c37bd4f3e0","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        # None-shared admin subnetpool cannot be retrieved by tenant user."},{"line_number":76,"context_line":"        self.assertRaises(lib_exc.NotFound, self.client.get_subnetpool,"},{"line_number":77,"context_line":"                          pool_id)"},{"line_number":78,"context_line":"        self.admin_client.delete_subnetpool(pool_id)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027, \u0027smoke\u0027])"},{"line_number":81,"context_line":"    @test.idempotent_id(\u00275e1f2f86-d81a-498c-82ed-32a49f4dc4d3\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_15437842","line":78,"updated":"2015-03-16 08:09:21.000000000","message":"The same comments as for test_subnetpools.py","commit_id":"d44f897ae0d6b391355c7b21c5c532f56904b304"},{"author":{"_account_id":12524,"name":"Zengfa Gao","email":"zengfa.gao@hp.com","username":"zengfagao"},"change_message_id":"cd2fa86aa074995cf3014ff2a6098ca5867522bc","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        # None-shared admin subnetpool cannot be retrieved by tenant user."},{"line_number":76,"context_line":"        self.assertRaises(lib_exc.NotFound, self.client.get_subnetpool,"},{"line_number":77,"context_line":"                          pool_id)"},{"line_number":78,"context_line":"        self.admin_client.delete_subnetpool(pool_id)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027, \u0027smoke\u0027])"},{"line_number":81,"context_line":"    @test.idempotent_id(\u00275e1f2f86-d81a-498c-82ed-32a49f4dc4d3\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_43fddeb0","line":78,"in_reply_to":"9a80dd14_15437842","updated":"2015-03-17 19:49:41.000000000","message":"Will use self.addCleanup","commit_id":"d44f897ae0d6b391355c7b21c5c532f56904b304"}]}