)]}'
{"tempest/api/compute/servers/test_server_rescue_negative.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b77b383680bf32f401c9cce29dad7e889175d120","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def _create_volume(self):"},{"line_number":60,"context_line":"        volume \u003d self.volumes_extensions_client.create_volume("},{"line_number":61,"context_line":"            CONF.volume.volume_size, display_name\u003ddata_utils.rand_name("},{"line_number":62,"context_line":"                self.__class__.__name__ + \u0027_volume\u0027))"},{"line_number":63,"context_line":"        self.addCleanup(self.delete_volume, volume[\u0027id\u0027])"},{"line_number":64,"context_line":"        self.volumes_extensions_client.wait_for_volume_status("}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_6dedb18b","line":61,"updated":"2015-03-04 06:50:07.000000000","message":"In case you want, size can be just removed as clients.py set the conf value as default but m ok with this also.","commit_id":"3d2a21ccfdcf84bbb16fe192061250f6eea6f84a"}],"tempest/services/compute/json/volumes_extensions_client.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f9058113687359ef0fdc53a307604f96dc7a7da9","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        self.validate_response(schema.create_get_volume, resp, body)"},{"line_number":60,"context_line":"        return service_client.ResponseBody(resp, body[\u0027volume\u0027])"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def create_volume(self, size\u003dCONF.volume.volume_size, **kwargs):"},{"line_number":63,"context_line":"        \"\"\""},{"line_number":64,"context_line":"        Creates a new Volume."},{"line_number":65,"context_line":"        size(Required): Size of volume in GB."}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_334d7d73","line":62,"updated":"2015-03-02 07:44:33.000000000","message":"I think this can be done like  -tempest/services/volume/json/volumes_client.py\n\nAll service clients will be moving to tempest-lib and all conf values have been removed from them. it will be better to set the conf volume size from clients.py","commit_id":"93123d6be51a5aa0812f02fcbdc21f2b20e04c64"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"56f8e17dbdf1d534e3014accc3c73688b2a9991e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        self.validate_response(schema.create_get_volume, resp, body)"},{"line_number":60,"context_line":"        return service_client.ResponseBody(resp, body[\u0027volume\u0027])"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def create_volume(self, size\u003dCONF.volume.volume_size, **kwargs):"},{"line_number":63,"context_line":"        \"\"\""},{"line_number":64,"context_line":"        Creates a new Volume."},{"line_number":65,"context_line":"        size(Required): Size of volume in GB."}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_6c6d5732","line":62,"in_reply_to":"ba7be1f8_334d7d73","updated":"2015-03-02 09:03:41.000000000","message":"Done","commit_id":"93123d6be51a5aa0812f02fcbdc21f2b20e04c64"}],"tempest/services/volume/json/volumes_client.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"99c99c02fb45b2471bfdf0dc1083e6fb84c9e08a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    create_resp \u003d 200"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def __init__(self, auth_provider, service, region,"},{"line_number":37,"context_line":"                 default_volume_size\u003dCONF.volume.volume_size, **kwargs):"},{"line_number":38,"context_line":"        super(BaseVolumesClientJSON, self).__init__("},{"line_number":39,"context_line":"            auth_provider, service, region, **kwargs)"},{"line_number":40,"context_line":"        self.default_volume_size \u003d default_volume_size"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_46588356","line":37,"updated":"2015-02-28 17:43:08.000000000","message":"FWIW, this was already being passed in everywhere through the initialization in tempest/clients.py, but I agree making it the default here makes sense.","commit_id":"93123d6be51a5aa0812f02fcbdc21f2b20e04c64"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f9058113687359ef0fdc53a307604f96dc7a7da9","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    create_resp \u003d 200"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def __init__(self, auth_provider, service, region,"},{"line_number":37,"context_line":"                 default_volume_size\u003dCONF.volume.volume_size, **kwargs):"},{"line_number":38,"context_line":"        super(BaseVolumesClientJSON, self).__init__("},{"line_number":39,"context_line":"            auth_provider, service, region, **kwargs)"},{"line_number":40,"context_line":"        self.default_volume_size \u003d default_volume_size"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_9815684b","line":37,"in_reply_to":"ba7be1f8_46588356","updated":"2015-03-02 07:44:33.000000000","message":"Matthew- as we have removed conf values from all clients to migrate service clients to lib, i think original way was good to initialize volume size through client.py","commit_id":"93123d6be51a5aa0812f02fcbdc21f2b20e04c64"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"56f8e17dbdf1d534e3014accc3c73688b2a9991e","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    create_resp \u003d 200"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def __init__(self, auth_provider, service, region,"},{"line_number":37,"context_line":"                 default_volume_size\u003dCONF.volume.volume_size, **kwargs):"},{"line_number":38,"context_line":"        super(BaseVolumesClientJSON, self).__init__("},{"line_number":39,"context_line":"            auth_provider, service, region, **kwargs)"},{"line_number":40,"context_line":"        self.default_volume_size \u003d default_volume_size"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_cc1ba3c8","line":37,"in_reply_to":"ba7be1f8_9815684b","updated":"2015-03-02 09:03:41.000000000","message":"@Matthew+Ghanshyam: The next patch set will remove the dependency to \"config\" because the initialization is made in \"clients.py\". I tried to make the parameter \"default_volume_size\" a mandatory parameter by removing the value \"1\", but that interfered with the test case \"test_service_client_creations_with_specified_args\". Maybe it makes sense to change that test when the migration to tempest-lib will start.","commit_id":"93123d6be51a5aa0812f02fcbdc21f2b20e04c64"}]}