)]}'
{"tempest/scenario/test_security_groups_basic_ops.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"6ce619d80cb6ac34f10dbdb03f870ed6f3804f68","unresolved":false,"context_lines":[{"line_number":290,"context_line":"            client\u003dtenant.manager.network_client)"},{"line_number":291,"context_line":"        self.floating_ips.setdefault(server[\u0027id\u0027], floating_ip)"},{"line_number":292,"context_line":"        # Check for floating ip status before connecting to access-point"},{"line_number":293,"context_line":"        self.check_floating_ip_status(floating_ip, \u0027ACTIVE\u0027)"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    def _create_tenant_network(self, tenant):"},{"line_number":296,"context_line":"        network, subnet, router \u003d self.create_networks("}],"source_content_type":"text/x-python","patch_set":7,"id":"9af37de9_cc863e13","line":293,"updated":"2015-05-11 03:58:04.000000000","message":"There is a larger method \"_verify_network_details\" for checking network status, and the method is called after this _assign_floating_ips().\nSo how about adding this check into _verify_network_details() instead of here for consistent/readable code ?","commit_id":"8a2a71a1954bdadb75235a2466f98e5d4cfe0eeb"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"09396a75bab56751d67cc63d069c037934d697a2","unresolved":false,"context_lines":[{"line_number":290,"context_line":"            client\u003dtenant.manager.network_client)"},{"line_number":291,"context_line":"        self.floating_ips.setdefault(server[\u0027id\u0027], floating_ip)"},{"line_number":292,"context_line":"        # Check for floating ip status before connecting to access-point"},{"line_number":293,"context_line":"        self.check_floating_ip_status(floating_ip, \u0027ACTIVE\u0027)"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    def _create_tenant_network(self, tenant):"},{"line_number":296,"context_line":"        network, subnet, router \u003d self.create_networks("}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_5f59895a","line":293,"in_reply_to":"9af37de9_cc863e13","updated":"2015-05-27 16:03:39.000000000","message":"The latest code is not changed related to the above comment. So is the comment wrong for this case?","commit_id":"8a2a71a1954bdadb75235a2466f98e5d4cfe0eeb"}]}