)]}'
{"tempest/api/compute/admin/test_baremetal_nodes.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"abbfd1816580e98ea999c41efbd7bc2d5c6e88ee","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            skip_msg \u003d (\u0027%s skipped as Ironic is not available\u0027 % cls.__name__)"},{"line_number":33,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":34,"context_line":"        cls.client \u003d cls.os_adm.baremetal_nodes_client"},{"line_number":35,"context_line":"        cls.bm_client \u003d clients.AdminManager().baremetal_client"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def setUp(self):"},{"line_number":38,"context_line":"        super(BaremetalNodesAdminTestJSON, self).setUp()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_35ec8e29","line":35,"updated":"2015-03-11 23:30:55.000000000","message":"If you need admin here you shouldn\u0027t reinitialize AdminManager like this it ignores the isolation of credential providers and won\u0027t work in every configuration. You should be able to just do:\n\n  cls.bm_client \u003d cls.os_adm.baremetal_client\n\n(also no comment on bm client)","commit_id":"9aa4f85f6f8cbcf2bd91ac3940a6e13be99ed62e"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"abbfd1816580e98ea999c41efbd7bc2d5c6e88ee","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        cls.client \u003d cls.os_adm.baremetal_nodes_client"},{"line_number":35,"context_line":"        cls.bm_client \u003d clients.AdminManager().baremetal_client"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def setUp(self):"},{"line_number":38,"context_line":"        super(BaremetalNodesAdminTestJSON, self).setUp()"},{"line_number":39,"context_line":"        self.nodes \u003d []"},{"line_number":40,"context_line":"        for i in range(0, 2):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_7571a6a7","line":37,"updated":"2015-03-11 23:30:55.000000000","message":"So using setUp here doesn\u0027t matter now because there is only one test present. But if there are additional tests added to this class in the future we\u0027ll be making 3 nodes for each test.","commit_id":"9aa4f85f6f8cbcf2bd91ac3940a6e13be99ed62e"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"420ef43d9ba9bd5306a8f10e0127fbbcea0a739b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        cls.client \u003d cls.os_adm.baremetal_nodes_client"},{"line_number":34,"context_line":"        cls.ironic_client \u003d cls.os_adm.baremetal_client"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @test.attr(type\u003d[\u0027smoke\u0027, \u0027baremetal\u0027])"},{"line_number":37,"context_line":"    @test.idempotent_id(\u0027e475aa6e-416d-4fa4-b3af-28d5e84250fb\u0027)"},{"line_number":38,"context_line":"    def test_list_get_baremetal_nodes(self):"},{"line_number":39,"context_line":"        # Create some test nodes in Ironic directly"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_06a46b49","line":36,"updated":"2015-03-13 15:02:52.000000000","message":"You don\u0027t have to tag this as baremetal it\u0027s a bit redundant if you\u0027re doing it just for filtering purposes, since baremetal is already in the test name, but it doesn\u0027t hurt anything.","commit_id":"118cd39c61996785f21acfb1afecba5f0d3e7fb9"}]}