)]}'
{"tempest/api_schema/response/compute/v2_1/servers.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"6698d88593061b6a619cea0fb6b7bba3fb1d5c5c","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    }"},{"line_number":147,"context_line":"}"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"base_get_server \u003d copy.deepcopy(common_show_server)"},{"line_number":150,"context_line":"base_get_server[\u0027properties\u0027].update({"},{"line_number":151,"context_line":"    \u0027key_name\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":152,"context_line":"    \u0027security_groups\u0027: {\u0027type\u0027: \u0027array\u0027},"}],"source_content_type":"text/x-python","patch_set":9,"id":"baa041b7_3a16a355","line":149,"updated":"2015-04-06 01:03:52.000000000","message":"This base_get_server seems the detail of a server because this value is used for list_servers_detail also, so how about naming \"server_detail\" or something ?","commit_id":"0bfb90a65ceedc22e5dc9dd9a72b97872f62f453"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"05882c35ab4638a0aac2beaae5c0220f79e95d70","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    }"},{"line_number":147,"context_line":"}"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"base_get_server \u003d copy.deepcopy(common_show_server)"},{"line_number":150,"context_line":"base_get_server[\u0027properties\u0027].update({"},{"line_number":151,"context_line":"    \u0027key_name\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":152,"context_line":"    \u0027security_groups\u0027: {\u0027type\u0027: \u0027array\u0027},"}],"source_content_type":"text/x-python","patch_set":9,"id":"baa041b7_95758099","line":149,"in_reply_to":"baa041b7_3a16a355","updated":"2015-04-06 01:41:58.000000000","message":"Nice point. Done","commit_id":"0bfb90a65ceedc22e5dc9dd9a72b97872f62f453"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"6698d88593061b6a619cea0fb6b7bba3fb1d5c5c","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    \u0027^[a-zA-Z0-9-_.]+$\u0027][\u0027items\u0027][\u0027properties\u0027].update({"},{"line_number":177,"context_line":"        \u0027OS-EXT-IPS:type\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":178,"context_line":"        \u0027OS-EXT-IPS-MAC:mac_addr\u0027: parameter_types.mac_address})"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"get_server \u003d {"},{"line_number":181,"context_line":"    \u0027status_code\u0027: [200],"},{"line_number":182,"context_line":"    \u0027response_body\u0027: {"}],"source_content_type":"text/x-python","patch_set":9,"id":"baa041b7_5a13a766","line":179,"updated":"2015-04-06 01:03:52.000000000","message":"If this part(line175-179) is moved into line 169, the code would be more easy.","commit_id":"0bfb90a65ceedc22e5dc9dd9a72b97872f62f453"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"05882c35ab4638a0aac2beaae5c0220f79e95d70","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    \u0027^[a-zA-Z0-9-_.]+$\u0027][\u0027items\u0027][\u0027properties\u0027].update({"},{"line_number":177,"context_line":"        \u0027OS-EXT-IPS:type\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":178,"context_line":"        \u0027OS-EXT-IPS-MAC:mac_addr\u0027: parameter_types.mac_address})"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"get_server \u003d {"},{"line_number":181,"context_line":"    \u0027status_code\u0027: [200],"},{"line_number":182,"context_line":"    \u0027response_body\u0027: {"}],"source_content_type":"text/x-python","patch_set":9,"id":"baa041b7_7578bc8f","line":179,"in_reply_to":"baa041b7_5a13a766","updated":"2015-04-06 01:41:58.000000000","message":"Done","commit_id":"0bfb90a65ceedc22e5dc9dd9a72b97872f62f453"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"6698d88593061b6a619cea0fb6b7bba3fb1d5c5c","unresolved":false,"context_lines":[{"line_number":203,"context_line":"}"},{"line_number":204,"context_line":"# Defining \u0027servers_links\u0027 attributes for V2 server schema"},{"line_number":205,"context_line":"list_servers_detail[\u0027response_body\u0027]["},{"line_number":206,"context_line":"    \u0027properties\u0027].update({\u0027servers_links\u0027: parameter_types.links})"},{"line_number":207,"context_line":"# NOTE(gmann): servers_links attribute is not necessary to be"},{"line_number":208,"context_line":"# present always So it is not \u0027required\u0027."},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"baa041b7_1a0e3f3b","line":206,"updated":"2015-04-06 01:03:52.000000000","message":"how about moving line294-206 into line 201 for readability?","commit_id":"0bfb90a65ceedc22e5dc9dd9a72b97872f62f453"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"05882c35ab4638a0aac2beaae5c0220f79e95d70","unresolved":false,"context_lines":[{"line_number":203,"context_line":"}"},{"line_number":204,"context_line":"# Defining \u0027servers_links\u0027 attributes for V2 server schema"},{"line_number":205,"context_line":"list_servers_detail[\u0027response_body\u0027]["},{"line_number":206,"context_line":"    \u0027properties\u0027].update({\u0027servers_links\u0027: parameter_types.links})"},{"line_number":207,"context_line":"# NOTE(gmann): servers_links attribute is not necessary to be"},{"line_number":208,"context_line":"# present always So it is not \u0027required\u0027."},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"baa041b7_556ff8c4","line":206,"in_reply_to":"baa041b7_1a0e3f3b","updated":"2015-04-06 01:41:58.000000000","message":"Done","commit_id":"0bfb90a65ceedc22e5dc9dd9a72b97872f62f453"}]}