)]}'
{"tempest/scenario/test_network_basic_ops.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"5ba44964a737d6ab26f705cc7f943e8997031409","unresolved":false,"context_lines":[{"line_number":665,"context_line":"    @test.idempotent_id(\u002751641c7d-119a-44cd-aac6-b5b9f86dd808\u0027)"},{"line_number":666,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":667,"context_line":"    def test_creation_of_server_attached_to_user_created_port(self):"},{"line_number":668,"context_line":"        self.sec_group \u003d self._create_security_group(tenant_id\u003dself.tenant_id)"},{"line_number":669,"context_line":"        self.network, self.subnet, self.router \u003d super(TestNetworkBasicOps,"},{"line_number":670,"context_line":"                                                       self).create_networks()"},{"line_number":671,"context_line":"        net_id \u003d self.network.id"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_c220884b","line":668,"updated":"2015-03-13 12:06:51.000000000","message":"You don\u0027t need to make this a instance attribute. Just do :\n\nsec_group \u003d self._create_security_group(tenant_id\u003dself.tenant_id)","commit_id":"4b9f8282738e9fed3fd8eb0bd0821283b5bfc38f"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"5ba44964a737d6ab26f705cc7f943e8997031409","unresolved":false,"context_lines":[{"line_number":666,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":667,"context_line":"    def test_creation_of_server_attached_to_user_created_port(self):"},{"line_number":668,"context_line":"        self.sec_group \u003d self._create_security_group(tenant_id\u003dself.tenant_id)"},{"line_number":669,"context_line":"        self.network, self.subnet, self.router \u003d super(TestNetworkBasicOps,"},{"line_number":670,"context_line":"                                                       self).create_networks()"},{"line_number":671,"context_line":"        net_id \u003d self.network.id"},{"line_number":672,"context_line":"        kwargs \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_221404e8","line":669,"updated":"2015-03-13 12:06:51.000000000","message":"Same here","commit_id":"4b9f8282738e9fed3fd8eb0bd0821283b5bfc38f"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"e3095df7b50974d22fdd8cebffbb5d38df20bb38","unresolved":false,"context_lines":[{"line_number":668,"context_line":"        self._check_tenant_network_connectivity()"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"        floating_ip \u003d self.create_floating_ip(server)"},{"line_number":671,"context_line":"        self.floating_ip_tuple \u003d Floating_IP_tuple(floating_ip, server)"},{"line_number":672,"context_line":"        self.check_public_network_connectivity("},{"line_number":673,"context_line":"            should_connect\u003dTrue, msg\u003d\"connected \")"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_008809e6","line":671,"updated":"2015-03-25 08:22:23.000000000","message":"Why do you need this variable for ?","commit_id":"912e03b7c706ed504479d6e194069ece71ae07ca"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"d2e03cbebef3d815c54e4d9194af1451dee73e5d","unresolved":false,"context_lines":[{"line_number":668,"context_line":"        self._check_tenant_network_connectivity()"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"        floating_ip \u003d self.create_floating_ip(server)"},{"line_number":671,"context_line":"        self.floating_ip_tuple \u003d Floating_IP_tuple(floating_ip, server)"},{"line_number":672,"context_line":"        self.check_public_network_connectivity("},{"line_number":673,"context_line":"            should_connect\u003dTrue, msg\u003d\"connected \")"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_03ec93c6","line":671,"in_reply_to":"1a6ced46_008809e6","updated":"2015-03-25 08:58:23.000000000","message":"in check_public_network_connectivity function there are using floating_ip_tuple to get the floating_ip ---\u003e\nfloating_ip, server \u003d self.floating_ip_tuple.","commit_id":"912e03b7c706ed504479d6e194069ece71ae07ca"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"331451f2d24a80360f139a1029652b20b38c8bef","unresolved":false,"context_lines":[{"line_number":668,"context_line":"        self._check_tenant_network_connectivity()"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"        floating_ip \u003d self.create_floating_ip(server)"},{"line_number":671,"context_line":"        self.floating_ip_tuple \u003d Floating_IP_tuple(floating_ip, server)"},{"line_number":672,"context_line":"        self.check_public_network_connectivity("},{"line_number":673,"context_line":"            should_connect\u003dTrue, msg\u003d\"connected \")"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_fea9cadf","line":671,"in_reply_to":"1a6ced46_03ec93c6","updated":"2015-03-25 09:32:19.000000000","message":"You\u0027re right. I didn\u0027t read carefully enough this. Thanks.","commit_id":"912e03b7c706ed504479d6e194069ece71ae07ca"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"e3095df7b50974d22fdd8cebffbb5d38df20bb38","unresolved":false,"context_lines":[{"line_number":670,"context_line":"        floating_ip \u003d self.create_floating_ip(server)"},{"line_number":671,"context_line":"        self.floating_ip_tuple \u003d Floating_IP_tuple(floating_ip, server)"},{"line_number":672,"context_line":"        self.check_public_network_connectivity("},{"line_number":673,"context_line":"            should_connect\u003dTrue, msg\u003d\"connected \")"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_c0f2716e","line":673,"updated":"2015-03-25 08:22:23.000000000","message":"You shouldn\u0027t pass the \"msg\" keyword argument. Otherwise in case of failure the following message would be printed :\n\n Public network connectivity check failed : connected\n\nWhich doesn\u0027t help imo.","commit_id":"912e03b7c706ed504479d6e194069ece71ae07ca"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"d2e03cbebef3d815c54e4d9194af1451dee73e5d","unresolved":false,"context_lines":[{"line_number":670,"context_line":"        floating_ip \u003d self.create_floating_ip(server)"},{"line_number":671,"context_line":"        self.floating_ip_tuple \u003d Floating_IP_tuple(floating_ip, server)"},{"line_number":672,"context_line":"        self.check_public_network_connectivity("},{"line_number":673,"context_line":"            should_connect\u003dTrue, msg\u003d\"connected \")"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_63dc6713","line":673,"in_reply_to":"1a6ced46_c0f2716e","updated":"2015-03-25 08:58:23.000000000","message":"yes i removed it.","commit_id":"912e03b7c706ed504479d6e194069ece71ae07ca"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"045d1a6ac602629adafadc2c26c1e28182eda0bd","unresolved":false,"context_lines":[{"line_number":661,"context_line":"            \u0027security_groups\u0027: [self.security_group[\u0027id\u0027]],"},{"line_number":662,"context_line":"        }"},{"line_number":663,"context_line":""},{"line_number":664,"context_line":"        port \u003d super(TestNetworkBasicOps, self)._create_port(network.id,"},{"line_number":665,"context_line":"                                                             **kwargs)"},{"line_number":666,"context_line":"        name \u003d data_utils.rand_name(\u0027server-smoke\u0027)"},{"line_number":667,"context_line":"        server \u003d self._create_server(name, network, port.id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aa53dc9_3a528314","line":664,"updated":"2015-04-06 19:59:14.000000000","message":"Why isn\u0027t this just calling self._create_port ?","commit_id":"40d0be944e7d5cad45bc8330edfe24a1bd0e1451"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"1d157cf4242ce47bdcdaec06ef9d5321d4ad975d","unresolved":false,"context_lines":[{"line_number":661,"context_line":"            \u0027security_groups\u0027: [self.security_group[\u0027id\u0027]],"},{"line_number":662,"context_line":"        }"},{"line_number":663,"context_line":""},{"line_number":664,"context_line":"        port \u003d super(TestNetworkBasicOps, self)._create_port(network.id,"},{"line_number":665,"context_line":"                                                             **kwargs)"},{"line_number":666,"context_line":"        name \u003d data_utils.rand_name(\u0027server-smoke\u0027)"},{"line_number":667,"context_line":"        server \u003d self._create_server(name, network, port.id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aa53dc9_df77fcd2","line":664,"in_reply_to":"9aa53dc9_3a528314","updated":"2015-04-07 06:02:04.000000000","message":"yes i made changes and uploaded new patch","commit_id":"40d0be944e7d5cad45bc8330edfe24a1bd0e1451"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"ab0071ce14cfe7c812459222d03c727abf7e5a78","unresolved":false,"context_lines":[{"line_number":653,"context_line":"    @test.idempotent_id(\u002751641c7d-119a-44cd-aac6-b5b9f86dd808\u0027)"},{"line_number":654,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":655,"context_line":"    def test_creation_of_server_attached_to_user_created_port(self):"},{"line_number":656,"context_line":"        self.security_group \u003d \\"},{"line_number":657,"context_line":"            self._create_security_group(tenant_id\u003dself.tenant_id)"},{"line_number":658,"context_line":"        network, subnet, router \u003d super(TestNetworkBasicOps,"},{"line_number":659,"context_line":"                                        self).create_networks()"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aa53dc9_e9cd0986","line":656,"updated":"2015-04-09 07:19:39.000000000","message":"See my comment on this line on patchset 3","commit_id":"4f4a4a586fca58258ef14623ea3c88a035aaa47e"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"68ac7731970b6ae239bc8b82ac2ccb8a0905df17","unresolved":false,"context_lines":[{"line_number":653,"context_line":"    @test.idempotent_id(\u002751641c7d-119a-44cd-aac6-b5b9f86dd808\u0027)"},{"line_number":654,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":655,"context_line":"    def test_creation_of_server_attached_to_user_created_port(self):"},{"line_number":656,"context_line":"        self.security_group \u003d \\"},{"line_number":657,"context_line":"            self._create_security_group(tenant_id\u003dself.tenant_id)"},{"line_number":658,"context_line":"        network, subnet, router \u003d super(TestNetworkBasicOps,"},{"line_number":659,"context_line":"                                        self).create_networks()"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aa53dc9_640b608f","line":656,"in_reply_to":"9aa53dc9_e9cd0986","updated":"2015-04-09 07:52:14.000000000","message":"in _create_server function, self.security_group is used.\nso i need to make a instance of that","commit_id":"4f4a4a586fca58258ef14623ea3c88a035aaa47e"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"ab0071ce14cfe7c812459222d03c727abf7e5a78","unresolved":false,"context_lines":[{"line_number":655,"context_line":"    def test_creation_of_server_attached_to_user_created_port(self):"},{"line_number":656,"context_line":"        self.security_group \u003d \\"},{"line_number":657,"context_line":"            self._create_security_group(tenant_id\u003dself.tenant_id)"},{"line_number":658,"context_line":"        network, subnet, router \u003d super(TestNetworkBasicOps,"},{"line_number":659,"context_line":"                                        self).create_networks()"},{"line_number":660,"context_line":"        kwargs \u003d {"},{"line_number":661,"context_line":"            \u0027security_groups\u0027: [self.security_group[\u0027id\u0027]],"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aa53dc9_89d55d1d","line":658,"updated":"2015-04-09 07:19:39.000000000","message":"Can\u0027t you just call self.create_networks() ?","commit_id":"4f4a4a586fca58258ef14623ea3c88a035aaa47e"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"68ac7731970b6ae239bc8b82ac2ccb8a0905df17","unresolved":false,"context_lines":[{"line_number":655,"context_line":"    def test_creation_of_server_attached_to_user_created_port(self):"},{"line_number":656,"context_line":"        self.security_group \u003d \\"},{"line_number":657,"context_line":"            self._create_security_group(tenant_id\u003dself.tenant_id)"},{"line_number":658,"context_line":"        network, subnet, router \u003d super(TestNetworkBasicOps,"},{"line_number":659,"context_line":"                                        self).create_networks()"},{"line_number":660,"context_line":"        kwargs \u003d {"},{"line_number":661,"context_line":"            \u0027security_groups\u0027: [self.security_group[\u0027id\u0027]],"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aa53dc9_2401d86a","line":658,"in_reply_to":"9aa53dc9_89d55d1d","updated":"2015-04-09 07:52:14.000000000","message":"yes i made changes and will upload a new patch","commit_id":"4f4a4a586fca58258ef14623ea3c88a035aaa47e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0aa0904df63663cb4f1fd7e37c3940de3d4c266d","unresolved":false,"context_lines":[{"line_number":652,"context_line":""},{"line_number":653,"context_line":"    @test.idempotent_id(\u002751641c7d-119a-44cd-aac6-b5b9f86dd808\u0027)"},{"line_number":654,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":655,"context_line":"    def test_creation_of_server_attached_to_user_created_port(self):"},{"line_number":656,"context_line":"        self.security_group \u003d ("},{"line_number":657,"context_line":"            self._create_security_group(tenant_id\u003dself.tenant_id))"},{"line_number":658,"context_line":"        network, subnet, router \u003d self.create_networks()"}],"source_content_type":"text/x-python","patch_set":8,"id":"dac4157f_e27b577a","line":655,"updated":"2015-04-19 15:37:49.000000000","message":"How is this any different than test_preserve_preexisting_port ?","commit_id":"2b34ec3ff444e6e6ec7b3e52832ecd6e8ca20552"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3034dca537c00dc5f7a1d26c150da4d2621190fe","unresolved":false,"context_lines":[{"line_number":652,"context_line":""},{"line_number":653,"context_line":"    @test.idempotent_id(\u002751641c7d-119a-44cd-aac6-b5b9f86dd808\u0027)"},{"line_number":654,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":655,"context_line":"    def test_creation_of_server_attached_to_user_created_port(self):"},{"line_number":656,"context_line":"        self.security_group \u003d ("},{"line_number":657,"context_line":"            self._create_security_group(tenant_id\u003dself.tenant_id))"},{"line_number":658,"context_line":"        network, subnet, router \u003d self.create_networks()"}],"source_content_type":"text/x-python","patch_set":8,"id":"dac4157f_a99529e5","line":655,"in_reply_to":"dac4157f_a904097e","updated":"2015-04-20 15:44:06.000000000","message":"I see the test wasn\u0027t run in the ironic pxe ssh job:\n\nhttp://logs.openstack.org/86/162886/8/check/check-tempest-dsvm-ironic-pxe_ssh/ffd43e7/console.html.gz\n\nSo this isn\u0027t tested against baremetal on kilo either, so I guess we could have just skipped if baremetal\u003dTrue rather than revert.","commit_id":"2b34ec3ff444e6e6ec7b3e52832ecd6e8ca20552"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"6d67cf8d35769013aabfffed3d0bd1ac2f1ed5d9","unresolved":false,"context_lines":[{"line_number":652,"context_line":""},{"line_number":653,"context_line":"    @test.idempotent_id(\u002751641c7d-119a-44cd-aac6-b5b9f86dd808\u0027)"},{"line_number":654,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":655,"context_line":"    def test_creation_of_server_attached_to_user_created_port(self):"},{"line_number":656,"context_line":"        self.security_group \u003d ("},{"line_number":657,"context_line":"            self._create_security_group(tenant_id\u003dself.tenant_id))"},{"line_number":658,"context_line":"        network, subnet, router \u003d self.create_networks()"}],"source_content_type":"text/x-python","patch_set":8,"id":"dac4157f_3b3b88d3","line":655,"in_reply_to":"dac4157f_a99529e5","updated":"2015-04-21 04:55:08.000000000","message":"ok what changes i need to do next?","commit_id":"2b34ec3ff444e6e6ec7b3e52832ecd6e8ca20552"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dafc9398f79209fda9a5b34d41e28f2ee358cb16","unresolved":false,"context_lines":[{"line_number":652,"context_line":""},{"line_number":653,"context_line":"    @test.idempotent_id(\u002751641c7d-119a-44cd-aac6-b5b9f86dd808\u0027)"},{"line_number":654,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":655,"context_line":"    def test_creation_of_server_attached_to_user_created_port(self):"},{"line_number":656,"context_line":"        self.security_group \u003d ("},{"line_number":657,"context_line":"            self._create_security_group(tenant_id\u003dself.tenant_id))"},{"line_number":658,"context_line":"        network, subnet, router \u003d self.create_networks()"}],"source_content_type":"text/x-python","patch_set":8,"id":"dac4157f_a904097e","line":655,"in_reply_to":"dac4157f_d1b49fd2","updated":"2015-04-20 15:40:32.000000000","message":"Hmm, this might be why it fails with ironic.","commit_id":"2b34ec3ff444e6e6ec7b3e52832ecd6e8ca20552"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"9531aa59b53cd06a8ef521d27b451e65e4402bae","unresolved":false,"context_lines":[{"line_number":652,"context_line":""},{"line_number":653,"context_line":"    @test.idempotent_id(\u002751641c7d-119a-44cd-aac6-b5b9f86dd808\u0027)"},{"line_number":654,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":655,"context_line":"    def test_creation_of_server_attached_to_user_created_port(self):"},{"line_number":656,"context_line":"        self.security_group \u003d ("},{"line_number":657,"context_line":"            self._create_security_group(tenant_id\u003dself.tenant_id))"},{"line_number":658,"context_line":"        network, subnet, router \u003d self.create_networks()"}],"source_content_type":"text/x-python","patch_set":8,"id":"dac4157f_d1b49fd2","line":655,"in_reply_to":"dac4157f_e27b577a","updated":"2015-04-20 05:27:09.000000000","message":"Here in this test i am creating a port with \"security group\" and later booting a server with the created port.","commit_id":"2b34ec3ff444e6e6ec7b3e52832ecd6e8ca20552"}]}