)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"86017ba7dd6626ecdbb6ca910d99a3a50cfaa6cc","unresolved":false,"context_lines":[{"line_number":15,"context_line":"True in gate runs so we can test it."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Also note Nova change Ideeb3c137ff68a4497189670be33f6edbb0ccb76 which"},{"line_number":18,"context_line":"will deprecate the option in Kilo and slate it for remove in Liberty, at"},{"line_number":19,"context_line":"which point we can unwind the config options. This work is being done"},{"line_number":20,"context_line":"now, however, so we can test a feature that\u0027s been in Nova since Juno"},{"line_number":21,"context_line":"but is not tested in the gate."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba3cc151_ddbdce68","line":18,"updated":"2015-07-09 20:22:57.000000000","message":"commit b06867c581541ed325ddc5e5b5a2d53b1b0261ac removed the option in liberty","commit_id":"b21c7341162e9bad9182c729a7665382f60392f3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"28c3b2c10f531b10a25c3f7f3f7831f849946661","unresolved":false,"context_lines":[{"line_number":11,"context_line":"to False. To test it, we need a feature toggle in Tempest so anything"},{"line_number":12,"context_line":"testing against a default Nova setup doesn\u0027t fail."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Separate changes will be made to devstack and devstack-gate to make this"},{"line_number":15,"context_line":"True in gate runs so we can test it."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Also note Nova change Ideeb3c137ff68a4497189670be33f6edbb0ccb76 which"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba3cc151_53b20d95","line":14,"updated":"2015-07-09 21:04:31.000000000","message":"I don\u0027t think I actually need to change anything for devstack-gate here.","commit_id":"8ebbc7caa097fefd6a2b5338d8e43d5344fc6b54"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"539d1089362f653071dd1992bdba9a8a50ffa906","unresolved":false,"context_lines":[{"line_number":20,"context_line":"remove the config option from Tempest."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Related devstack change: Ifd075420f57c9b60746f4a6af6520c0ef04800db"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I05f81d86cde249c23be06d5804fadbf40fc4a7f3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a41bdd9_50cd5583","line":23,"updated":"2015-07-15 15:48:25.000000000","message":"Add:\n\nCo-Authored-By: Racha Ben Ali \u003cbenali@gmail.com\u003e","commit_id":"eda33251dab0ea26073ec2479465d8561fa3f9c1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"58ad90e7d2a9e4fecbc5e9dff281e7a5642bab5e","unresolved":false,"context_lines":[{"line_number":20,"context_line":"remove the config option from Tempest."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Related devstack change: Ifd075420f57c9b60746f4a6af6520c0ef04800db"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I05f81d86cde249c23be06d5804fadbf40fc4a7f3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3a50d1a3_72003235","line":23,"updated":"2015-07-20 16:42:52.000000000","message":"Co-Authored-By: Racha Ben Ali \u003cbenali@gmail.com\u003e","commit_id":"638ce11d90647abfedc51571524a88969abc7b79"}],"tempest/api/compute/servers/test_create_server.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"28c3b2c10f531b10a25c3f7f3f7831f849946661","unresolved":false,"context_lines":[{"line_number":202,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled."},{"line_number":203,"context_line":"                          allow_duplicate_networks,"},{"line_number":204,"context_line":"                          \u0027Duplicate networks must \u0027"},{"line_number":205,"context_line":"                          \u0027be allowed (remove skip in Liberty)\u0027)"},{"line_number":206,"context_line":"    def test_verify_duplicate_network_nics(self):"},{"line_number":207,"context_line":"        # Verify that server creation does not fail when more than one nic"},{"line_number":208,"context_line":"        # is created on the same network."}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_936ad5eb","line":205,"updated":"2015-07-09 21:04:31.000000000","message":"The (remove skip in Liberty) thing doesn\u0027t need to be in the skip output, just add it as a comment in the code.","commit_id":"8ebbc7caa097fefd6a2b5338d8e43d5344fc6b54"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"28c3b2c10f531b10a25c3f7f3f7831f849946661","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        self.addCleanup(self.network_client.delete_subnet,"},{"line_number":219,"context_line":"                        subnet1[\u0027subnet\u0027][\u0027id\u0027])"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        name_net2 \u003d data_utils.rand_name(self.__class__.__name__)"},{"line_number":222,"context_line":"        net2 \u003d self.network_client.create_network(name\u003dname_net2)"},{"line_number":223,"context_line":"        self.addCleanup(self.network_client.delete_network,"},{"line_number":224,"context_line":"                        net2[\u0027network\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_f33561f6","line":221,"updated":"2015-07-09 21:04:31.000000000","message":"We should just write a helper method to create the network and subnet so we don\u0027t need the duplication here.  The only parameter is on the subnet helper for the cidr.","commit_id":"8ebbc7caa097fefd6a2b5338d8e43d5344fc6b54"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"539d1089362f653071dd1992bdba9a8a50ffa906","unresolved":false,"context_lines":[{"line_number":214,"context_line":"    @test.idempotent_id(\u00271678d144-ed74-43f8-8e57-ab10dbf9b3c2\u0027)"},{"line_number":215,"context_line":"    @testtools.skipUnless(CONF.service_available.neutron,"},{"line_number":216,"context_line":"                          \u0027Neutron service must be available.\u0027)"},{"line_number":217,"context_line":"    # The following skipUnless test should be removed in Liberty"},{"line_number":218,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled."},{"line_number":219,"context_line":"                          allow_duplicate_networks,"},{"line_number":220,"context_line":"                          \u0027Duplicate networks must be allowed\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a41bdd9_70dc1946","line":217,"updated":"2015-07-15 15:48:25.000000000","message":"We\u0027re in liberty, so this is confusing.  Per the commit message, we can remove the config option and the skip once kilo-eol happens, so that\u0027s what this should say.","commit_id":"eda33251dab0ea26073ec2479465d8561fa3f9c1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8e208869707203b27089c7713b0744ee588fc72e","unresolved":false,"context_lines":[{"line_number":214,"context_line":"    @test.idempotent_id(\u00271678d144-ed74-43f8-8e57-ab10dbf9b3c2\u0027)"},{"line_number":215,"context_line":"    @testtools.skipUnless(CONF.service_available.neutron,"},{"line_number":216,"context_line":"                          \u0027Neutron service must be available.\u0027)"},{"line_number":217,"context_line":"    # The following skipUnless test should be removed in Liberty"},{"line_number":218,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled."},{"line_number":219,"context_line":"                          allow_duplicate_networks,"},{"line_number":220,"context_line":"                          \u0027Duplicate networks must be allowed\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a41bdd9_431504e3","line":217,"in_reply_to":"9a41bdd9_3f009565","updated":"2015-07-18 01:40:17.000000000","message":"We can\u0027t remove the option until kilo-eol happens, which is when we\u0027d remove the skipUnless on the config option - we can\u0027t remove the skipUnless on the config option until kilo-eol since this code isn\u0027t on by default in juno and kilo so the test would fail there.","commit_id":"eda33251dab0ea26073ec2479465d8561fa3f9c1"},{"author":{"_account_id":8499,"name":"Racha Ben Ali","email":"benali@gmail.com","username":"rbenali"},"change_message_id":"149cdb031d3459611085884238bd8583820f868c","unresolved":false,"context_lines":[{"line_number":214,"context_line":"    @test.idempotent_id(\u00271678d144-ed74-43f8-8e57-ab10dbf9b3c2\u0027)"},{"line_number":215,"context_line":"    @testtools.skipUnless(CONF.service_available.neutron,"},{"line_number":216,"context_line":"                          \u0027Neutron service must be available.\u0027)"},{"line_number":217,"context_line":"    # The following skipUnless test should be removed in Liberty"},{"line_number":218,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled."},{"line_number":219,"context_line":"                          allow_duplicate_networks,"},{"line_number":220,"context_line":"                          \u0027Duplicate networks must be allowed\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a41bdd9_86dd5572","line":217,"in_reply_to":"9a41bdd9_431504e3","updated":"2015-07-20 00:03:16.000000000","message":"My bad. Wasn\u0027t referring to the current liberty cycle but to the future liberty release and wasn\u0027t following that this exact same tempest code is meant to be used to test that in juno and kilo as well.","commit_id":"eda33251dab0ea26073ec2479465d8561fa3f9c1"},{"author":{"_account_id":8499,"name":"Racha Ben Ali","email":"benali@gmail.com","username":"rbenali"},"change_message_id":"83ff3907f26d9f5b2227b46629654d5a6ea010f8","unresolved":false,"context_lines":[{"line_number":214,"context_line":"    @test.idempotent_id(\u00271678d144-ed74-43f8-8e57-ab10dbf9b3c2\u0027)"},{"line_number":215,"context_line":"    @testtools.skipUnless(CONF.service_available.neutron,"},{"line_number":216,"context_line":"                          \u0027Neutron service must be available.\u0027)"},{"line_number":217,"context_line":"    # The following skipUnless test should be removed in Liberty"},{"line_number":218,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled."},{"line_number":219,"context_line":"                          allow_duplicate_networks,"},{"line_number":220,"context_line":"                          \u0027Duplicate networks must be allowed\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a41bdd9_3f009565","line":217,"in_reply_to":"9a41bdd9_70dc1946","updated":"2015-07-15 19:15:41.000000000","message":"The comment is about the skip line below and not about the config option and that line should be removed (as a dependency patch) before removing the config option?","commit_id":"eda33251dab0ea26073ec2479465d8561fa3f9c1"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"d124b9012d60134d7fad6e1dbbf4db59ee69c050","unresolved":false,"context_lines":[{"line_number":235,"context_line":"            self.client.delete_server(server_multi_nics[\u0027id\u0027])"},{"line_number":236,"context_line":"            self.client.wait_for_server_termination(server_multi_nics[\u0027id\u0027])"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        self.addCleanup(cleanup_server)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        addresses \u003d self.client.list_addresses(server_multi_nics[\u0027id\u0027])"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a41bdd9_d44e596e","line":238,"updated":"2015-07-15 05:12:37.000000000","message":"The self.create_test_server() call you used above with handle resource cleanup as part of the teardownClass. (It adds the server to a list to delete at the end of the test class) You really only need to do this if you want a failure in deletion to be fatal. (which is a legitimate thing to want) I just wanted to clarify the intent before I gave it the thumbs up","commit_id":"eda33251dab0ea26073ec2479465d8561fa3f9c1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"539d1089362f653071dd1992bdba9a8a50ffa906","unresolved":false,"context_lines":[{"line_number":235,"context_line":"            self.client.delete_server(server_multi_nics[\u0027id\u0027])"},{"line_number":236,"context_line":"            self.client.wait_for_server_termination(server_multi_nics[\u0027id\u0027])"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        self.addCleanup(cleanup_server)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        addresses \u003d self.client.list_addresses(server_multi_nics[\u0027id\u0027])"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a41bdd9_b092a14a","line":238,"in_reply_to":"9a41bdd9_d44e596e","updated":"2015-07-15 15:48:25.000000000","message":"I assume this is only here because it\u0027s in test_verify_multiple_nics_order above and this test was copied from that more or less.","commit_id":"eda33251dab0ea26073ec2479465d8561fa3f9c1"},{"author":{"_account_id":8499,"name":"Racha Ben Ali","email":"benali@gmail.com","username":"rbenali"},"change_message_id":"83ff3907f26d9f5b2227b46629654d5a6ea010f8","unresolved":false,"context_lines":[{"line_number":235,"context_line":"            self.client.delete_server(server_multi_nics[\u0027id\u0027])"},{"line_number":236,"context_line":"            self.client.wait_for_server_termination(server_multi_nics[\u0027id\u0027])"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        self.addCleanup(cleanup_server)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        addresses \u003d self.client.list_addresses(server_multi_nics[\u0027id\u0027])"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a41bdd9_ec0ce9ed","line":238,"in_reply_to":"9a41bdd9_d44e596e","updated":"2015-07-15 19:15:41.000000000","message":"yes because the concern of this patch is just to test that a server can have more than one vnic on same net if config flag (for now) allows that.. I think probably also in case of exception, waiting for dependencies reverse cleanup of stacked resources should minimize subsequent side effects when continuing with running similar tests so I guess this function idempotency still hold regarding quotas, overlapping cidrs if neutron.allow_overlapping_ips is set to False, etc. or probably even collisions of net names rather than UUIDs as used as key below?","commit_id":"eda33251dab0ea26073ec2479465d8561fa3f9c1"}],"tempest/config.py":[{"author":{"_account_id":8499,"name":"Racha Ben Ali","email":"benali@gmail.com","username":"rbenali"},"change_message_id":"7dcc31995ae61d5b38ada5a5ee46cbc70d04b0c6","unresolved":false,"context_lines":[{"line_number":357,"context_line":"                default\u003dFalse,"},{"line_number":358,"context_line":"                help\u003d\u0027Does Nova preserve preexisting ports from Neutron \u0027"},{"line_number":359,"context_line":"                     \u0027when deleting an instance? This should be set to True \u0027"},{"line_number":360,"context_line":"                     \u0027if testing Kilo+ Nova.\u0027)"},{"line_number":361,"context_line":"    cfg.BoolOpt(\u0027allow_duplicate_networks\u0027,"},{"line_number":362,"context_line":"                default\u003dFalse,"},{"line_number":363,"context_line":"                help\u003d\u0027Does the test environment support creating instances \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_2d0dfe3e","line":360,"updated":"2015-03-25 07:56:47.000000000","message":"automatically resolve some git merge conflicts by appending a comma to last item in a python list?","commit_id":"d05b416c8affdc267d2f37bca143a091b3e41eec"}]}