)]}'
{"tempest/cmd/javelin.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"abd8ac7cc4fbbb198d5ada2840a63d99713bde74","unresolved":false,"context_lines":[{"line_number":458,"context_line":"                    for addr in body:"},{"line_number":459,"context_line":"                        ip \u003d addr[\u0027addr\u0027]"},{"line_number":460,"context_line":"                        # If use_floatingip_for_ssh is at True, we"},{"line_number":461,"context_line":"                        # consider we want to use the floating-ip"},{"line_number":462,"context_line":"                        # to reach the server, so no need to reach"},{"line_number":463,"context_line":"                        # the tenant network."},{"line_number":464,"context_line":"                        # This is useful in multi-node environment."}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_75e25d30","line":461,"updated":"2015-03-12 17:48:34.000000000","message":"s/we consider we want/it\u0027s assumed you want/","commit_id":"3d0242adf94b0b102e82e7dc79eece429629dbd0"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"2c2f9dc81e2de72499e6b04263a9cd9af0d8c1e6","unresolved":false,"context_lines":[{"line_number":458,"context_line":"                    for addr in body:"},{"line_number":459,"context_line":"                        ip \u003d addr[\u0027addr\u0027]"},{"line_number":460,"context_line":"                        # If use_floatingip_for_ssh is at True, we"},{"line_number":461,"context_line":"                        # consider we want to use the floating-ip"},{"line_number":462,"context_line":"                        # to reach the server, so no need to reach"},{"line_number":463,"context_line":"                        # the tenant network."},{"line_number":464,"context_line":"                        # This is useful in multi-node environment."}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_90827f50","line":461,"in_reply_to":"9a80dd14_75e25d30","updated":"2015-03-12 17:52:58.000000000","message":"Done","commit_id":"3d0242adf94b0b102e82e7dc79eece429629dbd0"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"2c2f9dc81e2de72499e6b04263a9cd9af0d8c1e6","unresolved":false,"context_lines":[{"line_number":466,"context_line":"                            if addr.get(\u0027OS-EXT-IPS:type\u0027,"},{"line_number":467,"context_line":"                                        \u0027floating\u0027) \u003d\u003d \u0027floating\u0027:"},{"line_number":468,"context_line":"                                self._ping_ip(ip, 60)"},{"line_number":469,"context_line":"                            else:"},{"line_number":470,"context_line":"                                break"},{"line_number":471,"context_line":"                        elif addr.get(\u0027OS-EXT-IPS:type\u0027, \u0027fixed\u0027) \u003d\u003d \u0027fixed\u0027:"},{"line_number":472,"context_line":"                            namespace \u003d _get_router_namespace(client,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_f0f65bf8","line":469,"updated":"2015-03-12 17:52:58.000000000","message":"this else/break is useless also.","commit_id":"3d0242adf94b0b102e82e7dc79eece429629dbd0"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"abd8ac7cc4fbbb198d5ada2840a63d99713bde74","unresolved":false,"context_lines":[{"line_number":882,"context_line":"                         disassociate_floating_ip_from_server(ip, res[\u0027id\u0027]))"},{"line_number":883,"context_line":"                        client.floating_ips.delete_floating_ip(ip)"},{"line_number":884,"context_line":"                    else:"},{"line_number":885,"context_line":"                        break"},{"line_number":886,"context_line":""},{"line_number":887,"context_line":"        client.servers.delete_server(res[\u0027id\u0027])"},{"line_number":888,"context_line":"        client.servers.wait_for_server_termination(res[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_d0579700","line":885,"updated":"2015-03-12 17:48:34.000000000","message":"your breaks might be wrong. they effectively nullify the loop","commit_id":"3d0242adf94b0b102e82e7dc79eece429629dbd0"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"2c2f9dc81e2de72499e6b04263a9cd9af0d8c1e6","unresolved":false,"context_lines":[{"line_number":882,"context_line":"                         disassociate_floating_ip_from_server(ip, res[\u0027id\u0027]))"},{"line_number":883,"context_line":"                        client.floating_ips.delete_floating_ip(ip)"},{"line_number":884,"context_line":"                    else:"},{"line_number":885,"context_line":"                        break"},{"line_number":886,"context_line":""},{"line_number":887,"context_line":"        client.servers.delete_server(res[\u0027id\u0027])"},{"line_number":888,"context_line":"        client.servers.wait_for_server_termination(res[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_902c3f4c","line":885,"in_reply_to":"9a80dd14_d0579700","updated":"2015-03-12 17:52:58.000000000","message":"for the second one, I\u0027m going to drop it but keep the break. We need can leave the loop once we find a floating IP, there is no need to continue.","commit_id":"3d0242adf94b0b102e82e7dc79eece429629dbd0"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"9323b9d22fff855c5be9773c8628090709e83bc0","unresolved":false,"context_lines":[{"line_number":464,"context_line":"                        # This is useful in multi-node environment."},{"line_number":465,"context_line":"                        if CONF.use_floatingip_for_ssh:"},{"line_number":466,"context_line":"                            if addr.get(\u0027OS-EXT-IPS:type\u0027,"},{"line_number":467,"context_line":"                                        \u0027floating\u0027) \u003d\u003d \u0027floating\u0027:"},{"line_number":468,"context_line":"                                self._ping_ip(ip, 60)"},{"line_number":469,"context_line":"                        elif addr.get(\u0027OS-EXT-IPS:type\u0027, \u0027fixed\u0027) \u003d\u003d \u0027fixed\u0027:"},{"line_number":470,"context_line":"                            namespace \u003d _get_router_namespace(client,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_fdb8ef76","line":467,"updated":"2015-03-12 19:24:41.000000000","message":"My only concern with this is that you never actually verify that the floating ip remains attached here. You could loop over all the addrs and have them all come back as fixed ips but that wouldn\u0027t error out. However, because use_floatingip_for_ssh is set there should be a floating ip set. (we created it during the  create phase)","commit_id":"edadb8c77860d3f517bcc3f19ced5cab231c0a3e"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"b1aad7a5b155f15779237ffe8889ec60fb435f76","unresolved":false,"context_lines":[{"line_number":461,"context_line":"                        # you want to use it to reach the server, otherwise"},{"line_number":462,"context_line":"                        # fallback to fixed IP, then other type."},{"line_number":463,"context_line":"                        # This is useful in multi-node environment."},{"line_number":464,"context_line":"                        if addr.get(\u0027OS-EXT-IPS:type\u0027,"},{"line_number":465,"context_line":"                                    \u0027floating\u0027) \u003d\u003d \u0027floating\u0027:"},{"line_number":466,"context_line":"                                self._ping_ip(ip, 60)"},{"line_number":467,"context_line":"                        elif addr.get(\u0027OS-EXT-IPS:type\u0027, \u0027fixed\u0027) \u003d\u003d \u0027fixed\u0027:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_968d0dd6","line":464,"updated":"2015-03-12 22:24:12.000000000","message":"This isn\u0027t going to work as expected. Because if there is fixed ip on the server then the pings below are going to fail assuming CONF.compute.use_floatingip_for_ssh is true. \n\nI would probably go back to the prev rev (with the conf if here) and then add a boolean variable outside set to false and inside this if set it to true after ping is called. Then after the loop check add another  if CONF.compute.use_floatingip_for_ssh is true and assertTrue the boolean variable.","commit_id":"1ad18c52b8ea1be579b21ae662df09de18e9ca14"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"20c40e8ce01a6e1fa04f089af5cce5b177f01c96","unresolved":false,"context_lines":[{"line_number":461,"context_line":"                        # you want to use it to reach the server, otherwise"},{"line_number":462,"context_line":"                        # fallback to fixed IP, then other type."},{"line_number":463,"context_line":"                        # This is useful in multi-node environment."},{"line_number":464,"context_line":"                        if addr.get(\u0027OS-EXT-IPS:type\u0027,"},{"line_number":465,"context_line":"                                    \u0027floating\u0027) \u003d\u003d \u0027floating\u0027:"},{"line_number":466,"context_line":"                                self._ping_ip(ip, 60)"},{"line_number":467,"context_line":"                        elif addr.get(\u0027OS-EXT-IPS:type\u0027, \u0027fixed\u0027) \u003d\u003d \u0027fixed\u0027:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_3940d2a4","line":464,"in_reply_to":"9a80dd14_968d0dd6","updated":"2015-03-12 22:41:57.000000000","message":"Done","commit_id":"1ad18c52b8ea1be579b21ae662df09de18e9ca14"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"b6438de86b1fc35f74d8ff5666f1921f08d783b5","unresolved":false,"context_lines":[{"line_number":461,"context_line":"                        # you want to use the floating IP to reach the server,"},{"line_number":462,"context_line":"                        # fallback to fixed IP, then other type."},{"line_number":463,"context_line":"                        # This is useful in multi-node environment."},{"line_number":464,"context_line":"                        _floating_is_alive \u003d False"},{"line_number":465,"context_line":"                        if CONF.use_floatingip_for_ssh:"},{"line_number":466,"context_line":"                            if addr.get(\u0027OS-EXT-IPS:type\u0027,"},{"line_number":467,"context_line":"                                        \u0027floating\u0027) \u003d\u003d \u0027floating\u0027:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_6f5c3c4c","line":464,"updated":"2015-03-12 23:49:23.000000000","message":"I don\u0027t think you can do this inside the inner loop otherwise the _floating_is_alive will most likely be False when you go to eval it after the inner loop. (unless the floating IP is always the last one in the list for each network label)\n\nI would move this to right above L457, or I guess if you want to verify the floating_ip for each if the found server\u0027s addresses above the inner loop. (I\u0027m not sure which is correct behavior to verify here)","commit_id":"1a7ac8a0aaa2a29823c73ce116ab28181cec6cc0"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"7f62242f57f0e8f88936de4f2108e34814f4357a","unresolved":false,"context_lines":[{"line_number":461,"context_line":"                        # you want to use the floating IP to reach the server,"},{"line_number":462,"context_line":"                        # fallback to fixed IP, then other type."},{"line_number":463,"context_line":"                        # This is useful in multi-node environment."},{"line_number":464,"context_line":"                        _floating_is_alive \u003d False"},{"line_number":465,"context_line":"                        if CONF.use_floatingip_for_ssh:"},{"line_number":466,"context_line":"                            if addr.get(\u0027OS-EXT-IPS:type\u0027,"},{"line_number":467,"context_line":"                                        \u0027floating\u0027) \u003d\u003d \u0027floating\u0027:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_ca5fd6e3","line":464,"in_reply_to":"9a80dd14_6f5c3c4c","updated":"2015-03-12 23:59:34.000000000","message":"Done","commit_id":"1a7ac8a0aaa2a29823c73ce116ab28181cec6cc0"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"0ed59df110da80b1290c6ee296c4d800bf098f18","unresolved":false,"context_lines":[{"line_number":475,"context_line":"                            self._ping_ip(ip, 60)"},{"line_number":476,"context_line":"                    # if floatingip_for_ssh is at True, validate found a"},{"line_number":477,"context_line":"                    # floating IP and ping worked."},{"line_number":478,"context_line":"                    if CONF.use_floatingip_for_ssh:"},{"line_number":479,"context_line":"                        self.assertTrue(_floating_is_alive,"},{"line_number":480,"context_line":"                                        \"Server %s has no floating IP.\" %"},{"line_number":481,"context_line":"                                        server[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_0ec55d8d","line":478,"updated":"2015-03-13 16:04:37.000000000","message":"So shouldn\u0027t this be after the outer loop? Otherwise you run the risk of failing based on the order of the network labels","commit_id":"2e564315212272c8b7b457d57b71f1a49380b091"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3bf9b4a2b1686465141601b3f4200faca1f0dbd0","unresolved":false,"context_lines":[{"line_number":475,"context_line":"                            self._ping_ip(ip, 60)"},{"line_number":476,"context_line":"                    # if floatingip_for_ssh is at True, validate found a"},{"line_number":477,"context_line":"                    # floating IP and ping worked."},{"line_number":478,"context_line":"                    if CONF.use_floatingip_for_ssh:"},{"line_number":479,"context_line":"                        self.assertTrue(_floating_is_alive,"},{"line_number":480,"context_line":"                                        \"Server %s has no floating IP.\" %"},{"line_number":481,"context_line":"                                        server[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_ee5ac9f0","line":478,"in_reply_to":"9a80dd14_0ec55d8d","updated":"2015-03-13 16:05:40.000000000","message":"Done","commit_id":"2e564315212272c8b7b457d57b71f1a49380b091"}]}