)]}'
{"tempest/common/service_client.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"db7dc94c54869f7e47e508acb4a12a097e4c3477","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"        # TODO(oomichi): This params setting should be removed after all"},{"line_number":26,"context_line":"        # service clients pass these values, and we can make ServiceClient"},{"line_number":27,"context_line":"        # free from CONF values."},{"line_number":28,"context_line":"        dscv \u003d disable_ssl_certificate_validation"},{"line_number":29,"context_line":"        params \u003d {"},{"line_number":30,"context_line":"            \u0027disable_ssl_certificate_validation\u0027: dscv,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_40e98f19","line":27,"updated":"2015-03-23 02:50:05.000000000","message":"We can remove the above TODO in this patch.","commit_id":"8e60a872b7c07d6877bb5609228f148fa9dbd9c5"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"db7dc94c54869f7e47e508acb4a12a097e4c3477","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        params \u003d {"},{"line_number":30,"context_line":"            \u0027disable_ssl_certificate_validation\u0027: dscv,"},{"line_number":31,"context_line":"            \u0027ca_certs\u0027: ca_certs,"},{"line_number":32,"context_line":"            \u0027trace_requests\u0027: trace_requests"},{"line_number":33,"context_line":"        }"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        if endpoint_type is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_e0927b9e","line":32,"updated":"2015-03-23 02:50:05.000000000","message":"If applying this patch, NegativeRestClient cannot use CONF values because it doesn\u0027t pass them to ServiceClient.\n\n 24 class NegativeRestClient(service_client.ServiceClient):\n 25     \"\"\"\n 26     Version of RestClient that does not raise exceptions.\n 27     \"\"\"\n 28     def __init__(self, auth_provider, service):\n 29         region \u003d self._get_region(service)\n 30         super(NegativeRestClient, self).__init__(auth_provider,\n 31                                                  service, region)\n\nSo it is necessary to move CONF values to NegativeRestClient or TestNegativeRestClient before this.","commit_id":"8e60a872b7c07d6877bb5609228f148fa9dbd9c5"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"98cf5b5a9449fb881201e12146ad7c156f7e52a2","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from tempest_lib.common import rest_client"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class ServiceClient(rest_client.RestClient):"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    def __init__(self, auth_provider, service, region,"},{"line_number":21,"context_line":"                 endpoint_type\u003dNone, build_interval\u003dNone, build_timeout\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_67f66fd9","line":18,"updated":"2015-03-24 02:20:53.000000000","message":"I\u0027m just curious is this wrapper class really needed anymore? All it does is pass through a bunch of params to the RestClient class now.\n\nI don\u0027t think this is worth blocking this patch over, but maybe in a follow up patch we should remove this and just switch to using RestClient as the parent of everything.","commit_id":"1e33e374cee02a9236b719533e3d67dbe665b9f8"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"7aa1d463c5a55c108b48169b7b8866ce705623ec","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from tempest_lib.common import rest_client"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class ServiceClient(rest_client.RestClient):"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    def __init__(self, auth_provider, service, region,"},{"line_number":21,"context_line":"                 endpoint_type\u003dNone, build_interval\u003dNone, build_timeout\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_eca86d79","line":18,"in_reply_to":"1a6ced46_67f66fd9","updated":"2015-03-24 14:23:03.000000000","message":"Maybe. But there is some value in having this abstraction. The RestClient and Service client are identitcal now in part because we put all of our needs in RestClient. But now that RestClient is its own thing not tied to tempest, in the future we might want to add something specific to tempest clients that would not be appropriate for RestClient. So I would be inclined to leave it, but don\u0027t feel strongly about that.","commit_id":"1e33e374cee02a9236b719533e3d67dbe665b9f8"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"98cf5b5a9449fb881201e12146ad7c156f7e52a2","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        super(ServiceClient, self).__init__(auth_provider, service, region,"},{"line_number":39,"context_line":"                                            **params)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class ResponseBody(dict):"},{"line_number":43,"context_line":"    \"\"\"Class that wraps an http response and dict body into a single value."},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_e7d89f55","line":41,"updated":"2015-03-24 02:20:53.000000000","message":"Also completely unrelated, I just realized these were added to tempest-lib in 0.4.0 into tempest_lib.common.rest_client so as a separate patch we probably should remove these copies too.","commit_id":"1e33e374cee02a9236b719533e3d67dbe665b9f8"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"7aa1d463c5a55c108b48169b7b8866ce705623ec","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        super(ServiceClient, self).__init__(auth_provider, service, region,"},{"line_number":39,"context_line":"                                            **params)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class ResponseBody(dict):"},{"line_number":43,"context_line":"    \"\"\"Class that wraps an http response and dict body into a single value."},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_0cdea911","line":41,"in_reply_to":"1a6ced46_e7d89f55","updated":"2015-03-24 14:23:03.000000000","message":"I will submit a follow on for this.","commit_id":"1e33e374cee02a9236b719533e3d67dbe665b9f8"}]}