)]}'
{"tempest/api/identity/base.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"ea5d0592f9fc6d2cf4cb7c8da14fd06241bcb463","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    @classmethod"},{"line_number":32,"context_line":"    def setup_credentials(cls):"},{"line_number":33,"context_line":"        super(BaseIdentityTest, cls).setup_credentials()"},{"line_number":34,"context_line":"        cls.os \u003d cls.get_client_manager()"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @classmethod"},{"line_number":37,"context_line":"    def disable_user(cls, user_name):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6ced46_3bb546cd","line":34,"updated":"2015-03-24 21:41:43.000000000","message":"This method will have to removed from the common base class and will have to be specific versions for v2 and v3. Since we need to add a parameter to get_client_manager to tell it which auth version to use.","commit_id":"86b1fdf9ad11589c196315849206d618d1c7f9fc"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"70588a9f60288c509a7673daea7a24bd7f837917","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    @classmethod"},{"line_number":32,"context_line":"    def setup_credentials(cls):"},{"line_number":33,"context_line":"        super(BaseIdentityTest, cls).setup_credentials()"},{"line_number":34,"context_line":"#        cls.os \u003d cls.get_client_manager()"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @classmethod"},{"line_number":37,"context_line":"    def disable_user(cls, user_name):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6ced46_c5018c07","line":34,"updated":"2015-03-25 17:03:38.000000000","message":"Probably should just drop this complete method here","commit_id":"d5e769fbca502818746b43e391a3a0b4c5508683"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"70588a9f60288c509a7673daea7a24bd7f837917","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    def skip_checks(cls):"},{"line_number":82,"context_line":"        super(BaseIdentityV2Test, cls).skip_checks()"},{"line_number":83,"context_line":"        if not CONF.identity_feature_enabled.api_v2:"},{"line_number":84,"context_line":"            raise cls.skipException(\"Identity api v2 is not enabled\")"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @classmethod"},{"line_number":87,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6ced46_48ce91b5","line":84,"updated":"2015-03-25 17:03:38.000000000","message":"This works fine but it least in my head skip_checks should be on top, because it\u0027s what\u0027s exec\u0027d first","commit_id":"d5e769fbca502818746b43e391a3a0b4c5508683"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"70588a9f60288c509a7673daea7a24bd7f837917","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    @classmethod"},{"line_number":110,"context_line":"    def skip_checks(cls):"},{"line_number":111,"context_line":"        super(BaseIdentityV2AdminTest, cls).skip_checks()"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @classmethod"},{"line_number":114,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6ced46_881fa907","line":111,"updated":"2015-03-25 17:03:38.000000000","message":"We probably should have a credentials.is_admin_available() check here, I believe dkranz has a patch up adding this everywhere.","commit_id":"d5e769fbca502818746b43e391a3a0b4c5508683"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"70588a9f60288c509a7673daea7a24bd7f837917","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    @classmethod"},{"line_number":170,"context_line":"    def skip_checks(cls):"},{"line_number":171,"context_line":"        super(BaseIdentityV3AdminTest, cls).skip_checks()"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    @classmethod"},{"line_number":174,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6ced46_e8bc9dde","line":171,"updated":"2015-03-25 17:03:38.000000000","message":"Same here with the admin check","commit_id":"d5e769fbca502818746b43e391a3a0b4c5508683"}],"tempest/api/identity/v2/test_tokens.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"6446d367039d509c00a40c32fe5587935cb48653","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from tempest import test"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class TokensTestJSON(base.BaseIdentityV2AdminTest):"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    @test.idempotent_id(\u002765ae3b78-91ff-467b-a705-f6678863b8ec\u0027)"},{"line_number":23,"context_line":"    def test_create_token(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6ced46_c38464b3","line":20,"updated":"2015-03-24 13:35:40.000000000","message":"The same comment about this requiring admin from the v3 test file, this needs to be a new base test class.","commit_id":"d05f64063edb0bb2144242ae10da97423b8fea5e"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"6446d367039d509c00a40c32fe5587935cb48653","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                                 tenant_name)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        self.assertEqual(body[\u0027token\u0027][\u0027tenant\u0027][\u0027name\u0027],"},{"line_number":39,"context_line":"                         tenant_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6ced46_83ec2c91","line":39,"updated":"2015-03-24 13:35:40.000000000","message":"Without knowing more details about the token response body off the top of my head, I\u0027m just wondering if there is more you want to assert in the response body.","commit_id":"d05f64063edb0bb2144242ae10da97423b8fea5e"}],"tempest/api/identity/v3/test_tokens.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"6446d367039d509c00a40c32fe5587935cb48653","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6ced46_83d50cbb","line":1,"updated":"2015-03-24 13:35:40.000000000","message":"Hmm, 88mph? :)","commit_id":"d05f64063edb0bb2144242ae10da97423b8fea5e"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"6446d367039d509c00a40c32fe5587935cb48653","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from tempest import test"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class TokensV3TestJSON(base.BaseIdentityV3AdminTest):"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    @test.idempotent_id(\u00276f8e4436-fc96-4282-8122-e41df57197a9\u0027)"},{"line_number":23,"context_line":"    def test_create_token(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6ced46_43cb141e","line":20,"updated":"2015-03-24 13:35:40.000000000","message":"The intent here is to not require admin credentials, however using the Admin base class as the parent will require this test to have admin credentials even though they aren\u0027t being used.\n\nTo do this correctly you need to make a base.BaseIdentityV3Test class that is the parent to base.BaseIdentityV3AdminTest. (so the admin will just overload the method definitions where needed to add admin stuff take a look at api.compute.base for an example) This test class with use BaseIdentityV3Test so that no admin creds will be allocated for this test.","commit_id":"d05f64063edb0bb2144242ae10da97423b8fea5e"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"836daed7ef64df4832cb88d88035b5d172073295","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from tempest import test"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class TokensV3TestJSON(base.BaseIdentityV3AdminTest):"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    @test.idempotent_id(\u00276f8e4436-fc96-4282-8122-e41df57197a9\u0027)"},{"line_number":23,"context_line":"    def test_create_token(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6ced46_ab965292","line":20,"in_reply_to":"1a6ced46_43cb141e","updated":"2015-03-24 17:15:04.000000000","message":"NIT: the JSON in the test names is legacy. I would not use it in new tests at all.","commit_id":"d05f64063edb0bb2144242ae10da97423b8fea5e"}]}