)]}'
{"tempest/hacking/checks.py":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"415f9d4d75b9e4b627838d39613066fde756e999","unresolved":false,"context_lines":[{"line_number":27,"context_line":"SETUP_TEARDOWN_CLASS_DEFINITION \u003d re.compile(r\u0027^\\s+def (setUp|tearDown)Class\u0027)"},{"line_number":28,"context_line":"SCENARIO_DECORATOR \u003d re.compile(r\u0027\\s*@.*services\\((.*)\\)\u0027)"},{"line_number":29,"context_line":"VI_HEADER_RE \u003d re.compile(r\"^#\\s+vim?:.+\")"},{"line_number":30,"context_line":"RAND_NAME_HYPHEN_RE \u003d re.compile(r\".+rand_name\\(.+[\\-\\_][\\\"\\\u0027]\\)\")"},{"line_number":31,"context_line":"mutable_default_args \u003d re.compile(r\"^\\s*def .+\\((.+\u003d\\{\\}|.+\u003d\\[\\])\")"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7a016987_43b4c033","line":30,"updated":"2015-05-20 12:01:45.000000000","message":"The first \u0027.+\u0027 should be \u0027.*\u0027 .","commit_id":"ce744eaac7ec4b10ab54a23c53347a7d2de9e6a9"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"544481e7b17bcb9b9f5cd186b691bd0fee4ff135","unresolved":false,"context_lines":[{"line_number":27,"context_line":"SETUP_TEARDOWN_CLASS_DEFINITION \u003d re.compile(r\u0027^\\s+def (setUp|tearDown)Class\u0027)"},{"line_number":28,"context_line":"SCENARIO_DECORATOR \u003d re.compile(r\u0027\\s*@.*services\\((.*)\\)\u0027)"},{"line_number":29,"context_line":"VI_HEADER_RE \u003d re.compile(r\"^#\\s+vim?:.+\")"},{"line_number":30,"context_line":"RAND_NAME_HYPHEN_RE \u003d re.compile(r\".+rand_name\\(.+[\\-\\_][\\\"\\\u0027]\\)\")"},{"line_number":31,"context_line":"mutable_default_args \u003d re.compile(r\"^\\s*def .+\\((.+\u003d\\{\\}|.+\u003d\\[\\])\")"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"fa32b979_0afd63b3","line":30,"in_reply_to":"7a016987_43b4c033","updated":"2015-06-18 00:29:37.000000000","message":"OK, will fix it.","commit_id":"ce744eaac7ec4b10ab54a23c53347a7d2de9e6a9"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"415f9d4d75b9e4b627838d39613066fde756e999","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                            \"T107: service tag should not be in path\")"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"def no_hyphen_at_end_of_rand_name(physical_line, filename):"},{"line_number":111,"context_line":"    \"\"\"Check no hyphen at the end of rand_name() argument"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    T108"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a016987_2339c4a4","line":110,"updated":"2015-05-20 12:01:45.000000000","message":"Why you don\u0027t use logical_line here ?","commit_id":"ce744eaac7ec4b10ab54a23c53347a7d2de9e6a9"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"544481e7b17bcb9b9f5cd186b691bd0fee4ff135","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                            \"T107: service tag should not be in path\")"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"def no_hyphen_at_end_of_rand_name(physical_line, filename):"},{"line_number":111,"context_line":"    \"\"\"Check no hyphen at the end of rand_name() argument"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    T108"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa32b979_2a4aa726","line":110,"in_reply_to":"7a016987_2339c4a4","updated":"2015-06-18 00:29:37.000000000","message":"ah, I forgot the reason.\nmaybe I copy\u0026paste this line from the other code.\n\nI agree with logical_line would be better because pep8.noqa check is not used and physical_line is not necessary.","commit_id":"ce744eaac7ec4b10ab54a23c53347a7d2de9e6a9"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"415f9d4d75b9e4b627838d39613066fde756e999","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    T108"},{"line_number":114,"context_line":"    \"\"\""},{"line_number":115,"context_line":"    if filename \u003d\u003d \u0027./tempest/tests/test_hacking.py\u0027:"},{"line_number":116,"context_line":"        return"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    if \u0027./tempest/api/network/\u0027 in filename:"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a016987_237664a4","line":115,"updated":"2015-05-20 12:01:45.000000000","message":"pep8 supports tests based on the doc string.:\nhttps://github.com/jcrocholl/pep8/blob/master/pep8.py#L1083","commit_id":"ce744eaac7ec4b10ab54a23c53347a7d2de9e6a9"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"544481e7b17bcb9b9f5cd186b691bd0fee4ff135","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    T108"},{"line_number":114,"context_line":"    \"\"\""},{"line_number":115,"context_line":"    if filename \u003d\u003d \u0027./tempest/tests/test_hacking.py\u0027:"},{"line_number":116,"context_line":"        return"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    if \u0027./tempest/api/network/\u0027 in filename:"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa32b979_2a714776","line":115,"in_reply_to":"7a016987_237664a4","updated":"2015-06-18 00:29:37.000000000","message":"Thanks, will try it.","commit_id":"ce744eaac7ec4b10ab54a23c53347a7d2de9e6a9"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"65a953a6288369b1dfcb4170628052f90b04b96d","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    T108"},{"line_number":114,"context_line":"    \"\"\""},{"line_number":115,"context_line":"    if filename \u003d\u003d \u0027./tempest/tests/test_hacking.py\u0027:"},{"line_number":116,"context_line":"        return"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    if \u0027./tempest/api/network/\u0027 in filename:"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa32b979_6ae98fb6","line":115,"in_reply_to":"fa32b979_2a714776","updated":"2015-06-18 00:49:43.000000000","message":"I tried to add doc string tests like the following, but it doesn\u0027t seem to work.\n\n T108\n \n +   Okay: data_utils.rand_name(\u0027resource\u0027)\n +   T108: data_utils.rand_name(\u0027resource-\u0027)\n +   T108: data_utils.rand_name(\u0027resource_\u0027)\n\nI tried to find a sample on the other projects, but I could not find it.\n\nBy switching to physical_line at the above, we can remove this ugly code anyway.","commit_id":"ce744eaac7ec4b10ab54a23c53347a7d2de9e6a9"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"24380d7fd5b5a6e1c8f6ccfa416073bbaff8685f","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    T108"},{"line_number":114,"context_line":"    \"\"\""},{"line_number":115,"context_line":"    if filename \u003d\u003d \u0027./tempest/tests/test_hacking.py\u0027:"},{"line_number":116,"context_line":"        return"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    if \u0027./tempest/api/network/\u0027 in filename:"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa32b979_ab243960","line":115,"in_reply_to":"fa32b979_6ae98fb6","updated":"2015-06-19 09:17:56.000000000","message":"Looks like you need to have the dev version of pep8 installed with the \u0027testsuite\u0027 and some other small things.\n\nAs I remember Long time ago we used the doc string magic,\nnow it is not as easy.","commit_id":"ce744eaac7ec4b10ab54a23c53347a7d2de9e6a9"}]}