)]}'
{"tempest/scenario/test_network_basic_ops.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"09517cdeffd4f05b71e04d00b89b54187b4d207b","unresolved":false,"context_lines":[{"line_number":682,"context_line":"        port1_ip_address \u003d ports[0][\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":683,"context_line":"        client \u003d self.network_client"},{"line_number":684,"context_line":"        external_network_id \u003d CONF.network.public_network_id"},{"line_number":685,"context_line":"        result \u003d client.create_floatingip("},{"line_number":686,"context_line":"            floating_network_id\u003dexternal_network_id,"},{"line_number":687,"context_line":"            port_id\u003dport1_id,"},{"line_number":688,"context_line":"            tenant_id\u003dserver[\u0027tenant_id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_b042f33c","line":685,"updated":"2015-03-31 13:59:33.000000000","message":"There\u0027s a helper function called create_floating_ip() in the NetworkScenarioTest class that you should use. It does what you\u0027re doing here.","commit_id":"c3ac54b55f16cf8d7eb5a6aadd26bac7e33b9d64"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"ee99c0c01ab3a76580da6b7e17f07de49029ec5c","unresolved":false,"context_lines":[{"line_number":682,"context_line":"        port1_ip_address \u003d ports[0][\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":683,"context_line":"        client \u003d self.network_client"},{"line_number":684,"context_line":"        external_network_id \u003d CONF.network.public_network_id"},{"line_number":685,"context_line":"        result \u003d client.create_floatingip("},{"line_number":686,"context_line":"            floating_network_id\u003dexternal_network_id,"},{"line_number":687,"context_line":"            port_id\u003dport1_id,"},{"line_number":688,"context_line":"            tenant_id\u003dserver[\u0027tenant_id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_d0e0d7fc","line":685,"in_reply_to":"da9b358b_b042f33c","updated":"2015-03-31 14:04:38.000000000","message":"yes u are correct, in that create_floating_ip function it is which interns calls a _get_server_port_id_and_ip4 function to get a port id but there self.assertEqual(len(ports), 1,  \"Unable to determine which port to target.\")\nis used to verify the number of ports.\nBut in my test case there are 2 ports, so i created floating ip separately in my test.","commit_id":"c3ac54b55f16cf8d7eb5a6aadd26bac7e33b9d64"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"c0590e66cd3063a1083dbc958a3e3526e5000208","unresolved":false,"context_lines":[{"line_number":682,"context_line":"        port1_ip_address \u003d ports[0][\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":683,"context_line":"        client \u003d self.network_client"},{"line_number":684,"context_line":"        external_network_id \u003d CONF.network.public_network_id"},{"line_number":685,"context_line":"        result \u003d client.create_floatingip("},{"line_number":686,"context_line":"            floating_network_id\u003dexternal_network_id,"},{"line_number":687,"context_line":"            port_id\u003dport1_id,"},{"line_number":688,"context_line":"            tenant_id\u003dserver[\u0027tenant_id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_9f7db81e","line":685,"in_reply_to":"da9b358b_d0e0d7fc","updated":"2015-03-31 15:29:31.000000000","message":"_get_server_port_id_and_ip4 should not be called if you provide a port_id. Which you do, right ? (port1_id)","commit_id":"c3ac54b55f16cf8d7eb5a6aadd26bac7e33b9d64"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"8e23397fa9dc4386fea6ef68d5674ae489aee468","unresolved":false,"context_lines":[{"line_number":682,"context_line":"        port1_ip_address \u003d ports[0][\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":683,"context_line":"        client \u003d self.network_client"},{"line_number":684,"context_line":"        external_network_id \u003d CONF.network.public_network_id"},{"line_number":685,"context_line":"        result \u003d client.create_floatingip("},{"line_number":686,"context_line":"            floating_network_id\u003dexternal_network_id,"},{"line_number":687,"context_line":"            port_id\u003dport1_id,"},{"line_number":688,"context_line":"            tenant_id\u003dserver[\u0027tenant_id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_29755a97","line":685,"in_reply_to":"da9b358b_d0e0d7fc","updated":"2015-04-01 05:13:22.000000000","message":"yes","commit_id":"c3ac54b55f16cf8d7eb5a6aadd26bac7e33b9d64"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"edbeae109073953c956381a4fdfa5f4365d8e824","unresolved":false,"context_lines":[{"line_number":679,"context_line":"                                                   network2)"},{"line_number":680,"context_line":"        ports \u003d self._list_ports(device_id\u003dserver[\u0027id\u0027])"},{"line_number":681,"context_line":"        port_id \u003d ports[0][\u0027id\u0027]"},{"line_number":682,"context_line":"        ext_net \u003d CONF.network.public_network_id"},{"line_number":683,"context_line":"        floating_ip \u003d self.create_floating_ip(server, ext_net, port_id)"},{"line_number":684,"context_line":"        self.floating_ip_tuple \u003d Floating_IP_tuple(floating_ip, server)"},{"line_number":685,"context_line":"        self._check_tenant_network_connectivity()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_1c06f61c","line":682,"updated":"2015-04-10 10:20:47.000000000","message":"This line is not needed. This is the default.","commit_id":"22c428ae046d8a22e4f6936dc0086c43c4e03526"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"2dc7fcaf8e8ba8cf617960e408e8764172f7ced1","unresolved":false,"context_lines":[{"line_number":679,"context_line":"                                                   network2)"},{"line_number":680,"context_line":"        ports \u003d self._list_ports(device_id\u003dserver[\u0027id\u0027])"},{"line_number":681,"context_line":"        port_id \u003d ports[0][\u0027id\u0027]"},{"line_number":682,"context_line":"        ext_net \u003d CONF.network.public_network_id"},{"line_number":683,"context_line":"        floating_ip \u003d self.create_floating_ip(server, ext_net, port_id)"},{"line_number":684,"context_line":"        self.floating_ip_tuple \u003d Floating_IP_tuple(floating_ip, server)"},{"line_number":685,"context_line":"        self._check_tenant_network_connectivity()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_bc4dca3f","line":682,"in_reply_to":"9aa53dc9_1c06f61c","updated":"2015-04-10 10:25:21.000000000","message":"yes, i made changes and uploaded a new patch","commit_id":"22c428ae046d8a22e4f6936dc0086c43c4e03526"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"edbeae109073953c956381a4fdfa5f4365d8e824","unresolved":false,"context_lines":[{"line_number":680,"context_line":"        ports \u003d self._list_ports(device_id\u003dserver[\u0027id\u0027])"},{"line_number":681,"context_line":"        port_id \u003d ports[0][\u0027id\u0027]"},{"line_number":682,"context_line":"        ext_net \u003d CONF.network.public_network_id"},{"line_number":683,"context_line":"        floating_ip \u003d self.create_floating_ip(server, ext_net, port_id)"},{"line_number":684,"context_line":"        self.floating_ip_tuple \u003d Floating_IP_tuple(floating_ip, server)"},{"line_number":685,"context_line":"        self._check_tenant_network_connectivity()"},{"line_number":686,"context_line":"        self.check_public_network_connectivity("}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_3c289a85","line":683,"updated":"2015-04-10 10:20:47.000000000","message":"floating_ip \u003d self.create_floating_ip(server, port_id\u003dport_id)\n\nshould be enough","commit_id":"22c428ae046d8a22e4f6936dc0086c43c4e03526"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"2dc7fcaf8e8ba8cf617960e408e8764172f7ced1","unresolved":false,"context_lines":[{"line_number":680,"context_line":"        ports \u003d self._list_ports(device_id\u003dserver[\u0027id\u0027])"},{"line_number":681,"context_line":"        port_id \u003d ports[0][\u0027id\u0027]"},{"line_number":682,"context_line":"        ext_net \u003d CONF.network.public_network_id"},{"line_number":683,"context_line":"        floating_ip \u003d self.create_floating_ip(server, ext_net, port_id)"},{"line_number":684,"context_line":"        self.floating_ip_tuple \u003d Floating_IP_tuple(floating_ip, server)"},{"line_number":685,"context_line":"        self._check_tenant_network_connectivity()"},{"line_number":686,"context_line":"        self.check_public_network_connectivity("}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_9c4a0625","line":683,"in_reply_to":"9aa53dc9_3c289a85","updated":"2015-04-10 10:25:21.000000000","message":"yes, i made changes and uploaded a new patch","commit_id":"22c428ae046d8a22e4f6936dc0086c43c4e03526"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"81e893dd77a63725e6fd6790251a4e6c302fd58b","unresolved":false,"context_lines":[{"line_number":793,"context_line":"        self._check_remote_connectivity(ssh_client, dest\u003dnew_net_dhcp,"},{"line_number":794,"context_line":"                                        nic\u003dspoof_nic, should_succeed\u003dTrue)"},{"line_number":795,"context_line":""},{"line_number":796,"context_line":"    def _create_server_multiple_nics(self, name, network1, network2):"},{"line_number":797,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":798,"context_line":"        self.keypairs[keypair[\u0027name\u0027]] \u003d keypair"},{"line_number":799,"context_line":"        security_groups \u003d [{\u0027name\u0027: self.security_group[\u0027name\u0027]}]"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a061dce_bd0a4388","line":796,"range":{"start_line":796,"start_character":8,"end_line":796,"end_character":36},"updated":"2016-04-06 19:35:49.000000000","message":"Why not extend _create_server to support multiple networks?","commit_id":"c5fcf5a44b791e273ea3fcbac2d7c7bd2236b084"}]}