)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"df3719366fcd719ccc8f4039492a2fc2560dfe03","unresolved":false,"context_lines":[{"line_number":310,"context_line":"        else:"},{"line_number":311,"context_line":"            addrs \u003d server_or_ip[\u0027addresses\u0027][CONF.compute.network_for_ssh]"},{"line_number":312,"context_line":"            ip \u003d (addr[\u0027addr\u0027] for addr in addrs if"},{"line_number":313,"context_line":"                  netaddr.valid_ipv4(addr[\u0027addr\u0027])).next()"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        if username is None:"},{"line_number":316,"context_line":"            username \u003d CONF.scenario.ssh_user"}],"source_content_type":"text/x-python","patch_set":10,"id":"9aa53dc9_79b914e9","line":313,"updated":"2015-04-07 15:37:12.000000000","message":"Right now if for whatever reason the list of addrs does not contain any valid v4 addresses this will explode with StopIteration which is not useful for debugging the failure at all.\n\nSo, I think we need to break this up into 2 steps, first use a list comprehension or another mechanism (it doesn\u0027t really matter how) to create a list of all the valid v4 addrs then check and make sure there is at least 1 before using it. Else raise an exception with a msg which explains why it failed.","commit_id":"ac2b2249429432722b4aa56c2e628b0f0de3c62d"},{"author":{"_account_id":13409,"name":"Andrew Boik","email":"drew.boik@gmail.com","username":"dboik"},"change_message_id":"f4555d1bf1a6800d3bedfb850c005dbb4a56bf8a","unresolved":false,"context_lines":[{"line_number":310,"context_line":"        else:"},{"line_number":311,"context_line":"            addrs \u003d server_or_ip[\u0027addresses\u0027][CONF.compute.network_for_ssh]"},{"line_number":312,"context_line":"            ip \u003d (addr[\u0027addr\u0027] for addr in addrs if"},{"line_number":313,"context_line":"                  netaddr.valid_ipv4(addr[\u0027addr\u0027])).next()"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        if username is None:"},{"line_number":316,"context_line":"            username \u003d CONF.scenario.ssh_user"}],"source_content_type":"text/x-python","patch_set":10,"id":"9aa53dc9_fd0f47df","line":313,"in_reply_to":"9aa53dc9_79b914e9","updated":"2015-04-07 18:19:58.000000000","message":"Good call. I just wrapped this in a try..except StopIteration in the next patch","commit_id":"ac2b2249429432722b4aa56c2e628b0f0de3c62d"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"ea79927b604e0d65583ae87e54083e09d9c64698","unresolved":false,"context_lines":[{"line_number":313,"context_line":"                ip \u003d (addr[\u0027addr\u0027] for addr in addrs if"},{"line_number":314,"context_line":"                      netaddr.valid_ipv4(addr[\u0027addr\u0027])).next()"},{"line_number":315,"context_line":"            except StopIteration:"},{"line_number":316,"context_line":"                raise Exception(\"No IPv4 addresses to use for SSH to \""},{"line_number":317,"context_line":"                                \"remote server.\")"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        if username is None:"}],"source_content_type":"text/x-python","patch_set":12,"id":"9aa53dc9_6db5497c","line":316,"updated":"2015-04-10 14:55:29.000000000","message":"I wonder if there is a better exception to be raising here. Exception seems kinda generic especially if we want to catch this at higher levels, since this is in a helper method. \n\nHow about something like: lib_exc.NotFound while not the most ideal (since it\u0027s a child of rest client exception and this isn\u0027t a rest call) it should at least provide a specific exception which can be caught by itself if needed. But, if you have a better one that would be fine too.","commit_id":"e2e1c769d7c0372868a25f41fc70569c85122e2f"},{"author":{"_account_id":13409,"name":"Andrew Boik","email":"drew.boik@gmail.com","username":"dboik"},"change_message_id":"da7dab2e67cdb5441a5023ad82252857154fcb75","unresolved":false,"context_lines":[{"line_number":313,"context_line":"                ip \u003d (addr[\u0027addr\u0027] for addr in addrs if"},{"line_number":314,"context_line":"                      netaddr.valid_ipv4(addr[\u0027addr\u0027])).next()"},{"line_number":315,"context_line":"            except StopIteration:"},{"line_number":316,"context_line":"                raise Exception(\"No IPv4 addresses to use for SSH to \""},{"line_number":317,"context_line":"                                \"remote server.\")"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        if username is None:"}],"source_content_type":"text/x-python","patch_set":12,"id":"7aaa499b_c740740a","line":316,"in_reply_to":"9aa53dc9_6db5497c","updated":"2015-04-10 17:25:00.000000000","message":"I guess that works. I couldn\u0027t find anything appropriate, which is why I just had Exception.","commit_id":"e2e1c769d7c0372868a25f41fc70569c85122e2f"}],"tempest/scenario/test_network_basic_ops.py":[{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"90b4b5776bbecba21af2489d931617f9a3ecf18f","unresolved":false,"context_lines":[{"line_number":320,"context_line":""},{"line_number":321,"context_line":"        subnets \u003d self._list_subnets("},{"line_number":322,"context_line":"            network_id\u003dCONF.network.public_network_id)"},{"line_number":323,"context_line":"        if CONF.network.public_network_dualstack:"},{"line_number":324,"context_line":"            self.assertEqual(2, len(subnets),"},{"line_number":325,"context_line":"                             \"Found %d subnets\" % len(subnets))"},{"line_number":326,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa963961_738815e8","line":323,"updated":"2015-03-27 18:19:02.000000000","message":"we can remove this flag and check there is one v4 subnet in the network.","commit_id":"46fcd475df4dc4ddbbea0f9a9888b980ffc626c1"}]}