)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"4711a4dae08a10bcd6c5e48c8c3a44704cf86816","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"[compute]"},{"line_number":27,"context_line":"..."},{"line_number":28,"context_line":"ssh_connect_method \u003d floating"},{"line_number":29,"context_line":"image_ssh_user \u003d cirros"},{"line_number":30,"context_line":"image_ssh_password \u003d cubswin:)"},{"line_number":31,"context_line":"ssh_auth_method \u003d configured  #default is keypair"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da9b358b_e8c54c5b","line":28,"updated":"2015-03-30 21:47:07.000000000","message":"I don\u0027t think the connect_method is relevant here.\nNothing in your code changes the behaviour around this parameter.","commit_id":"178de16439480944f746bdcf833ea9b176510ab3"}],"tempest/scenario/manager.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"4711a4dae08a10bcd6c5e48c8c3a44704cf86816","unresolved":false,"context_lines":[{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        if username is None:"},{"line_number":315,"context_line":"            username \u003d CONF.scenario.ssh_user"},{"line_number":316,"context_line":"        # Scenario testing should not ignore SSH cases. Also there is"},{"line_number":317,"context_line":"        # should_connect as the flag to decide whether to test ping and SSH."},{"line_number":318,"context_line":"        # So the ssh_auth_method should not be \u0027disabled\u0027. Login with keypair"},{"line_number":319,"context_line":"        # or username/password is the only two choices."}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_88a5a005","line":316,"updated":"2015-03-30 21:47:07.000000000","message":"A comment referring to the old behaviour will sound odd once the code is merge to someone reading it. It would be better to simply document the new behaviour here.","commit_id":"178de16439480944f746bdcf833ea9b176510ab3"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"4711a4dae08a10bcd6c5e48c8c3a44704cf86816","unresolved":false,"context_lines":[{"line_number":322,"context_line":"            if private_key is None:"},{"line_number":323,"context_line":"                private_key \u003d self.keypair[\u0027private_key\u0027]"},{"line_number":324,"context_line":"        else:"},{"line_number":325,"context_line":"            password \u003d CONF.compute.image_ssh_password"},{"line_number":326,"context_line":"            private_key \u003d None"},{"line_number":327,"context_line":"        linux_client \u003d remote_client.RemoteClient(ip, username,"},{"line_number":328,"context_line":"                                                  pkey\u003dprivate_key,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_081bd01c","line":325,"updated":"2015-03-30 21:47:07.000000000","message":"As you mention in the comment, it doesn\u0027t seem right to pick the password from the compute section. Compute API tests may use a different image compared to scenario ones. \nThe only other places where this parameter can be found in the code, it is used to inject the password in the created server. So this will probably work.\nI\u0027m not too happy with this, but is should be fine as the current configuration inconsistencies will be fixed by the ssh-auth-strategy bp anyways.","commit_id":"178de16439480944f746bdcf833ea9b176510ab3"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"0a9afa59b04334563ee96b6eeae8ebf8a9c2c2fb","unresolved":false,"context_lines":[{"line_number":315,"context_line":"            username \u003d CONF.scenario.ssh_user"},{"line_number":316,"context_line":"        # Set this with \u0027keypair\u0027 or others to log in with keypair or"},{"line_number":317,"context_line":"        # username/password."},{"line_number":318,"context_line":"        if CONF.compute.ssh_auth_method \u003d\u003d \u0027keypair\u0027:"},{"line_number":319,"context_line":"            password \u003d None"},{"line_number":320,"context_line":"            if private_key is None:"},{"line_number":321,"context_line":"                private_key \u003d self.keypair[\u0027private_key\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_0e6a80b3","line":318,"updated":"2015-04-08 19:58:25.000000000","message":"The original code is broken in not lookat that the value of ssh_auth_method, but the new version does not take into account the various documented options for that value.","commit_id":"896300ca7cd13749ad10609ade557b3140b2c269"}]}