)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"699aae90f79f3929e5bb5024616e3bd95b36473f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     abhishek60014726 \u003cabhishek.g-m@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-04-07 03:03:16 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Test Creeation of server in a shared_network"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add test to create a server in a shared network"},{"line_number":10,"context_line":"   -Create a shared network as a admin"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9aa53dc9_1e474178","line":7,"updated":"2015-04-09 07:00:59.000000000","message":"Extra \u0027e\u0027 in creation","commit_id":"f7088d5d21b9e8488690dad4f03110e6c3799369"}],"tempest/scenario/manager.py":[{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"b9c20526ed77eca15d49be26eb1934b091121ae9","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        # Heat client"},{"line_number":73,"context_line":"        cls.orchestration_client \u003d cls.manager.orchestration_client"},{"line_number":74,"context_line":"        try:"},{"line_number":75,"context_line":"            creds \u003d cls.isolated_creds.get_admin_creds()"},{"line_number":76,"context_line":"            cls.os_adm \u003d clients.Manager(credentials\u003dcreds)"},{"line_number":77,"context_line":"        except NotImplementedError:"},{"line_number":78,"context_line":"            msg \u003d (\"Missing Administrative Network API credentials \""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_dc6af0ec","line":75,"updated":"2015-06-17 22:00:12.000000000","message":"This will cause all scenario tests to require admin creds which is no good.","commit_id":"b2985b76bab6361b2af1afb1109963fea407ef58"}],"tempest/scenario/test_network_basic_ops.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"699aae90f79f3929e5bb5024616e3bd95b36473f","unresolved":false,"context_lines":[{"line_number":657,"context_line":"        network_id \u003d CONF.network.public_network_id"},{"line_number":658,"context_line":"        name \u003d \u0027shared_network\u0027"},{"line_number":659,"context_line":"        client \u003d self.admin_client"},{"line_number":660,"context_line":"        self.security_group \u003d \\"},{"line_number":661,"context_line":"            self._create_security_group(tenant_id\u003dself.tenant_id)"},{"line_number":662,"context_line":"        net_result \u003d client.create_network(name\u003dname, shared\u003dTrue)"},{"line_number":663,"context_line":"        network \u003d net_resources.DeletableNetwork(client\u003dclient,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa53dc9_3e6b25f3","line":660,"updated":"2015-04-09 07:00:59.000000000","message":"it is preferred to use () instead of /","commit_id":"f7088d5d21b9e8488690dad4f03110e6c3799369"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"0f9ca8e0d98cee31b26c61d03ebb08e35c590989","unresolved":false,"context_lines":[{"line_number":657,"context_line":"        network_id \u003d CONF.network.public_network_id"},{"line_number":658,"context_line":"        name \u003d \u0027shared_network\u0027"},{"line_number":659,"context_line":"        client \u003d self.admin_client"},{"line_number":660,"context_line":"        self.security_group \u003d \\"},{"line_number":661,"context_line":"            self._create_security_group(tenant_id\u003dself.tenant_id)"},{"line_number":662,"context_line":"        net_result \u003d client.create_network(name\u003dname, shared\u003dTrue)"},{"line_number":663,"context_line":"        network \u003d net_resources.DeletableNetwork(client\u003dclient,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa53dc9_490d15e7","line":660,"in_reply_to":"9aa53dc9_3e6b25f3","updated":"2015-04-09 07:15:20.000000000","message":"is this the way i need to use?\n\n        self.security_group \u003d (\n            self._create_security_group(tenant_id\u003dself.tenant_id))","commit_id":"f7088d5d21b9e8488690dad4f03110e6c3799369"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"71bd5d5bb68a44d934f812f0cc049067400d5c8b","unresolved":false,"context_lines":[{"line_number":657,"context_line":"        network_id \u003d CONF.network.public_network_id"},{"line_number":658,"context_line":"        name \u003d \u0027shared_network\u0027"},{"line_number":659,"context_line":"        client \u003d self.admin_client"},{"line_number":660,"context_line":"        self.security_group \u003d \\"},{"line_number":661,"context_line":"            self._create_security_group(tenant_id\u003dself.tenant_id)"},{"line_number":662,"context_line":"        net_result \u003d client.create_network(name\u003dname, shared\u003dTrue)"},{"line_number":663,"context_line":"        network \u003d net_resources.DeletableNetwork(client\u003dclient,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa53dc9_c9c6c567","line":660,"in_reply_to":"9aa53dc9_490d15e7","updated":"2015-04-09 07:19:08.000000000","message":"yes, exactly","commit_id":"f7088d5d21b9e8488690dad4f03110e6c3799369"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"addad19c6a00af05876961646ec5db27a781353f","unresolved":false,"context_lines":[{"line_number":657,"context_line":"        network_id \u003d CONF.network.public_network_id"},{"line_number":658,"context_line":"        name \u003d \u0027shared_network\u0027"},{"line_number":659,"context_line":"        client \u003d self.admin_client"},{"line_number":660,"context_line":"        self.security_group \u003d \\"},{"line_number":661,"context_line":"            self._create_security_group(tenant_id\u003dself.tenant_id)"},{"line_number":662,"context_line":"        net_result \u003d client.create_network(name\u003dname, shared\u003dTrue)"},{"line_number":663,"context_line":"        network \u003d net_resources.DeletableNetwork(client\u003dclient,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa53dc9_09982d77","line":660,"in_reply_to":"9aa53dc9_c9c6c567","updated":"2015-04-09 07:20:31.000000000","message":"ok thanks, will make changes and upload a  new patch","commit_id":"f7088d5d21b9e8488690dad4f03110e6c3799369"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"2706dc2dc8ccfc2612ba4de5252bf5282fc6ab50","unresolved":false,"context_lines":[{"line_number":661,"context_line":"    @test.idempotent_id(\u00272c0d5792-a04a-44e1-b95b-cbb9c4597c7e\u0027)"},{"line_number":662,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":663,"context_line":"    def test_creation_of_vm_in_shared_network(self):"},{"line_number":664,"context_line":"        network_id \u003d CONF.network.public_network_id"},{"line_number":665,"context_line":"        name \u003d \u0027shared_network\u0027"},{"line_number":666,"context_line":"        client \u003d self.admin_client"},{"line_number":667,"context_line":"        self.security_group \u003d ("}],"source_content_type":"text/x-python","patch_set":9,"id":"7a016987_ea671fe7","line":664,"updated":"2015-05-19 06:40:04.000000000","message":"The default value from public_network_id is \"\" ,  in case there is no shared id we should skip this test .  \nWhat do you think ?","commit_id":"b2985b76bab6361b2af1afb1109963fea407ef58"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"c288b93202225cc4062e87665d8fea8efc99a36f","unresolved":false,"context_lines":[{"line_number":661,"context_line":"    @test.idempotent_id(\u00272c0d5792-a04a-44e1-b95b-cbb9c4597c7e\u0027)"},{"line_number":662,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":663,"context_line":"    def test_creation_of_vm_in_shared_network(self):"},{"line_number":664,"context_line":"        network_id \u003d CONF.network.public_network_id"},{"line_number":665,"context_line":"        name \u003d \u0027shared_network\u0027"},{"line_number":666,"context_line":"        client \u003d self.admin_client"},{"line_number":667,"context_line":"        self.security_group \u003d ("}],"source_content_type":"text/x-python","patch_set":9,"id":"7a016987_8a2e6b41","line":664,"in_reply_to":"7a016987_ea671fe7","updated":"2015-05-19 06:53:59.000000000","message":"I am creating a shared network explicitly in my test case, --\u003e\nnet_result \u003d client.create_network(name\u003dname, shared\u003dTrue)","commit_id":"b2985b76bab6361b2af1afb1109963fea407ef58"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"200b1445f82563dc4971886afb6f898c6b10aed4","unresolved":false,"context_lines":[{"line_number":805,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":806,"context_line":"    @test.idempotent_id(\u00272c0d5792-a04a-44e1-b95b-cbb9c4597c7e\u0027)"},{"line_number":807,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":808,"context_line":"    def test_creation_of_vm_in_shared_network(self):"},{"line_number":809,"context_line":"        network_id \u003d CONF.network.public_network_id"},{"line_number":810,"context_line":"        name \u003d \u0027shared_network\u0027"},{"line_number":811,"context_line":"        client \u003d self.admin_manager.networks_client"}],"source_content_type":"text/x-python","patch_set":17,"id":"1ac06dbe_9afff033","line":808,"updated":"2016-08-19 23:10:50.000000000","message":"Code is node readable. What about adding empty lines to space the code ? L835,836 are not used. \n\nAlso I am pretty sure this is already tested.","commit_id":"d0b6ee48121d47a5edebb71507426eb6b8194d82"},{"author":{"_account_id":13342,"name":"Abhishek G M","email":"abhishek.gm@hpe.com","username":"abhishek60014726"},"change_message_id":"5f952136f4109b9b9afe50d242f9b819279fc235","unresolved":false,"context_lines":[{"line_number":805,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":806,"context_line":"    @test.idempotent_id(\u00272c0d5792-a04a-44e1-b95b-cbb9c4597c7e\u0027)"},{"line_number":807,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":808,"context_line":"    def test_creation_of_vm_in_shared_network(self):"},{"line_number":809,"context_line":"        network_id \u003d CONF.network.public_network_id"},{"line_number":810,"context_line":"        name \u003d \u0027shared_network\u0027"},{"line_number":811,"context_line":"        client \u003d self.admin_manager.networks_client"}],"source_content_type":"text/x-python","patch_set":17,"id":"1ac06dbe_f120a69d","line":808,"in_reply_to":"1ac06dbe_9afff033","updated":"2016-08-22 06:12:07.000000000","message":"I didn\u0027t added extra line at the end, I verified it by downloading the patch in my setup.\nI added one more line at the end to test for public connectivity.\nAnd i didn\u0027t find any shared network test case in test_network_basic_ops.py.","commit_id":"d0b6ee48121d47a5edebb71507426eb6b8194d82"}]}