)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10796,"name":"Deepak C Shetty (deepakcs)","email":"dpkshetty@gmail.com","username":"deepakcs"},"change_message_id":"811e80f0583da4aabb99d6a79a359e04c581565d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As part of \"test_volume_boot_pattern\" test case cleanup, current"},{"line_number":10,"context_line":"code deletes the snapshot before shutting down the vms."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Because of this, when cinder drivers, which supports assisted"},{"line_number":13,"context_line":"snapshots like \"GlusterFS\", calls nova to delete snapshots, it is"},{"line_number":14,"context_line":"failing."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9aa53dc9_92648149","line":11,"updated":"2015-04-08 15:07:36.000000000","message":"current code deletes snap before or after shutting down VMs, i think after, and hence the need for this patch, agree ?","commit_id":"27b3abefda75dd462d7cf3ba01cec58c11d82cc0"}],"tempest/scenario/test_volume_boot_pattern.py":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"4211ce1e941e1a277cbddc27e462bdc1d72826ce","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        except lib_exc.NotFound:"},{"line_number":181,"context_line":"            pass"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        self._stop_instances([instance_2nd, instance_from_snapshot])"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"class TestVolumeBootPatternV2(TestVolumeBootPattern):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_947a24f0","line":183,"updated":"2015-04-08 18:56:31.000000000","message":"It looks like the result of the test doesn\u0027t depend on whether we delete the snapshot before shutting the instance down or after. I applied this patch and ran the test. It had success. Then I placed your code block (lines 175-181) after line 183, i.e after stopping the instances and the test had success as well. I think (maybe I am wrong) the root cause of the issue is the cleanup order that actually matters for the snapshot. We cannot delete the volume till we are sure that the volume snapshot is really deleted. So I think we should use usual self.addCleanup(...), that does sync deletion, instead of self.addCleanup_with_wait(...) that does async deletion. See patch https://review.openstack.org/#/c/171569 .","commit_id":"284be2081de007f19a90959acb4869c72b2d142d"}]}