)]}'
{"tempest/common/accounts.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"80498c3f19188378a38542a4e31d1b8018c06f9b","unresolved":false,"context_lines":[{"line_number":218,"context_line":"                return _hash"},{"line_number":219,"context_line":"        raise AttributeError(\u0027Invalid credentials %s\u0027 % creds)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def remove_credentials(self, creds):"},{"line_number":222,"context_line":"        _hash \u003d self.get_hash(creds)"},{"line_number":223,"context_line":"        self.remove_hash(_hash)"},{"line_number":224,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7aaa499b_6f7d84e6","line":221,"updated":"2015-04-15 08:22:41.000000000","message":"how about adding log for releasing cred too for better debugging.","commit_id":"9ba4edae4e4e2e4744ddb4b2da08b5d232160532"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9d9ed3e3c5146dc6af25a87877e86bca2b20e910","unresolved":false,"context_lines":[{"line_number":218,"context_line":"                return _hash"},{"line_number":219,"context_line":"        raise AttributeError(\u0027Invalid credentials %s\u0027 % creds)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def remove_credentials(self, creds):"},{"line_number":222,"context_line":"        _hash \u003d self.get_hash(creds)"},{"line_number":223,"context_line":"        self.remove_hash(_hash)"},{"line_number":224,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7aaa499b_f2d97b84","line":221,"in_reply_to":"7aaa499b_6f7d84e6","updated":"2015-04-15 08:42:25.000000000","message":"So that we can get to know about both acquire and release of cred by tests.","commit_id":"9ba4edae4e4e2e4744ddb4b2da08b5d232160532"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"479952ff0ea127c976926bfce8b62979170d5903","unresolved":false,"context_lines":[{"line_number":218,"context_line":"                return _hash"},{"line_number":219,"context_line":"        raise AttributeError(\u0027Invalid credentials %s\u0027 % creds)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def remove_credentials(self, creds):"},{"line_number":222,"context_line":"        _hash \u003d self.get_hash(creds)"},{"line_number":223,"context_line":"        self.remove_hash(_hash)"},{"line_number":224,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5aa745d1_0723debe","line":221,"in_reply_to":"7aaa499b_f2d97b84","updated":"2015-04-16 14:28:28.000000000","message":"Good idea, I\u0027ll respin it right now","commit_id":"9ba4edae4e4e2e4744ddb4b2da08b5d232160532"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0ab5429a3f437abe5e8419c357fa2f167ecf3f77","unresolved":false,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    def remove_credentials(self, creds):"},{"line_number":226,"context_line":"        _hash \u003d self.get_hash(creds)"},{"line_number":227,"context_line":"        clean_creds \u003d self._sanitize_creds(self.hash_dict[\u0027creds\u0027][_hash])"},{"line_number":228,"context_line":"        self.remove_hash(_hash)"},{"line_number":229,"context_line":"        LOG.info(\"%s returned allocated creds:\\n%s\" % (self.name, clean_creds))"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dac4157f_380a7327","line":227,"updated":"2015-04-21 00:18:51.000000000","message":"param \u0027creds\u0027 can be used directly.","commit_id":"fd683e81cc776d295548f03a2603aa5fc39758d6"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"3885728c278fe5218171b8edd5e7b2769bc10aa4","unresolved":false,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    def remove_credentials(self, creds):"},{"line_number":226,"context_line":"        _hash \u003d self.get_hash(creds)"},{"line_number":227,"context_line":"        clean_creds \u003d self._sanitize_creds(self.hash_dict[\u0027creds\u0027][_hash])"},{"line_number":228,"context_line":"        self.remove_hash(_hash)"},{"line_number":229,"context_line":"        LOG.info(\"%s returned allocated creds:\\n%s\" % (self.name, clean_creds))"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dac4157f_6c5dcce8","line":227,"in_reply_to":"dac4157f_380a7327","updated":"2015-04-21 00:31:20.000000000","message":"Do you mean just pass the creds variable into sanitize_creds() by itself? If so look at the previous revs, it turns out that doesn\u0027t work because remove credentials gets passed a real Credentials object instead of a dict, which is what is required for _sanitize_creds().","commit_id":"fd683e81cc776d295548f03a2603aa5fc39758d6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e3dc266b9b7575190f36696897a73801d8318ac8","unresolved":false,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    def remove_credentials(self, creds):"},{"line_number":226,"context_line":"        _hash \u003d self.get_hash(creds)"},{"line_number":227,"context_line":"        clean_creds \u003d self._sanitize_creds(self.hash_dict[\u0027creds\u0027][_hash])"},{"line_number":228,"context_line":"        self.remove_hash(_hash)"},{"line_number":229,"context_line":"        LOG.info(\"%s returned allocated creds:\\n%s\" % (self.name, clean_creds))"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dac4157f_cc04d87f","line":227,"in_reply_to":"dac4157f_6c5dcce8","updated":"2015-04-21 00:45:33.000000000","message":"Ah, got it I thought its dict. Thanks","commit_id":"fd683e81cc776d295548f03a2603aa5fc39758d6"}]}