)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"68b7b50dce124583584855e1a49f9e85fe09a57b","unresolved":false,"context_lines":[{"line_number":16,"context_line":"ServerActionsTestJSON.test_resize_server_confirm"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The count of failed tests will be more than 3 if we run tests in"},{"line_number":19,"context_line":"parallel mode."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"The root cause of this is wrong cleanup order in the test"},{"line_number":22,"context_line":"\"test_rebuild_server\". In particular the issue is in these code lines:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_c2cfea7d","line":19,"updated":"2015-05-15 13:58:50.000000000","message":"I\u0027m not sure how parallel execution comes into play here. Tests execution inside of a class are serialized, so running tempest in parallel should not have an effect on this.","commit_id":"818d6202320ae31f91e561adbe8dae1917bda117"}],"tempest/api/compute/servers/test_server_actions.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"68b7b50dce124583584855e1a49f9e85fe09a57b","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        # If the server was rebuilt on a different image, restore it to the"},{"line_number":149,"context_line":"        # original image once the test ends"},{"line_number":150,"context_line":"        if self.image_ref_alt !\u003d self.image_ref:"},{"line_number":151,"context_line":"            self.client.rebuild(self.server_id, self.image_ref)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    @test.idempotent_id(\u002730449a88-5aff-4f9b-9866-6ee9b17f906d\u0027)"},{"line_number":154,"context_line":"    def test_rebuild_server_in_stop_state(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_227d9ee7","line":151,"updated":"2015-05-15 13:58:50.000000000","message":"So while this may fix an issue you\u0027re hitting on the good case it breaks the failure case. The reason addCleanup was used before was because it\u0027s always executed regardless of whether something fails. By, having this called in the test method it means if there is a failure above this point we won\u0027t execute the rebuild causing compound failures like what you reported.","commit_id":"818d6202320ae31f91e561adbe8dae1917bda117"}]}
