)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15736,"name":"Ritesh Anand","email":"tellrit@gmail.com","username":"ritesh"},"change_message_id":"562c331a810cbe385a9c4b8f2b4b412980e4dfb2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added negative test for DVR routers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Test uses administrative credentials to creates a"},{"line_number":10,"context_line":"Centralized Virtual router using the disributed\u003dFalse."},{"line_number":11,"context_line":"Then it will \"update\" the router\u0027s distributed attribute"},{"line_number":12,"context_line":"to True and validate appropriate exception raised."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba3cc151_a466d54e","line":9,"updated":"2015-07-02 20:33:09.000000000","message":"Looks like you are creating a DVR and updating it to be centralized.","commit_id":"d6ab39d8a48c99330c8ea15cf050053ab0bf4fe0"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"96a5c68afd34b521ab0c52328885e4dd62592271","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"439ffcf0_c8bbca9d","updated":"2022-02-14 02:31:59.000000000","message":"we do not need to add more negative tests in tempest, please check if this test coverage is there in neutron unit or functional tests.","commit_id":"081bc4fd7964c99ddfe3a568881ebf0e390b5cb5"}],"tempest/api/network/admin/test_routers_dvr_negative.py":[{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"5c713c0ef92ddd1d05a05c0efc1c5c01c277085a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    @classmethod"},{"line_number":29,"context_line":"    def skip_checks(cls):"},{"line_number":30,"context_line":"        super(DvrRoutersNegativeTest, cls).skip_checks()"},{"line_number":31,"context_line":"        if not test.is_extension_enabled(\u0027dvr\u0027, \u0027network\u0027):"},{"line_number":32,"context_line":"            msg \u003d \"DVR extension not enabled.\""},{"line_number":33,"context_line":"            raise cls.skipException(msg)"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba3cc151_da5c101b","line":31,"updated":"2015-07-02 21:12:50.000000000","message":"# The check above will pass if api_extensions\u003dall, which does\n not mean DVR extension itself is present. \nyou should check for the existance of the distributed flag in the created router. d\ntake a look at the following patch for a working example of a way to skip non-dvr setups: \nhttps://review.openstack.org/#/c/194792/","commit_id":"e9d6b66a8cc29d5104867ccc23836ce51a9ca42b"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"28033d0854841659ade8a777f1b42ae0e4525b5b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a41bdd9_47c6629b","line":1,"updated":"2015-07-14 01:16:44.000000000","message":"nit: 2015\n\nSince your e-mail address, are you working for ...","commit_id":"5e9606aae0c56d7c4b42c7e46fe9d9b0a240580c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"28033d0854841659ade8a777f1b42ae0e4525b5b","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027])"},{"line_number":50,"context_line":"    @test.idempotent_id(\u00270724fe9b-eb4f-4500-80fe-b142c39a117c\u0027)"},{"line_number":51,"context_line":"    def test_dvr_router_update_to_centralized_returns_notimplemented(self):"},{"line_number":52,"context_line":"        self.assertRaises(lib_exc.NotImplemented,"},{"line_number":53,"context_line":"                          self.admin_client.update_router,"},{"line_number":54,"context_line":"                          self.router[\u0027router\u0027][\u0027id\u0027], distributed\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a41bdd9_47e982e5","line":52,"updated":"2015-07-14 01:16:44.000000000","message":"We are not sure this http code is ideal or not because we are discussing this on API-WG(https://review.openstack.org/#/c/181283/).\nSo this test seems just fitting to current code.\n\nIf merging this test and we need to change the status code after that, we need to skip this test for merging Neutron side patch. So I -1 for blocking this situation.","commit_id":"5e9606aae0c56d7c4b42c7e46fe9d9b0a240580c"},{"author":{"_account_id":15736,"name":"Ritesh Anand","email":"tellrit@gmail.com","username":"ritesh"},"change_message_id":"7e6cea32d8ec065db33b5de0c10b89e0f675512d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (c) Copyright 2015,2016 Hewlett Packard Enterprise Development LP"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":10,"id":"9abb7d3a_cddf41d4","line":1,"updated":"2016-06-01 19:05:16.000000000","message":"Does 2016 instead of \"2015,2016\" make more sense ?","commit_id":"88cedc7b478540e4b71f5828921cd565f1e52990"},{"author":{"_account_id":15739,"name":"Hardik Italia","email":"hardik.italia@suse.com","username":"hitalia"},"change_message_id":"8a129aaac88c6696b7f3f55ddf2483d3fc889c48","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (c) Copyright 2015,2016 Hewlett Packard Enterprise Development LP"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_d17e02e3","line":1,"in_reply_to":"9abb7d3a_cddf41d4","updated":"2016-06-13 16:25:00.000000000","message":"Done","commit_id":"88cedc7b478540e4b71f5828921cd565f1e52990"}],"tempest/api/network/test_routers_negative.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"cce61ab414cda679f9cf533ff38aafc215039bc5","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        self.addCleanup(self.admin_client.delete_router,"},{"line_number":149,"context_line":"                        router[\u0027router\u0027][\u0027id\u0027])"},{"line_number":150,"context_line":"        self.assertTrue(router[\u0027router\u0027][\u0027distributed\u0027])"},{"line_number":151,"context_line":"        self.assertRaises(lib_exc.NotImplemented,"},{"line_number":152,"context_line":"                          lambda: self.admin_client.update_router"},{"line_number":153,"context_line":"                          (router[\u0027router\u0027][\u0027id\u0027], distributed\u003dFalse))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_9f710f47","line":151,"range":{"start_line":151,"start_character":7,"end_line":151,"end_character":9},"updated":"2015-05-19 05:52:56.000000000","message":"I am pretty sure you don\u0027t need a lambda here:\n\n self.assertRaises(lib_exc.NotImplemented, \nself.admin_client.update_router, router[\u0027router\u0027][\u0027id\u0027],  distributed\u003dFalse\n\nshould work","commit_id":"42f71e26a132f7ad2417140be886f26884ff68fb"},{"author":{"_account_id":15739,"name":"Hardik Italia","email":"hardik.italia@suse.com","username":"hitalia"},"change_message_id":"16ea9417514b447cbc63d8fc0ad4c91848938c89","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        self.addCleanup(self.admin_client.delete_router,"},{"line_number":149,"context_line":"                        router[\u0027router\u0027][\u0027id\u0027])"},{"line_number":150,"context_line":"        self.assertTrue(router[\u0027router\u0027][\u0027distributed\u0027])"},{"line_number":151,"context_line":"        self.assertRaises(lib_exc.NotImplemented,"},{"line_number":152,"context_line":"                          lambda: self.admin_client.update_router"},{"line_number":153,"context_line":"                          (router[\u0027router\u0027][\u0027id\u0027], distributed\u003dFalse))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_aaeda7b8","line":151,"in_reply_to":"7a016987_9f710f47","updated":"2015-05-19 07:21:35.000000000","message":"By removing lambda, testr is returning with \"test failed\" even though getting \"not implemented error\".\n\noutput from testr run:\n\nBody: {\"NotImplementedError\": {\"message\": \"\", \"type\": \"NotImplementedError\", \"detail\": \"\"}}\n\ntempest_lib.exceptions.NotImplemented: Got NotImplemented error\nDetails:\nRan 1 (+1) tests in 4.282s\nFAILED (id\u003d29, failures\u003d1 (+1))","commit_id":"42f71e26a132f7ad2417140be886f26884ff68fb"}]}