)]}'
{"tempest/api/compute/security_groups/test_security_groups_negative.py":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"817d050c7d42d7f2fb7d15d0ca943c2bc256f1fd","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    def test_security_group_create_with_invalid_group_description(self):"},{"line_number":92,"context_line":"        # Negative test: Security Group should not be created with description"},{"line_number":93,"context_line":"        # longer than 255 chars. Empty description is allowed by the API"},{"line_number":94,"context_line":"        # reference, however."},{"line_number":95,"context_line":"        s_name \u003d data_utils.rand_name(\u0027securitygroup\u0027)"},{"line_number":96,"context_line":"        # Create Security Group with group description longer than 255 chars"},{"line_number":97,"context_line":"        s_description \u003d \u0027description-\u0027.ljust(260, \u00270\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_5b0fa72e","line":94,"updated":"2015-05-25 20:24:24.000000000","message":"You talk about the empty string being wrong, but you also removed a check for just having whitespace...if that\u0027s intentional then you should probably describe why you\u0027re moving that check too.","commit_id":"2440387be72078688081f85f3f4007fc12f95b15"},{"author":{"_account_id":12561,"name":"Adrien Vergé","email":"adrienverge@gmail.com","username":"adrien.verge"},"change_message_id":"e483d246f2aac20c7324ea1e082b09350df863b0","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    def test_security_group_create_with_invalid_group_description(self):"},{"line_number":92,"context_line":"        # Negative test: Security Group should not be created with description"},{"line_number":93,"context_line":"        # longer than 255 chars. Empty description is allowed by the API"},{"line_number":94,"context_line":"        # reference, however."},{"line_number":95,"context_line":"        s_name \u003d data_utils.rand_name(\u0027securitygroup\u0027)"},{"line_number":96,"context_line":"        # Create Security Group with group description longer than 255 chars"},{"line_number":97,"context_line":"        s_description \u003d \u0027description-\u0027.ljust(260, \u00270\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_fb2413b3","line":94,"in_reply_to":"7a016987_5b0fa72e","updated":"2015-05-25 20:27:19.000000000","message":"No, the empty string is not wrong, neither is the whitespace. Both are *allowed* by the API (although I would not recommend to use the whitespace).","commit_id":"2440387be72078688081f85f3f4007fc12f95b15"},{"author":{"_account_id":12561,"name":"Adrien Vergé","email":"adrienverge@gmail.com","username":"adrien.verge"},"change_message_id":"ce234a7cf6c03ff38e2667665b89462200bd403f","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    def test_security_group_create_with_invalid_group_description(self):"},{"line_number":92,"context_line":"        # Negative test: Security Group should not be created with description"},{"line_number":93,"context_line":"        # longer than 255 chars. Empty description is allowed by the API"},{"line_number":94,"context_line":"        # reference, however."},{"line_number":95,"context_line":"        s_name \u003d data_utils.rand_name(\u0027securitygroup\u0027)"},{"line_number":96,"context_line":"        # Create Security Group with group description longer than 255 chars"},{"line_number":97,"context_line":"        s_description \u003d \u0027description-\u0027.ljust(260, \u00270\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_8d3962db","line":94,"in_reply_to":"7a016987_9b7f5f66","updated":"2015-05-25 21:57:38.000000000","message":"OK thanks for clarifying this!","commit_id":"2440387be72078688081f85f3f4007fc12f95b15"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"4a0507959e1030549aacb8aadb5ccf3e280856f0","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    def test_security_group_create_with_invalid_group_description(self):"},{"line_number":92,"context_line":"        # Negative test: Security Group should not be created with description"},{"line_number":93,"context_line":"        # longer than 255 chars. Empty description is allowed by the API"},{"line_number":94,"context_line":"        # reference, however."},{"line_number":95,"context_line":"        s_name \u003d data_utils.rand_name(\u0027securitygroup\u0027)"},{"line_number":96,"context_line":"        # Create Security Group with group description longer than 255 chars"},{"line_number":97,"context_line":"        s_description \u003d \u0027description-\u0027.ljust(260, \u00270\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_9b7f5f66","line":94,"in_reply_to":"7a016987_fb2413b3","updated":"2015-05-25 20:36:55.000000000","message":"Sorry, I was unclear.  Your commit message only talks about the test for empty string being incorrect, but then you also remove the test for whitespace.\n\nI\u0027m merely suggesting that you add to the git commit message a mention of the whitespace test being invalid as well.","commit_id":"2440387be72078688081f85f3f4007fc12f95b15"}]}