)]}'
{"tempest/services/image/v1/json/image_client.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7ad450866b61b9658e1efce1d101aa82c6582c39","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        return service_client.ResponseBodyList(resp, body[\u0027images\u0027])"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def image_list_detail(self, properties\u003ddict(), changes_since\u003dNone,"},{"line_number":216,"context_line":"                          **kwargs):"},{"line_number":217,"context_line":"        url \u003d \u0027v1/images/detail\u0027"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        params \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_b2e0f5fb","line":216,"updated":"2015-05-26 07:55:45.000000000","message":"This should be merged with list_images","commit_id":"e3acc12f619bbb88457e9f56acdaca5d9c2ff414"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a45daf93eedd9e189559a5e792f089db94f458d7","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        return service_client.ResponseBodyList(resp, body[\u0027images\u0027])"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def image_list_detail(self, properties\u003ddict(), changes_since\u003dNone,"},{"line_number":216,"context_line":"                          **kwargs):"},{"line_number":217,"context_line":"        url \u003d \u0027v1/images/detail\u0027"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        params \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_3bcba174","line":216,"in_reply_to":"7a016987_b2e0f5fb","updated":"2015-05-26 23:45:19.000000000","message":"ok. it there in https://review.openstack.org/#/c/184978/4","commit_id":"e3acc12f619bbb88457e9f56acdaca5d9c2ff414"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7ad450866b61b9658e1efce1d101aa82c6582c39","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        body \u003d json.loads(body)"},{"line_number":273,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    def add_member(self, member_id, image_id, can_share\u003dFalse):"},{"line_number":276,"context_line":"        url \u003d \u0027v1/images/%s/members/%s\u0027 % (image_id, member_id)"},{"line_number":277,"context_line":"        body \u003d None"},{"line_number":278,"context_line":"        if can_share:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_52c78164","line":275,"updated":"2015-05-26 07:55:45.000000000","message":"should we rename this too? something \u0027update_image_member()\u0027\nref - http://developer.openstack.org/api-ref-image-v1.html","commit_id":"e3acc12f619bbb88457e9f56acdaca5d9c2ff414"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5a37c06505f18d449f244a979c5d53795ab6df8e","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        body \u003d json.loads(body)"},{"line_number":273,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    def add_member(self, member_id, image_id, can_share\u003dFalse):"},{"line_number":276,"context_line":"        url \u003d \u0027v1/images/%s/members/%s\u0027 % (image_id, member_id)"},{"line_number":277,"context_line":"        body \u003d None"},{"line_number":278,"context_line":"        if can_share:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_928859c8","line":275,"in_reply_to":"7a016987_52c78164","updated":"2015-05-26 07:59:02.000000000","message":"Sorry this patch is just for GET.","commit_id":"e3acc12f619bbb88457e9f56acdaca5d9c2ff414"}],"tempest/services/image/v2/json/image_client.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7ad450866b61b9658e1efce1d101aa82c6582c39","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        \"\"\"Returns the primary type of resource this client works with.\"\"\""},{"line_number":134,"context_line":"        return \u0027image\u0027"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def store_image(self, image_id, data):"},{"line_number":137,"context_line":"        url \u003d \u0027v2/images/%s/file\u0027 % image_id"},{"line_number":138,"context_line":"        headers \u003d {\u0027Content-Type\u0027: \u0027application/octet-stream\u0027}"},{"line_number":139,"context_line":"        resp, body \u003d self.http.raw_request(\u0027PUT\u0027, url, headers\u003dheaders,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_72503d5f","line":136,"updated":"2015-05-26 07:55:45.000000000","message":"to make all put consistent, we should rename this too -\u003e \u0027update_binary_image_data\u0027\nref - http://developer.openstack.org/api-ref-image-v2.html","commit_id":"e3acc12f619bbb88457e9f56acdaca5d9c2ff414"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5a37c06505f18d449f244a979c5d53795ab6df8e","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        \"\"\"Returns the primary type of resource this client works with.\"\"\""},{"line_number":134,"context_line":"        return \u0027image\u0027"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def store_image(self, image_id, data):"},{"line_number":137,"context_line":"        url \u003d \u0027v2/images/%s/file\u0027 % image_id"},{"line_number":138,"context_line":"        headers \u003d {\u0027Content-Type\u0027: \u0027application/octet-stream\u0027}"},{"line_number":139,"context_line":"        resp, body \u003d self.http.raw_request(\u0027PUT\u0027, url, headers\u003dheaders,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_12bb4977","line":136,"in_reply_to":"7a016987_72503d5f","updated":"2015-05-26 07:59:02.000000000","message":"ditto. I think its going to be fixed in another patch.","commit_id":"e3acc12f619bbb88457e9f56acdaca5d9c2ff414"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7ad450866b61b9658e1efce1d101aa82c6582c39","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        self.expected_success(204, resp.status)"},{"line_number":142,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def get_image_file(self, image_id):"},{"line_number":145,"context_line":"        url \u003d \u0027v2/images/%s/file\u0027 % image_id"},{"line_number":146,"context_line":"        resp, body \u003d self.get(url)"},{"line_number":147,"context_line":"        self.expected_success(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_52766107","line":144,"updated":"2015-05-26 07:55:45.000000000","message":"this to \u0027get_binary_image_data\u0027\nref- http://developer.openstack.org/api-ref-image-v2.html","commit_id":"e3acc12f619bbb88457e9f56acdaca5d9c2ff414"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1ba99351c12e110e00eb88af3fb1dd4db11ed9b2","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        self.expected_success(204, resp.status)"},{"line_number":142,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def get_image_file(self, image_id):"},{"line_number":145,"context_line":"        url \u003d \u0027v2/images/%s/file\u0027 % image_id"},{"line_number":146,"context_line":"        resp, body \u003d self.get(url)"},{"line_number":147,"context_line":"        self.expected_success(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_94504660","line":144,"in_reply_to":"7a016987_52766107","updated":"2015-05-26 08:23:42.000000000","message":"This should be fixed in another patch","commit_id":"e3acc12f619bbb88457e9f56acdaca5d9c2ff414"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7ad450866b61b9658e1efce1d101aa82c6582c39","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":148,"context_line":"        return service_client.ResponseBodyData(resp, body)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def add_image_tag(self, image_id, tag):"},{"line_number":151,"context_line":"        url \u003d \u0027v2/images/%s/tags/%s\u0027 % (image_id, tag)"},{"line_number":152,"context_line":"        resp, body \u003d self.put(url, body\u003dNone)"},{"line_number":153,"context_line":"        self.expected_success(204, resp.status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_f27c2ded","line":150,"updated":"2015-05-26 07:55:45.000000000","message":"As it is PUT, should it be update_image_tag but add_image_tag is more clear as per http://developer.openstack.org/api-ref-image-v2.html. what you think should we rename add_*?","commit_id":"e3acc12f619bbb88457e9f56acdaca5d9c2ff414"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5a37c06505f18d449f244a979c5d53795ab6df8e","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":148,"context_line":"        return service_client.ResponseBodyData(resp, body)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def add_image_tag(self, image_id, tag):"},{"line_number":151,"context_line":"        url \u003d \u0027v2/images/%s/tags/%s\u0027 % (image_id, tag)"},{"line_number":152,"context_line":"        resp, body \u003d self.put(url, body\u003dNone)"},{"line_number":153,"context_line":"        self.expected_success(204, resp.status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_92af392b","line":150,"in_reply_to":"7a016987_f27c2ded","updated":"2015-05-26 07:59:02.000000000","message":"ditto","commit_id":"e3acc12f619bbb88457e9f56acdaca5d9c2ff414"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7ad450866b61b9658e1efce1d101aa82c6582c39","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        body \u003d json.loads(body)"},{"line_number":167,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def add_member(self, image_id, member_id):"},{"line_number":170,"context_line":"        url \u003d \u0027v2/images/%s/members\u0027 % image_id"},{"line_number":171,"context_line":"        data \u003d json.dumps({\u0027member\u0027: member_id})"},{"line_number":172,"context_line":"        resp, body \u003d self.post(url, data)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_f22e6df9","line":169,"updated":"2015-05-26 07:55:45.000000000","message":"This is POST. Should we rename this to something \u0027create_image_member()\u0027\nref - http://developer.openstack.org/api-ref-image-v2.html","commit_id":"e3acc12f619bbb88457e9f56acdaca5d9c2ff414"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5a37c06505f18d449f244a979c5d53795ab6df8e","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        body \u003d json.loads(body)"},{"line_number":167,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def add_member(self, image_id, member_id):"},{"line_number":170,"context_line":"        url \u003d \u0027v2/images/%s/members\u0027 % image_id"},{"line_number":171,"context_line":"        data \u003d json.dumps({\u0027member\u0027: member_id})"},{"line_number":172,"context_line":"        resp, body \u003d self.post(url, data)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_52a9c123","line":169,"in_reply_to":"7a016987_f22e6df9","updated":"2015-05-26 07:59:02.000000000","message":"ditto","commit_id":"e3acc12f619bbb88457e9f56acdaca5d9c2ff414"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7ad450866b61b9658e1efce1d101aa82c6582c39","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        body \u003d json.loads(body)"},{"line_number":175,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def update_member_status(self, image_id, member_id, status):"},{"line_number":178,"context_line":"        \"\"\"Valid status are: ``pending``, ``accepted``,  ``rejected``.\"\"\""},{"line_number":179,"context_line":"        url \u003d \u0027v2/images/%s/members/%s\u0027 % (image_id, member_id)"},{"line_number":180,"context_line":"        data \u003d json.dumps({\u0027status\u0027: status})"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_d2fc9174","line":177,"updated":"2015-05-26 07:55:45.000000000","message":"To make it consistent with API ref, should we rename it to  something \u0027update_image_member()\u0027\nref - http://developer.openstack.org/api-ref-image-v2.html","commit_id":"e3acc12f619bbb88457e9f56acdaca5d9c2ff414"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5a37c06505f18d449f244a979c5d53795ab6df8e","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        body \u003d json.loads(body)"},{"line_number":175,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def update_member_status(self, image_id, member_id, status):"},{"line_number":178,"context_line":"        \"\"\"Valid status are: ``pending``, ``accepted``,  ``rejected``.\"\"\""},{"line_number":179,"context_line":"        url \u003d \u0027v2/images/%s/members/%s\u0027 % (image_id, member_id)"},{"line_number":180,"context_line":"        data \u003d json.dumps({\u0027status\u0027: status})"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_32a64554","line":177,"in_reply_to":"7a016987_d2fc9174","updated":"2015-05-26 07:59:02.000000000","message":"ditto","commit_id":"e3acc12f619bbb88457e9f56acdaca5d9c2ff414"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7ad450866b61b9658e1efce1d101aa82c6582c39","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        resp, body \u003d self.get(url)"},{"line_number":189,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":190,"context_line":"        return service_client.ResponseBody(resp, json.loads(body))"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    def remove_member(self, image_id, member_id):"},{"line_number":193,"context_line":"        url \u003d \u0027v2/images/%s/members/%s\u0027 % (image_id, member_id)"},{"line_number":194,"context_line":"        resp, _ \u003d self.delete(url)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_f2078d7f","line":191,"updated":"2015-05-26 07:55:45.000000000","message":"-\u003edelete_member","commit_id":"e3acc12f619bbb88457e9f56acdaca5d9c2ff414"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5a37c06505f18d449f244a979c5d53795ab6df8e","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        resp, body \u003d self.get(url)"},{"line_number":189,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":190,"context_line":"        return service_client.ResponseBody(resp, json.loads(body))"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    def remove_member(self, image_id, member_id):"},{"line_number":193,"context_line":"        url \u003d \u0027v2/images/%s/members/%s\u0027 % (image_id, member_id)"},{"line_number":194,"context_line":"        resp, _ \u003d self.delete(url)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_f2666d28","line":191,"in_reply_to":"7a016987_f2078d7f","updated":"2015-05-26 07:59:02.000000000","message":"ditto","commit_id":"e3acc12f619bbb88457e9f56acdaca5d9c2ff414"}]}