)]}'
{"tempest/services/image/v2/json/image_client.py":[{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"0090acc2a522874610984231a8f18c3e1ede6204","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        body \u003d json.loads(body)"},{"line_number":184,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def show_image_member(self, image_id, member_id):"},{"line_number":187,"context_line":"        url \u003d \u0027v2/images/%s/members/%s\u0027 % (image_id, member_id)"},{"line_number":188,"context_line":"        resp, body \u003d self.get(url)"},{"line_number":189,"context_line":"        self.expected_success(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_906e752d","line":186,"updated":"2015-05-29 16:11:24.000000000","message":"IMO, consistency within a service client is just as important as between services. All the member methods should be the same. Before this change, list_image_members was the only member method that used \"image\" in the method name. Now there will be two. Considering that there are a different set of names that use \"image\" in the method name it would be better to make this \"show_member\" and change list_image_members to list_members.","commit_id":"716c736177600b1810cb982a3140ae85ddaf058f"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"d55dc9deebb6a4181fa62cddd6421b68da825a5f","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        body \u003d json.loads(body)"},{"line_number":184,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def show_image_member(self, image_id, member_id):"},{"line_number":187,"context_line":"        url \u003d \u0027v2/images/%s/members/%s\u0027 % (image_id, member_id)"},{"line_number":188,"context_line":"        resp, body \u003d self.get(url)"},{"line_number":189,"context_line":"        self.expected_success(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_a2bc55dc","line":186,"in_reply_to":"7a016987_2ada8c17","updated":"2015-06-01 14:11:31.000000000","message":"I don\u0027t think I was saying that. I was saying that there are two sets of methods on this class: \"image\" methods and \"member\" methods. The image methods have image in the name, and the member methods have member in the name, except for list_image_members which has both. Your change introduces another one that has both and I was just suggesting removing the existing one that has both rather than adding another. Another alternative would be to change all _member to image_member.","commit_id":"716c736177600b1810cb982a3140ae85ddaf058f"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"bdf7fa6ee1975cea3be498224da5e71b5f2896e2","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        body \u003d json.loads(body)"},{"line_number":184,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def show_image_member(self, image_id, member_id):"},{"line_number":187,"context_line":"        url \u003d \u0027v2/images/%s/members/%s\u0027 % (image_id, member_id)"},{"line_number":188,"context_line":"        resp, body \u003d self.get(url)"},{"line_number":189,"context_line":"        self.expected_success(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_2ada8c17","line":186,"in_reply_to":"7a016987_906e752d","updated":"2015-06-01 06:24:03.000000000","message":"@David\n\nIIUC, you are saying that \"image\" is already clarified on its service client class name and the method doesn\u0027t need to include it on its name.\nbut I don\u0027t agree with that because we don\u0027t change \"create_image\" to \"create\" even if a service client class name contains it.","commit_id":"716c736177600b1810cb982a3140ae85ddaf058f"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"82abce95a99b073783d879b275adb7244d6d92ab","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        body \u003d json.loads(body)"},{"line_number":184,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def show_image_member(self, image_id, member_id):"},{"line_number":187,"context_line":"        url \u003d \u0027v2/images/%s/members/%s\u0027 % (image_id, member_id)"},{"line_number":188,"context_line":"        resp, body \u003d self.get(url)"},{"line_number":189,"context_line":"        self.expected_success(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5afe65bd_f908912a","line":186,"in_reply_to":"7a016987_a2bc55dc","updated":"2015-06-01 23:45:59.000000000","message":"I got your point, thanks.\n\nAs the URL(v2/images/%s/members), I think all _member should be renamed to image_member for clarifying \"member\" meaning. So I will do it in a single patch.","commit_id":"716c736177600b1810cb982a3140ae85ddaf058f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b4629d5df8e080db040ef95ffa0a724c19115481","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        body \u003d json.loads(body)"},{"line_number":184,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def show_image_member(self, image_id, member_id):"},{"line_number":187,"context_line":"        url \u003d \u0027v2/images/%s/members/%s\u0027 % (image_id, member_id)"},{"line_number":188,"context_line":"        resp, body \u003d self.get(url)"},{"line_number":189,"context_line":"        self.expected_success(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5afe65bd_399bc9cb","line":186,"in_reply_to":"7a016987_a2bc55dc","updated":"2015-06-01 23:49:52.000000000","message":"Yes, we should have consistency between all methods. I think Ken\u0027ichi is going to change other in different patches. Like remove_member -\u003e delete_image_member etc.\n\nIMO having \"image\" and \"member\" both in method name gives more readability about methods. Same way as title of API in below doc- \nhttp://developer.openstack.org/api-ref-image-v2.html#members-v2","commit_id":"716c736177600b1810cb982a3140ae85ddaf058f"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"2dc2d54e8696cbd80328d4381fc8f5107b4ec547","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        self.expected_success(204, resp.status)"},{"line_number":142,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def show_image_file(self, image_id):"},{"line_number":145,"context_line":"        url \u003d \u0027v2/images/%s/file\u0027 % image_id"},{"line_number":146,"context_line":"        resp, body \u003d self.get(url)"},{"line_number":147,"context_line":"        self.expected_success(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3afb71cf_a1601002","line":144,"updated":"2015-06-09 19:00:01.000000000","message":"I don\u0027t think this makes sense. In this case the original name was not just inconsistent but bad. The other \"file\" method is called store_image so this should be load_image.  That makes more sense since this is returning the contents of the file.","commit_id":"7bf0cb5075c1456d3836a96dc70afc7cffad7c59"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"1e8da097cc3f6cd11614ca52d76ac07bdfb7494c","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        self.expected_success(204, resp.status)"},{"line_number":142,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def show_image_file(self, image_id):"},{"line_number":145,"context_line":"        url \u003d \u0027v2/images/%s/file\u0027 % image_id"},{"line_number":146,"context_line":"        resp, body \u003d self.get(url)"},{"line_number":147,"context_line":"        self.expected_success(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3afb71cf_1b082827","line":144,"in_reply_to":"3afb71cf_a1601002","updated":"2015-06-11 03:11:36.000000000","message":"nice point, I will do it.","commit_id":"7bf0cb5075c1456d3836a96dc70afc7cffad7c59"}]}