)]}'
{"tempest/api/compute/servers/test_server_actions.py":[{"author":{"_account_id":7055,"name":"Tapio Tallgren","username":"tapiotallgren","inactive":true},"change_message_id":"c78a1172982285e8334e084406c8ad822f69a752","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        try:"},{"line_number":44,"context_line":"            self.client.wait_for_server_status(self.server_id, \u0027ACTIVE\u0027)"},{"line_number":45,"context_line":"        except lib_exc.NotFound:"},{"line_number":46,"context_line":"            # The server was deleted by previous test, create a new one"},{"line_number":47,"context_line":"            server \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":48,"context_line":"            self.__class__.server_id \u003d server[\u0027id\u0027]"},{"line_number":49,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_948fc222","line":46,"updated":"2015-05-28 11:40:26.000000000","message":"It would better if test cases did not delete the images, or if there would be a separate module for tests that delete the image. However, since the servers do get deleted, this is a good workaround.","commit_id":"501da3ded7a031b1f68e88a4f1a594c965167d27"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"b67d6d5fb10eb5f8929b4bca24bdd094a53d1d7b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            # The server was deleted by previous test, create a new one"},{"line_number":47,"context_line":"            server \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":48,"context_line":"            self.__class__.server_id \u003d server[\u0027id\u0027]"},{"line_number":49,"context_line":"        else:"},{"line_number":50,"context_line":"            # Rebuild server if something happened to it during a test"},{"line_number":51,"context_line":"            self.__class__.server_id \u003d self.rebuild_server(self.server_id)"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_77824f54","line":49,"updated":"2015-06-02 15:33:11.000000000","message":"This else clause completely changes the logic of this method. I am sure it\u0027s not what you want.","commit_id":"501da3ded7a031b1f68e88a4f1a594c965167d27"},{"author":{"_account_id":14743,"name":"Viktor Tikkanen","email":"viktor.tikkanen@nokia.com","username":"vitikkan"},"change_message_id":"f4b1be7ae324f61a69d497e6640069337f068460","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            # The server was deleted by previous test, create a new one"},{"line_number":47,"context_line":"            server \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":48,"context_line":"            self.__class__.server_id \u003d server[\u0027id\u0027]"},{"line_number":49,"context_line":"        else:"},{"line_number":50,"context_line":"            # Rebuild server if something happened to it during a test"},{"line_number":51,"context_line":"            self.__class__.server_id \u003d self.rebuild_server(self.server_id)"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_9a096f2f","line":49,"in_reply_to":"5afe65bd_77312f0b","updated":"2015-06-02 16:02:45.000000000","message":"OK, got your point :)  Will replace else: with except:","commit_id":"501da3ded7a031b1f68e88a4f1a594c965167d27"},{"author":{"_account_id":14743,"name":"Viktor Tikkanen","email":"viktor.tikkanen@nokia.com","username":"vitikkan"},"change_message_id":"2f298526bdb61ff788ff8f573d5e1ba82eb6f9d8","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            # The server was deleted by previous test, create a new one"},{"line_number":47,"context_line":"            server \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":48,"context_line":"            self.__class__.server_id \u003d server[\u0027id\u0027]"},{"line_number":49,"context_line":"        else:"},{"line_number":50,"context_line":"            # Rebuild server if something happened to it during a test"},{"line_number":51,"context_line":"            self.__class__.server_id \u003d self.rebuild_server(self.server_id)"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_77312f0b","line":49,"in_reply_to":"5afe65bd_77824f54","updated":"2015-06-02 15:50:46.000000000","message":"Hmmm... If I understand right, the logic of this method is to reuse the instance created by previous test(s) if possible. If the existing instance is in somehow broken, it is rebuild. Added check just ensures that delete() is not called for non-existing instances. Of course, *_server_resize_* tests could be moved to a new module or rewritten so that they don\u0027t delete instances explicitely but this would be a bigger change...","commit_id":"501da3ded7a031b1f68e88a4f1a594c965167d27"}]}