)]}'
{"tempest/api/network/base.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"080ea94136ee2f1cbf2a502726ebf28f125d061d","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                cls._try_delete_resource(cls.client.delete_floatingip,"},{"line_number":125,"context_line":"                                         floating_ip[\u0027id\u0027])"},{"line_number":126,"context_line":"            # Clean up routers"},{"line_number":127,"context_line":"            for router in cls.routers:"},{"line_number":128,"context_line":"                cls._try_delete_resource(cls.delete_router,"},{"line_number":129,"context_line":"                                         router)"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5afe65bd_f2fa7fbc","line":127,"updated":"2015-06-04 05:43:08.000000000","message":"Have you consider fixing DVR to behave like central routers? This change seems innocent enough.","commit_id":"4b9a95a0cf2971098f073a4375397850d131f012"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ff14c5e5320228f8f47b65354d7ad26442e02a40","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                cls._try_delete_resource(cls.client.delete_floatingip,"},{"line_number":125,"context_line":"                                         floating_ip[\u0027id\u0027])"},{"line_number":126,"context_line":"            # Clean up routers"},{"line_number":127,"context_line":"            for router in cls.routers:"},{"line_number":128,"context_line":"                cls._try_delete_resource(cls.delete_router,"},{"line_number":129,"context_line":"                                         router)"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_d93b9f9b","line":127,"in_reply_to":"3afb71cf_b3c922af","updated":"2015-06-04 22:24:51.000000000","message":"great, so it sounds like the right fix would be to add method resource_cleanup to L3AgentSchedulerTestJSON to make sure that no dangling resource is left behind.","commit_id":"4b9a95a0cf2971098f073a4375397850d131f012"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"bc1d12cab4823bc37fc83565ec60c3c28a1e0d98","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                cls._try_delete_resource(cls.client.delete_floatingip,"},{"line_number":125,"context_line":"                                         floating_ip[\u0027id\u0027])"},{"line_number":126,"context_line":"            # Clean up routers"},{"line_number":127,"context_line":"            for router in cls.routers:"},{"line_number":128,"context_line":"                cls._try_delete_resource(cls.delete_router,"},{"line_number":129,"context_line":"                                         router)"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_8e727c7b","line":127,"in_reply_to":"3afb71cf_d93b9f9b","updated":"2015-06-04 23:48:58.000000000","message":"Yes I fixed the L3AgentSchedulerTestJSON class by adding resource_cleanup method.\n\nhttps://review.openstack.org/#/c/188630/","commit_id":"4b9a95a0cf2971098f073a4375397850d131f012"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"fcc8c16194ec3bcf50897f1892c92ce90319ee6e","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                cls._try_delete_resource(cls.client.delete_floatingip,"},{"line_number":125,"context_line":"                                         floating_ip[\u0027id\u0027])"},{"line_number":126,"context_line":"            # Clean up routers"},{"line_number":127,"context_line":"            for router in cls.routers:"},{"line_number":128,"context_line":"                cls._try_delete_resource(cls.delete_router,"},{"line_number":129,"context_line":"                                         router)"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5afe65bd_ef395aa5","line":127,"in_reply_to":"5afe65bd_0c54c41e","updated":"2015-06-04 17:05:38.000000000","message":"Also if a router owns the interface ports or gateway ports, those ports, should be removed before you try to delete the router.","commit_id":"4b9a95a0cf2971098f073a4375397850d131f012"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"aa194b44b247c8a14fb6058568286955d9f8072a","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                cls._try_delete_resource(cls.client.delete_floatingip,"},{"line_number":125,"context_line":"                                         floating_ip[\u0027id\u0027])"},{"line_number":126,"context_line":"            # Clean up routers"},{"line_number":127,"context_line":"            for router in cls.routers:"},{"line_number":128,"context_line":"                cls._try_delete_resource(cls.delete_router,"},{"line_number":129,"context_line":"                                         router)"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5afe65bd_e03969a5","line":127,"in_reply_to":"5afe65bd_221c2969","updated":"2015-06-04 18:31:26.000000000","message":"Let me recheck the behavior why the centralized router is allowing to delete the port after the router has been deleted and not the dvr routers.\n\nBut to me the whole sequence here is messed up, we normally delete the ports first and then delete the routers.","commit_id":"4b9a95a0cf2971098f073a4375397850d131f012"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"93d73f9f85819d280f26d30ea234a3ef23ada30d","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                cls._try_delete_resource(cls.client.delete_floatingip,"},{"line_number":125,"context_line":"                                         floating_ip[\u0027id\u0027])"},{"line_number":126,"context_line":"            # Clean up routers"},{"line_number":127,"context_line":"            for router in cls.routers:"},{"line_number":128,"context_line":"                cls._try_delete_resource(cls.delete_router,"},{"line_number":129,"context_line":"                                         router)"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_b3c922af","line":127,"in_reply_to":"5afe65bd_80b755f4","updated":"2015-06-04 21:26:50.000000000","message":"Armando, Ok I think I found out the answer why it is passing for Legacy centralized routers and not for \"DVR Routers\".\n\nRemember there was bug with the DVR scheduler not able to schedule a router without any subnet attached to the Router. But the centralized routers were able to do it.\n\nSo we fixed it by making this test aware of the DVR routers and only when DVR router is enabled, we add an interface to the router before scheduling the router.\nSee the patch below.\nhttps://review.openstack.org/#/c/165246/\n\nThat is the reason, that only with DVR routers, now the port deletion fails. That is the right behavior.\n\nIn the case of centralized routers, it is not failing because, there is no router-interface-ports attached to the router in this specific test case.\n\nHope this helps.","commit_id":"4b9a95a0cf2971098f073a4375397850d131f012"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"8b0911ddba28bb263d5880465ad9767b4c7a4f57","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                cls._try_delete_resource(cls.client.delete_floatingip,"},{"line_number":125,"context_line":"                                         floating_ip[\u0027id\u0027])"},{"line_number":126,"context_line":"            # Clean up routers"},{"line_number":127,"context_line":"            for router in cls.routers:"},{"line_number":128,"context_line":"                cls._try_delete_resource(cls.delete_router,"},{"line_number":129,"context_line":"                                         router)"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5afe65bd_80b755f4","line":127,"in_reply_to":"5afe65bd_e03969a5","updated":"2015-06-04 18:36:31.000000000","message":"\u003e But to me the whole sequence here is messed up, we normally delete the ports first and then delete the routers.\n\nNot really, order shouldn\u0027t really matter, and the ports being collected in cls.ports are not necessarily the ones that belong to routers.","commit_id":"4b9a95a0cf2971098f073a4375397850d131f012"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"9face2bdce6c8d231fd4fdf20cd8095505acaad5","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                cls._try_delete_resource(cls.client.delete_floatingip,"},{"line_number":125,"context_line":"                                         floating_ip[\u0027id\u0027])"},{"line_number":126,"context_line":"            # Clean up routers"},{"line_number":127,"context_line":"            for router in cls.routers:"},{"line_number":128,"context_line":"                cls._try_delete_resource(cls.delete_router,"},{"line_number":129,"context_line":"                                         router)"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5afe65bd_221c2969","line":127,"in_reply_to":"5afe65bd_ef395aa5","updated":"2015-06-04 17:21:32.000000000","message":"I am not fully sure what is going on, but it sounds to me that we can better align the behavior of both types of routers, because the regular job doesn\u0027t fail and the dvr one does.","commit_id":"4b9a95a0cf2971098f073a4375397850d131f012"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"d014ffde53ce372d729d2e23cfc834765f3971b5","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                cls._try_delete_resource(cls.client.delete_floatingip,"},{"line_number":125,"context_line":"                                         floating_ip[\u0027id\u0027])"},{"line_number":126,"context_line":"            # Clean up routers"},{"line_number":127,"context_line":"            for router in cls.routers:"},{"line_number":128,"context_line":"                cls._try_delete_resource(cls.delete_router,"},{"line_number":129,"context_line":"                                         router)"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5afe65bd_0c54c41e","line":127,"in_reply_to":"5afe65bd_f2fa7fbc","updated":"2015-06-04 16:58:12.000000000","message":"Aramando, this was based on the fix that was similar to centralized routers, that internal admin only owned ports should not be allowed to be deleted directly by using delete_ports.\n\nhttps://review.openstack.org/#/c/159679/2","commit_id":"4b9a95a0cf2971098f073a4375397850d131f012"}]}