)]}'
{"tempest/api/network/admin/test_l3_agent_scheduler.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6dfe8f713b2d89c6d410af80bbb03051967c56eb","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    @classmethod"},{"line_number":85,"context_line":"    def resource_cleanup(cls):"},{"line_number":86,"context_line":"        if test.is_extension_enabled(\u0027dvr\u0027, \u0027network\u0027):"},{"line_number":87,"context_line":"            is_dvr_router \u003d cls.admin_client.show_router("},{"line_number":88,"context_line":"                cls.router[\u0027id\u0027])[\u0027router\u0027].get(\u0027distributed\u0027, False)"},{"line_number":89,"context_line":"            if is_dvr_router:"},{"line_number":90,"context_line":"                cls.client.remove_router_interface_with_port_id("}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_2ed8281d","line":87,"updated":"2015-06-05 00:02:44.000000000","message":"maybe we can keep this as class member to avoid calling more than once.","commit_id":"a6b9a18bacc1f4a1aec2f95f397f41f7886d04a5"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"d0d4173b198da5b4059d4827f041e662016df70f","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    @classmethod"},{"line_number":85,"context_line":"    def resource_cleanup(cls):"},{"line_number":86,"context_line":"        if test.is_extension_enabled(\u0027dvr\u0027, \u0027network\u0027):"},{"line_number":87,"context_line":"            is_dvr_router \u003d cls.admin_client.show_router("},{"line_number":88,"context_line":"                cls.router[\u0027id\u0027])[\u0027router\u0027].get(\u0027distributed\u0027, False)"},{"line_number":89,"context_line":"            if is_dvr_router:"},{"line_number":90,"context_line":"                cls.client.remove_router_interface_with_port_id("}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_41e7b540","line":87,"in_reply_to":"3afb71cf_2ed8281d","updated":"2015-06-05 00:25:21.000000000","message":"Done","commit_id":"a6b9a18bacc1f4a1aec2f95f397f41f7886d04a5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b04aa9b9c4eab2849c1130660756cdcc3c7a9228","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                cls.client.remove_router_interface_with_port_id("},{"line_number":91,"context_line":"                    cls.router[\u0027id\u0027], cls.port[\u0027id\u0027])"},{"line_number":92,"context_line":"                cls.client.delete_subnet(cls.subnet[\u0027id\u0027])"},{"line_number":93,"context_line":"        super(L3AgentSchedulerTestJSON, cls).resource_setup()"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    @test.idempotent_id(\u0027b7ce6e89-e837-4ded-9b78-9ed3c9c6a45a\u0027)"},{"line_number":96,"context_line":"    def test_list_routers_on_l3_agent(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_8ed15cfe","line":93,"updated":"2015-06-04 23:59:54.000000000","message":"this is cleanup","commit_id":"a6b9a18bacc1f4a1aec2f95f397f41f7886d04a5"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"d0d4173b198da5b4059d4827f041e662016df70f","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                cls.client.remove_router_interface_with_port_id("},{"line_number":91,"context_line":"                    cls.router[\u0027id\u0027], cls.port[\u0027id\u0027])"},{"line_number":92,"context_line":"                cls.client.delete_subnet(cls.subnet[\u0027id\u0027])"},{"line_number":93,"context_line":"        super(L3AgentSchedulerTestJSON, cls).resource_setup()"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    @test.idempotent_id(\u0027b7ce6e89-e837-4ded-9b78-9ed3c9c6a45a\u0027)"},{"line_number":96,"context_line":"    def test_list_routers_on_l3_agent(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_0e044c7c","line":93,"in_reply_to":"3afb71cf_8ed15cfe","updated":"2015-06-05 00:25:21.000000000","message":"sorry too quick, copy paste error.\nWill fix it.","commit_id":"a6b9a18bacc1f4a1aec2f95f397f41f7886d04a5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f2073ebc08224283b0f8b34882e85456fcdb9408","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    The l3_agent_scheduler extension is required for these tests."},{"line_number":41,"context_line":"    \"\"\""},{"line_number":42,"context_line":"    _is_dvr_router \u003d False"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @classmethod"},{"line_number":45,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_21bb9910","line":42,"updated":"2015-06-05 00:26:54.000000000","message":"we don\u0027t need this.","commit_id":"36d9e6632cafad44ccb5667fe339b9536f1760c6"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"611758dec65eaf031aa9a6cae0b9fa8348eab1a9","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    The l3_agent_scheduler extension is required for these tests."},{"line_number":41,"context_line":"    \"\"\""},{"line_number":42,"context_line":"    _is_dvr_router \u003d False"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @classmethod"},{"line_number":45,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_411a1519","line":42,"in_reply_to":"3afb71cf_21bb9910","updated":"2015-06-05 00:45:18.000000000","message":"Done","commit_id":"36d9e6632cafad44ccb5667fe339b9536f1760c6"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f2073ebc08224283b0f8b34882e85456fcdb9408","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        # query and setup steps are only required if the extension is available"},{"line_number":73,"context_line":"        # and only if the router\u0027s default type is distributed."},{"line_number":74,"context_line":"        if test.is_extension_enabled(\u0027dvr\u0027, \u0027network\u0027):"},{"line_number":75,"context_line":"            cls._is_dvr_router \u003d cls.admin_client.show_router("},{"line_number":76,"context_line":"                cls.router[\u0027id\u0027])[\u0027router\u0027].get(\u0027distributed\u0027, False)"},{"line_number":77,"context_line":"            if cls._is_dvr_router:"},{"line_number":78,"context_line":"                cls.network \u003d cls.create_network()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_e13b419b","line":75,"updated":"2015-06-05 00:26:54.000000000","message":"this can simply be:\n\ncls.is_dvr_router\n\njust like we\u0027re initializing the other class members","commit_id":"36d9e6632cafad44ccb5667fe339b9536f1760c6"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"611758dec65eaf031aa9a6cae0b9fa8348eab1a9","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        # query and setup steps are only required if the extension is available"},{"line_number":73,"context_line":"        # and only if the router\u0027s default type is distributed."},{"line_number":74,"context_line":"        if test.is_extension_enabled(\u0027dvr\u0027, \u0027network\u0027):"},{"line_number":75,"context_line":"            cls._is_dvr_router \u003d cls.admin_client.show_router("},{"line_number":76,"context_line":"                cls.router[\u0027id\u0027])[\u0027router\u0027].get(\u0027distributed\u0027, False)"},{"line_number":77,"context_line":"            if cls._is_dvr_router:"},{"line_number":78,"context_line":"                cls.network \u003d cls.create_network()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_a113090d","line":75,"in_reply_to":"3afb71cf_e13b419b","updated":"2015-06-05 00:45:18.000000000","message":"ok will fix it.","commit_id":"36d9e6632cafad44ccb5667fe339b9536f1760c6"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"5aa07f78cfc8fbfbfa243611cf33cec657275db3","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                cls.router[\u0027id\u0027])[\u0027router\u0027].get(\u0027distributed\u0027, False)"},{"line_number":77,"context_line":"            if cls.is_dvr_router:"},{"line_number":78,"context_line":"                cls.network \u003d cls.create_network()"},{"line_number":79,"context_line":"                cls.create_subnet(cls.network)"},{"line_number":80,"context_line":"                cls.port \u003d cls.create_port(cls.network)"},{"line_number":81,"context_line":"                cls.client.add_router_interface_with_port_id("},{"line_number":82,"context_line":"                    cls.router[\u0027id\u0027], cls.port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afb71cf_ba48ce88","line":79,"updated":"2015-06-05 02:53:33.000000000","message":"you\u0027re not keeping the subnet for use afterwards","commit_id":"ebe65e3e7e1bf980d0d26580b49b8697e5d5546d"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"c98d8759de895a5b668fbd666f73b3ea86a36ad2","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                cls.router[\u0027id\u0027])[\u0027router\u0027].get(\u0027distributed\u0027, False)"},{"line_number":77,"context_line":"            if cls.is_dvr_router:"},{"line_number":78,"context_line":"                cls.network \u003d cls.create_network()"},{"line_number":79,"context_line":"                cls.create_subnet(cls.network)"},{"line_number":80,"context_line":"                cls.port \u003d cls.create_port(cls.network)"},{"line_number":81,"context_line":"                cls.client.add_router_interface_with_port_id("},{"line_number":82,"context_line":"                    cls.router[\u0027id\u0027], cls.port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afb71cf_0a485b5a","line":79,"in_reply_to":"3afb71cf_ba48ce88","updated":"2015-06-08 17:02:25.000000000","message":"Done","commit_id":"ebe65e3e7e1bf980d0d26580b49b8697e5d5546d"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"5aa07f78cfc8fbfbfa243611cf33cec657275db3","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        if cls.is_dvr_router:"},{"line_number":87,"context_line":"            cls.client.remove_router_interface_with_port_id("},{"line_number":88,"context_line":"                cls.router[\u0027id\u0027], cls.port[\u0027id\u0027])"},{"line_number":89,"context_line":"            cls.client.delete_subnet(cls.subnet[\u0027id\u0027])"},{"line_number":90,"context_line":"        super(L3AgentSchedulerTestJSON, cls).resource_cleanup()"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @test.idempotent_id(\u0027b7ce6e89-e837-4ded-9b78-9ed3c9c6a45a\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afb71cf_3a7e1eaf","line":89,"updated":"2015-06-05 02:53:33.000000000","message":"you\u0027d need to keep the subnet.","commit_id":"ebe65e3e7e1bf980d0d26580b49b8697e5d5546d"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"c98d8759de895a5b668fbd666f73b3ea86a36ad2","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        if cls.is_dvr_router:"},{"line_number":87,"context_line":"            cls.client.remove_router_interface_with_port_id("},{"line_number":88,"context_line":"                cls.router[\u0027id\u0027], cls.port[\u0027id\u0027])"},{"line_number":89,"context_line":"            cls.client.delete_subnet(cls.subnet[\u0027id\u0027])"},{"line_number":90,"context_line":"        super(L3AgentSchedulerTestJSON, cls).resource_cleanup()"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @test.idempotent_id(\u0027b7ce6e89-e837-4ded-9b78-9ed3c9c6a45a\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afb71cf_ca780392","line":89,"in_reply_to":"3afb71cf_3a7e1eaf","updated":"2015-06-08 17:02:25.000000000","message":"Done","commit_id":"ebe65e3e7e1bf980d0d26580b49b8697e5d5546d"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"98e192fe11700cd89e113ec68778f7b7ab23a8d4","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                cls.router[\u0027id\u0027])[\u0027router\u0027].get(\u0027distributed\u0027, False)"},{"line_number":77,"context_line":"            if cls.is_dvr_router:"},{"line_number":78,"context_line":"                cls.network \u003d cls.create_network()"},{"line_number":79,"context_line":"                cls.subnet \u003d cls.create_subnet(cls.network)"},{"line_number":80,"context_line":"                cls.port \u003d cls.create_port(cls.network)"},{"line_number":81,"context_line":"                cls.client.add_router_interface_with_port_id("},{"line_number":82,"context_line":"                    cls.router[\u0027id\u0027], cls.port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"3afb71cf_ec795f83","line":79,"updated":"2015-06-09 19:05:12.000000000","message":"Not worth a -1 but this line did not need to be changed.","commit_id":"ae82c97f8b5968750be89dd96e216dcf085cb671"}]}