)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"66df0a4e08539991417ac8080998482df40a4031","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Currently, for IsolatedCreds provider, new tenant/user will be created for"},{"line_number":10,"context_line":"testing. However, the user password is hardcoded(with \u0027pass\u0027 as the"},{"line_number":11,"context_line":"default) in the implementation. This patch change that to make password"},{"line_number":12,"context_line":"for user creation configurable."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I36d64e6313a5b4edc03acad64bcdaeab680f9ce0"},{"line_number":15,"context_line":"Implements: blueprint password-configurable"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3afb71cf_5cea4575","line":12,"updated":"2015-06-10 09:31:52.000000000","message":"Not justified why does it needed.","commit_id":"dc5bab21e0be59db7f6243ef09b2e6a9def5e72e"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"66df0a4e08539991417ac8080998482df40a4031","unresolved":false,"context_lines":[{"line_number":12,"context_line":"for user creation configurable."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I36d64e6313a5b4edc03acad64bcdaeab680f9ce0"},{"line_number":15,"context_line":"Implements: blueprint password-configurable"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3afb71cf_bcf1396d","line":15,"updated":"2015-06-10 09:31:52.000000000","message":"The referenced bp does not exists.","commit_id":"dc5bab21e0be59db7f6243ef09b2e6a9def5e72e"}],"tempest/common/cred_provider.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3daef08acf5d18c1614c8968c2771a47c6fe382d","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                    credentials when credentials are provisioned on the fly"},{"line_number":109,"context_line":"        :param network_resources Network resources required for the credentials"},{"line_number":110,"context_line":"        \"\"\""},{"line_number":111,"context_line":"        # TODO(andreaf) name and password are tenant isolation specific, and"},{"line_number":112,"context_line":"        # could be removed from this abstract class"},{"line_number":113,"context_line":"        self.name \u003d name or \"test_creds\""},{"line_number":114,"context_line":"        self.identity_version \u003d identity_version or CONF.identity.auth_version"}],"source_content_type":"text/x-python","patch_set":6,"id":"3afb71cf_605c0b19","line":111,"updated":"2015-06-11 02:44:16.000000000","message":"Please remove \u0027password\u0027 from this TODO also","commit_id":"208c20da2a03c293107ded3ca9df8e7755a40bd4"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"424ae280e63f48ae54e82364c6331ce8a8d76ed0","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                    credentials when credentials are provisioned on the fly"},{"line_number":109,"context_line":"        :param network_resources Network resources required for the credentials"},{"line_number":110,"context_line":"        \"\"\""},{"line_number":111,"context_line":"        # TODO(andreaf) name and password are tenant isolation specific, and"},{"line_number":112,"context_line":"        # could be removed from this abstract class"},{"line_number":113,"context_line":"        self.name \u003d name or \"test_creds\""},{"line_number":114,"context_line":"        self.identity_version \u003d identity_version or CONF.identity.auth_version"}],"source_content_type":"text/x-python","patch_set":6,"id":"3afb71cf_b8deb3da","line":111,"in_reply_to":"3afb71cf_605c0b19","updated":"2015-06-11 08:21:33.000000000","message":"Done","commit_id":"208c20da2a03c293107ded3ca9df8e7755a40bd4"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"7cba58da0f45790ef2e2c112d32b7654c4c5bc27","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                    credentials when credentials are provisioned on the fly"},{"line_number":109,"context_line":"        :param network_resources Network resources required for the credentials"},{"line_number":110,"context_line":"        \"\"\""},{"line_number":111,"context_line":"        # TODO(andreaf) name is tenant isolation specific, and could be"},{"line_number":112,"context_line":"        # removed from this abstract class"},{"line_number":113,"context_line":"        self.name \u003d name or \"test_creds\""},{"line_number":114,"context_line":"        self.identity_version \u003d identity_version or CONF.identity.auth_version"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_84b162e2","line":111,"updated":"2015-06-24 17:02:59.000000000","message":"So this whole comment is no longer true after this patch, name is used to track the classes using creds in the other providers too. Not worth - 1ing the patch over though.","commit_id":"c0a529b01a3ee327dcf2dc20592309ac9f2d0d66"}],"tempest/common/isolated_creds.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3daef08acf5d18c1614c8968c2771a47c6fe382d","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        self.network_resources \u003d network_resources"},{"line_number":144,"context_line":"        self.isolated_creds \u003d {}"},{"line_number":145,"context_line":"        self.ports \u003d []"},{"line_number":146,"context_line":"        self.password \u003d data_utils.rand_password()"},{"line_number":147,"context_line":"        self.default_admin_creds \u003d cred_provider.get_configured_credentials("},{"line_number":148,"context_line":"            \u0027identity_admin\u0027, fill_in\u003dTrue,"},{"line_number":149,"context_line":"            identity_version\u003dself.identity_version)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3afb71cf_c0c73f94","line":146,"updated":"2015-06-11 02:44:16.000000000","message":"1 suggestion - how about moving this to _create_creds() as local variable now.","commit_id":"208c20da2a03c293107ded3ca9df8e7755a40bd4"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"424ae280e63f48ae54e82364c6331ce8a8d76ed0","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        self.network_resources \u003d network_resources"},{"line_number":144,"context_line":"        self.isolated_creds \u003d {}"},{"line_number":145,"context_line":"        self.ports \u003d []"},{"line_number":146,"context_line":"        self.password \u003d data_utils.rand_password()"},{"line_number":147,"context_line":"        self.default_admin_creds \u003d cred_provider.get_configured_credentials("},{"line_number":148,"context_line":"            \u0027identity_admin\u0027, fill_in\u003dTrue,"},{"line_number":149,"context_line":"            identity_version\u003dself.identity_version)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3afb71cf_987537cc","line":146,"in_reply_to":"3afb71cf_c0c73f94","updated":"2015-06-11 08:21:33.000000000","message":"yes, it\u0027s reasonable!","commit_id":"208c20da2a03c293107ded3ca9df8e7755a40bd4"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"8fd415d3d85a3d8399325a55e1abab65a1062cd8","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            name\u003dproject_name, description\u003dproject_desc)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        username \u003d data_utils.rand_name(root) + suffix"},{"line_number":195,"context_line":"        user_password \u003d data_utils.rand_password()"},{"line_number":196,"context_line":"        email \u003d data_utils.rand_name(root) + suffix + \"@example.com\""},{"line_number":197,"context_line":"        user \u003d self.creds_client.create_user("},{"line_number":198,"context_line":"            username, user_password, project, email)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_9fc19ee6","line":195,"updated":"2015-06-25 02:27:28.000000000","message":"looks like you remove the password from init , means no deault pass allowed.\nCould you set a default as None in init and override it\nif not user_password:\n   user_password \u003d data_utils.rand_password()","commit_id":"c0a529b01a3ee327dcf2dc20592309ac9f2d0d66"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"65ec744984132070f16e217afdc3846817e44189","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            name\u003dproject_name, description\u003dproject_desc)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        username \u003d data_utils.rand_name(root) + suffix"},{"line_number":195,"context_line":"        user_password \u003d data_utils.rand_password()"},{"line_number":196,"context_line":"        email \u003d data_utils.rand_name(root) + suffix + \"@example.com\""},{"line_number":197,"context_line":"        user \u003d self.creds_client.create_user("},{"line_number":198,"context_line":"            username, user_password, project, email)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_6c566b2b","line":195,"in_reply_to":"fa32b979_3880a8f6","updated":"2015-06-25 08:45:25.000000000","message":"hi, you could see my modification to test_tenant_isolation.py, i have alrady get rid of them, and BTW, i didn\u0027t see any use case of specifying custom password for testing, if we really need it in future, we could add it back then. so, i insist removing it :-)","commit_id":"c0a529b01a3ee327dcf2dc20592309ac9f2d0d66"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"994602005b669372404803738bcb3bd14f5f2f79","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            name\u003dproject_name, description\u003dproject_desc)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        username \u003d data_utils.rand_name(root) + suffix"},{"line_number":195,"context_line":"        user_password \u003d data_utils.rand_password()"},{"line_number":196,"context_line":"        email \u003d data_utils.rand_name(root) + suffix + \"@example.com\""},{"line_number":197,"context_line":"        user \u003d self.creds_client.create_user("},{"line_number":198,"context_line":"            username, user_password, project, email)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_8f42c1a9","line":195,"in_reply_to":"fa32b979_6c566b2b","updated":"2015-06-25 08:59:14.000000000","message":"Yep i saw that your removed them , i am thinking that adding random password should not limit our exising code which is not used now.\nIts up to you , whatever you decide .\nI am not a core reviewer so you have my welcome anyway .","commit_id":"c0a529b01a3ee327dcf2dc20592309ac9f2d0d66"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"fecef6166116bfceae9d78032fb207e9e65da11d","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            name\u003dproject_name, description\u003dproject_desc)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        username \u003d data_utils.rand_name(root) + suffix"},{"line_number":195,"context_line":"        user_password \u003d data_utils.rand_password()"},{"line_number":196,"context_line":"        email \u003d data_utils.rand_name(root) + suffix + \"@example.com\""},{"line_number":197,"context_line":"        user \u003d self.creds_client.create_user("},{"line_number":198,"context_line":"            username, user_password, project, email)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_bf04a217","line":195,"in_reply_to":"fa32b979_9fc19ee6","updated":"2015-06-25 02:31:27.000000000","message":"hi, Benny, i didn\u0027t see any usage of the \u0027password\u0027 param, why should we keep it in the initialization?","commit_id":"c0a529b01a3ee327dcf2dc20592309ac9f2d0d66"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"0084867481c1c5a1219a9c7a67564074a1eba317","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            name\u003dproject_name, description\u003dproject_desc)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        username \u003d data_utils.rand_name(root) + suffix"},{"line_number":195,"context_line":"        user_password \u003d data_utils.rand_password()"},{"line_number":196,"context_line":"        email \u003d data_utils.rand_name(root) + suffix + \"@example.com\""},{"line_number":197,"context_line":"        user \u003d self.creds_client.create_user("},{"line_number":198,"context_line":"            username, user_password, project, email)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_3880a8f6","line":195,"in_reply_to":"fa32b979_bf04a217","updated":"2015-06-25 04:41:45.000000000","message":"Hi , \ni see in tests/test_tenant_isolation.py many examples with password set to \u0027fake\u0027 . your patch is a good idea but lets keep the option to set password.\n\nMaybe we will need it in the future , who knows :) \n\nWhat do you think ?","commit_id":"c0a529b01a3ee327dcf2dc20592309ac9f2d0d66"}]}