)]}'
{"tempest/api/object_storage/test_object_expiry.py":[{"author":{"_account_id":7822,"name":"Chris Hoge (not involved in upstream development)","email":"chris@hogepodge.com","username":"hogepodge"},"change_message_id":"e3b6a17fbf65078215f5bbee2d5eb8bd90031bc4","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        self.assertHeaders(resp, \u0027Object\u0027, \u0027GET\u0027)"},{"line_number":68,"context_line":"        self.assertIn(\u0027x-delete-at\u0027, resp)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        # add a couple of seconds for safety."},{"line_number":71,"context_line":"        time.sleep(sleepy_time + self.container_sync_interval)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        # object should not be there anymore"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_7289c874","line":70,"updated":"2015-06-16 20:41:48.000000000","message":"Pedantic, but couple means 2, which is most certainly not how long we\u0027re waiting.","commit_id":"267dc7a70421acc53554f09d8be237267a8e2faf"},{"author":{"_account_id":16433,"name":"izadorozhna","email":"izadorozhna@mirantis.com","username":"izadorozhna"},"change_message_id":"a1bce45ffb867ba95bf1b53352bddc01bdf98c35","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        self.assertHeaders(resp, \u0027Object\u0027, \u0027GET\u0027)"},{"line_number":68,"context_line":"        self.assertIn(\u0027x-delete-at\u0027, resp)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        # add a couple of seconds for safety."},{"line_number":71,"context_line":"        time.sleep(sleepy_time + self.container_sync_interval)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        # object should not be there anymore"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_e97f1ba9","line":70,"in_reply_to":"fa32b979_7289c874","updated":"2015-06-17 09:05:16.000000000","message":"Done","commit_id":"267dc7a70421acc53554f09d8be237267a8e2faf"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"3b9e282add65aadb9e9bb3ce9a492cacaeea2f52","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        # add several seconds for safety."},{"line_number":66,"context_line":"        time.sleep(sleepy_time)"},{"line_number":67,"context_line":"        # checking whether object still exists for several seconds"},{"line_number":68,"context_line":"        for seconds in [3, 6, 15, 36]:"},{"line_number":69,"context_line":"            time.sleep(seconds)"},{"line_number":70,"context_line":"            try:"},{"line_number":71,"context_line":"                self.object_client.get_object(self.container_name,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_cfb7b738","line":68,"range":{"start_line":67,"start_character":41,"end_line":68,"end_character":30},"updated":"2015-06-17 09:41:00.000000000","message":"This is a bit unusual. It works and is valid but could confuse future reviewers or maintainers. I would do a simpler approach:\n\n  for i in range(30):\n    time.sleep(1)\n    try:/except:\n\n(my main concern is I thing people could thing that 3,6,15,36 are special/magic values)\n\nPolling Swift every second should have a minimal impact on the Swift cluster, it\u0027s designed to handle way more load.\n\nAlso, I would add a comment to clearly say why we had to add some more waiting time.","commit_id":"791bc1a95fc8dee0e85aa44c860a4fb1330bb7c9"},{"author":{"_account_id":16433,"name":"izadorozhna","email":"izadorozhna@mirantis.com","username":"izadorozhna"},"change_message_id":"8058801b7305c8beffaee3a9d02b16f1ee0f77ab","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        # add several seconds for safety."},{"line_number":66,"context_line":"        time.sleep(sleepy_time)"},{"line_number":67,"context_line":"        # checking whether object still exists for several seconds"},{"line_number":68,"context_line":"        for seconds in [3, 6, 15, 36]:"},{"line_number":69,"context_line":"            time.sleep(seconds)"},{"line_number":70,"context_line":"            try:"},{"line_number":71,"context_line":"                self.object_client.get_object(self.container_name,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_6f3eabdb","line":68,"in_reply_to":"fa32b979_cfb7b738","updated":"2015-06-17 09:55:27.000000000","message":"Actually I tried to make an array [3, 6, 15, 36] not linear but in a total for 60 seconds (3 + 6 + 15 +36) because it is not necessary to request for an object every 1 second (in an explanation comment to test_get_object_after_expiry_time test there is string about the get calls that can take 3s each sometimes)","commit_id":"791bc1a95fc8dee0e85aa44c860a4fb1330bb7c9"},{"author":{"_account_id":16433,"name":"izadorozhna","email":"izadorozhna@mirantis.com","username":"izadorozhna"},"change_message_id":"51c9284535596bff917d170d514ae5223ae1a4cb","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        # add several seconds for safety."},{"line_number":66,"context_line":"        time.sleep(sleepy_time)"},{"line_number":67,"context_line":"        # checking whether object still exists for several seconds"},{"line_number":68,"context_line":"        for seconds in [3, 6, 15, 36]:"},{"line_number":69,"context_line":"            time.sleep(seconds)"},{"line_number":70,"context_line":"            try:"},{"line_number":71,"context_line":"                self.object_client.get_object(self.container_name,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_95d2205b","line":68,"in_reply_to":"fa32b979_cfb7b738","updated":"2015-06-17 10:22:25.000000000","message":"Done","commit_id":"791bc1a95fc8dee0e85aa44c860a4fb1330bb7c9"}]}