)]}'
{"tempest/config.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"323eb6f9570077b1e85584098eac8ce9c8f14fbc","unresolved":false,"context_lines":[{"line_number":261,"context_line":"    cfg.IntOpt(\u0027ip_version_for_ssh\u0027,"},{"line_number":262,"context_line":"               default\u003d4,"},{"line_number":263,"context_line":"               help\u003d\"IP version used for SSH connections.\"),"},{"line_number":264,"context_line":"    cfg.BoolOpt(\u0027use_floatingip_for_ssh\u0027,"},{"line_number":265,"context_line":"                default\u003dTrue,"},{"line_number":266,"context_line":"                help\u003d\"Does SSH use Floating IPs?\"),"},{"line_number":267,"context_line":"    cfg.StrOpt(\u0027catalog_type\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_6ef911c8","side":"PARENT","line":264,"updated":"2015-06-22 15:43:44.000000000","message":"You can\u0027t just remove a config option like this even if broken. This will break anyone who is using this option currently, we need to handle this gracefully.\n\nIf we\u0027re combining options then you need to mark things as deprecated on the new option. See some of the auth group options for examples.","commit_id":"b93e67690c35285e1fc01bfa02f7c0f9fe079765"}],"tempest/scenario/test_volume_boot_pattern.py":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"571da733e9499ccd912752a54753cbfe5ac912ac","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            self.floating_ips_client.associate_floating_ip_to_server("},{"line_number":106,"context_line":"                floating_ip[\u0027ip\u0027], server[\u0027id\u0027])"},{"line_number":107,"context_line":"            ip \u003d floating_ip[\u0027ip\u0027]"},{"line_number":108,"context_line":"        else:"},{"line_number":109,"context_line":"            network_name_for_ssh \u003d CONF.compute.network_for_ssh"},{"line_number":110,"context_line":"            ip \u003d server.networks[network_name_for_ssh][0]"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_2989dcca","side":"PARENT","line":108,"updated":"2015-06-22 07:58:45.000000000","message":"This supposed to work when you have a flat nova network, or shared accessible provider network with neutron.","commit_id":"b93e67690c35285e1fc01bfa02f7c0f9fe079765"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"0eaa65369d49be9979bc79a562dfdbe7f2eaf455","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            self.floating_ips_client.associate_floating_ip_to_server("},{"line_number":106,"context_line":"                floating_ip[\u0027ip\u0027], server[\u0027id\u0027])"},{"line_number":107,"context_line":"            ip \u003d floating_ip[\u0027ip\u0027]"},{"line_number":108,"context_line":"        else:"},{"line_number":109,"context_line":"            network_name_for_ssh \u003d CONF.compute.network_for_ssh"},{"line_number":110,"context_line":"            ip \u003d server.networks[network_name_for_ssh][0]"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_dddca748","side":"PARENT","line":108,"in_reply_to":"fa32b979_2989dcca","updated":"2015-06-22 10:23:03.000000000","message":"Afazekas, this code didn\u0027t work. You can take a look at previous jenkins checks and see many failures. Please take a look at http://logs.openstack.org/57/192657/8/check/check-tempest-dsvm-full/3f209f0/logs/tempest_conf.txt.gz. This is tempest.conf of the job check-tempest-dsvm-full. In this tempest.conf:\n\n    [compute]\n    ...\n    ssh_connect_method \u003d fixed\n    ...\n\n    [service_available]\n    neutron \u003d False\n    ...","commit_id":"b93e67690c35285e1fc01bfa02f7c0f9fe079765"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"9b39b635c78548213c2cf076a74f63ec3afa6eb2","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            self.floating_ips_client.associate_floating_ip_to_server("},{"line_number":106,"context_line":"                floating_ip[\u0027ip\u0027], server[\u0027id\u0027])"},{"line_number":107,"context_line":"            ip \u003d floating_ip[\u0027ip\u0027]"},{"line_number":108,"context_line":"        else:"},{"line_number":109,"context_line":"            network_name_for_ssh \u003d CONF.compute.network_for_ssh"},{"line_number":110,"context_line":"            ip \u003d server.networks[network_name_for_ssh][0]"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_5caf27e3","side":"PARENT","line":108,"in_reply_to":"fa32b979_517cf0b4","updated":"2015-06-22 16:02:55.000000000","message":"I was agreeing with you on this, just providing more details on why the code works without these lines. My -1 is because of the straight removal of config opts without a deprecation path. It\u0027s a non-graceful config change that will break users.","commit_id":"b93e67690c35285e1fc01bfa02f7c0f9fe079765"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"3dce96e8dd98d0caa987704898f352b16588a048","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            self.floating_ips_client.associate_floating_ip_to_server("},{"line_number":106,"context_line":"                floating_ip[\u0027ip\u0027], server[\u0027id\u0027])"},{"line_number":107,"context_line":"            ip \u003d floating_ip[\u0027ip\u0027]"},{"line_number":108,"context_line":"        else:"},{"line_number":109,"context_line":"            network_name_for_ssh \u003d CONF.compute.network_for_ssh"},{"line_number":110,"context_line":"            ip \u003d server.networks[network_name_for_ssh][0]"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_bc119306","side":"PARENT","line":108,"in_reply_to":"fa32b979_5caf27e3","updated":"2015-06-22 16:04:57.000000000","message":"Oh, sorry. Got it.","commit_id":"b93e67690c35285e1fc01bfa02f7c0f9fe079765"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"323eb6f9570077b1e85584098eac8ce9c8f14fbc","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            self.floating_ips_client.associate_floating_ip_to_server("},{"line_number":106,"context_line":"                floating_ip[\u0027ip\u0027], server[\u0027id\u0027])"},{"line_number":107,"context_line":"            ip \u003d floating_ip[\u0027ip\u0027]"},{"line_number":108,"context_line":"        else:"},{"line_number":109,"context_line":"            network_name_for_ssh \u003d CONF.compute.network_for_ssh"},{"line_number":110,"context_line":"            ip \u003d server.networks[network_name_for_ssh][0]"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_eebbe173","side":"PARENT","line":108,"in_reply_to":"fa32b979_dddca748","updated":"2015-06-22 15:43:44.000000000","message":"afazekas is right in that this was added because of nova net and with neutron using provider networks. However our relatively recent changes to bake the fixed network name into the server create call (back in March/April) should have addressed this. IIRC that was added to the create call in manager, so that\u0027s why this isn\u0027t needed anymore","commit_id":"b93e67690c35285e1fc01bfa02f7c0f9fe079765"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d51af7ee68302b2eb3e4d6d47d2b54998c6cc108","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            self.floating_ips_client.associate_floating_ip_to_server("},{"line_number":106,"context_line":"                floating_ip[\u0027ip\u0027], server[\u0027id\u0027])"},{"line_number":107,"context_line":"            ip \u003d floating_ip[\u0027ip\u0027]"},{"line_number":108,"context_line":"        else:"},{"line_number":109,"context_line":"            network_name_for_ssh \u003d CONF.compute.network_for_ssh"},{"line_number":110,"context_line":"            ip \u003d server.networks[network_name_for_ssh][0]"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_517cf0b4","side":"PARENT","line":108,"in_reply_to":"fa32b979_eebbe173","updated":"2015-06-22 15:58:55.000000000","message":"Matthew, what should I change in this patch set to get a +1 from you? :) As far as I understood we don\u0027t need the following code lines anymore\n\n     network_name_for_ssh \u003d CONF.compute.network_for_ssh\t\t\n     ip \u003d server.networks[network_name_for_ssh][0]\n\nSo I removed them.","commit_id":"b93e67690c35285e1fc01bfa02f7c0f9fe079765"}]}