)]}'
{"tempest/api/network/admin/test_routers_dvr.py":[{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"833bdea7d7f827870b34539bc734e438744c5f9c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        name \u003d data_utils.rand_name(\u0027pretest-check\u0027)"},{"line_number":38,"context_line":"        router \u003d cls.admin_client.create_router(name)"},{"line_number":39,"context_line":"        if \u0027distributed\u0027 not in router[\u0027router\u0027]:"},{"line_number":40,"context_line":"            try: "},{"line_number":41,"context_line":"                cls.admin_client.delete_router(router[\u0027router\u0027][\u0027id\u0027])"},{"line_number":42,"context_line":"            except:"},{"line_number":43,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_da1d37bf","line":40,"updated":"2015-06-23 19:45:01.000000000","message":"Can you fix the whitespace in here.","commit_id":"ccaabfc89e51ddac893dd89c8f10a528e2229e18"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"d3cc2f363bae3be05c1ac8f95e783ef7b508e07b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        name \u003d data_utils.rand_name(\u0027pretest-check\u0027)"},{"line_number":38,"context_line":"        router \u003d cls.admin_client.create_router(name)"},{"line_number":39,"context_line":"        if \u0027distributed\u0027 not in router[\u0027router\u0027]:"},{"line_number":40,"context_line":"            try: "},{"line_number":41,"context_line":"                cls.admin_client.delete_router(router[\u0027router\u0027][\u0027id\u0027])"},{"line_number":42,"context_line":"            except:"},{"line_number":43,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_95c8e023","line":40,"updated":"2015-06-23 20:33:22.000000000","message":"It would be much simpler to just move the delete to right after the create. The only difference is that you would fail instead of skip if the delete failed but that is ok. These tests are not likely to pass anyway in the unlikely event that the delete fails.","commit_id":"ccaabfc89e51ddac893dd89c8f10a528e2229e18"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"b0f93aec1512d7bc9151ff7ec87ca7606e7c70ac","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        name \u003d data_utils.rand_name(\u0027pretest-check\u0027)"},{"line_number":38,"context_line":"        router \u003d cls.admin_client.create_router(name)"},{"line_number":39,"context_line":"        if \u0027distributed\u0027 not in router[\u0027router\u0027]:"},{"line_number":40,"context_line":"            try: "},{"line_number":41,"context_line":"                cls.admin_client.delete_router(router[\u0027router\u0027][\u0027id\u0027])"},{"line_number":42,"context_line":"            except:"},{"line_number":43,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_167cd3b3","line":40,"in_reply_to":"fa32b979_95c8e023","updated":"2015-06-23 23:58:36.000000000","message":"yeah I guess so.. if the delete fails it means something went wrong anyways so fail it!","commit_id":"ccaabfc89e51ddac893dd89c8f10a528e2229e18"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"b0f93aec1512d7bc9151ff7ec87ca7606e7c70ac","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        name \u003d data_utils.rand_name(\u0027pretest-check\u0027)"},{"line_number":38,"context_line":"        router \u003d cls.admin_client.create_router(name)"},{"line_number":39,"context_line":"        if \u0027distributed\u0027 not in router[\u0027router\u0027]:"},{"line_number":40,"context_line":"            try: "},{"line_number":41,"context_line":"                cls.admin_client.delete_router(router[\u0027router\u0027][\u0027id\u0027])"},{"line_number":42,"context_line":"            except:"},{"line_number":43,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_3679d7c8","line":40,"in_reply_to":"fa32b979_da1d37bf","updated":"2015-06-23 23:58:36.000000000","message":"done","commit_id":"ccaabfc89e51ddac893dd89c8f10a528e2229e18"},{"author":{"_account_id":15736,"name":"Ritesh Anand","email":"tellrit@gmail.com","username":"ritesh"},"change_message_id":"69a14c14bb5281c10be50aba8d7017e8ba4e718b","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        if \u0027distributed\u0027 not in router[\u0027router\u0027]:"},{"line_number":40,"context_line":"            try: "},{"line_number":41,"context_line":"                cls.admin_client.delete_router(router[\u0027router\u0027][\u0027id\u0027])"},{"line_number":42,"context_line":"            except:"},{"line_number":43,"context_line":"                pass"},{"line_number":44,"context_line":"            finally:"},{"line_number":45,"context_line":"                msg \u003d \"\u0027distributed\u0027 attribute not found. DVR Possibly not enabled\""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_f6aa8f70","line":42,"updated":"2015-06-23 23:15:09.000000000","message":"Seems except block is not necessary","commit_id":"ccaabfc89e51ddac893dd89c8f10a528e2229e18"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"b0f93aec1512d7bc9151ff7ec87ca7606e7c70ac","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        if \u0027distributed\u0027 not in router[\u0027router\u0027]:"},{"line_number":40,"context_line":"            try: "},{"line_number":41,"context_line":"                cls.admin_client.delete_router(router[\u0027router\u0027][\u0027id\u0027])"},{"line_number":42,"context_line":"            except:"},{"line_number":43,"context_line":"                pass"},{"line_number":44,"context_line":"            finally:"},{"line_number":45,"context_line":"                msg \u003d \"\u0027distributed\u0027 attribute not found. DVR Possibly not enabled\""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_b132d10e","line":42,"in_reply_to":"fa32b979_f6aa8f70","updated":"2015-06-23 23:58:36.000000000","message":"it was just in case the delete failed (throws exception) but as David points out, if that happens, we can just assume there is something else wrong anyways... so go out with a bang! (or exception :) )","commit_id":"ccaabfc89e51ddac893dd89c8f10a528e2229e18"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0042766a7c5a47532bbff85cb2a1fe076a5884be","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        # Instead, we have to check whether DVR is actually present by using"},{"line_number":33,"context_line":"        # admin credentials to create router with distributed\u003dTrue attribute"},{"line_number":34,"context_line":"        # and checking for BadRequest exception and that the resulting router"},{"line_number":35,"context_line":"        # has a distributed attribute."},{"line_number":36,"context_line":"        super(RoutersTestDVR, cls).resource_setup()"},{"line_number":37,"context_line":"        name \u003d data_utils.rand_name(\u0027pretest-check\u0027)"},{"line_number":38,"context_line":"        router \u003d cls.admin_client.create_router(name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_4a8b151f","line":35,"updated":"2015-06-26 07:41:51.000000000","message":"Comments needs to be updated as per below logic of discovering DVR extension. But not in scope of this patch.","commit_id":"2657404d602752549310407cf692fb05c6988c2d"}]}