)]}'
{"tempest/test_discover/test_discover.py":[{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"870ce2b91a7e32ee9a981bb7a3ab494e9275bdb2","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    base_path \u003d os.path.split(os.path.dirname(os.path.abspath(__file__)))[0]"},{"line_number":27,"context_line":"    base_path \u003d os.path.split(base_path)[0]"},{"line_number":28,"context_line":"    for test_dir in [\u0027./tempest/api\u0027, \u0027./tempest/scenario\u0027,"},{"line_number":29,"context_line":"                     \u0027./tempest/thirdparty\u0027]:"},{"line_number":30,"context_line":"        if not pattern:"},{"line_number":31,"context_line":"            suite.addTests(loader.discover(test_dir, top_level_dir\u003dbase_path))"},{"line_number":32,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_5e1ea970","side":"PARENT","line":29,"updated":"2015-07-03 06:24:43.000000000","message":"I would remove the \".\" from the paths. A path like /opt/stack/foo/./bar look a bit weird IMO.","commit_id":"30859df18b5515979bec3d59b34c472772093e71"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"64691c78e78cfb3d781a7dc64012b11e19ca9385","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    base_path \u003d os.path.split(os.path.dirname(os.path.abspath(__file__)))[0]"},{"line_number":27,"context_line":"    base_path \u003d os.path.split(base_path)[0]"},{"line_number":28,"context_line":"    for test_dir in [\u0027./tempest/api\u0027, \u0027./tempest/scenario\u0027,"},{"line_number":29,"context_line":"                     \u0027./tempest/thirdparty\u0027]:"},{"line_number":30,"context_line":"        if not pattern:"},{"line_number":31,"context_line":"            suite.addTests(loader.discover(test_dir, top_level_dir\u003dbase_path))"},{"line_number":32,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_6148adb3","side":"PARENT","line":29,"in_reply_to":"ba3cc151_5e1ea970","updated":"2015-07-03 08:14:47.000000000","message":"Good point, thanks, I\u0027ll do that.","commit_id":"30859df18b5515979bec3d59b34c472772093e71"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"7bc5442607c9ff79f865283f07a471c000e83204","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    base_path \u003d os.path.split(os.path.dirname(os.path.abspath(__file__)))[0]"},{"line_number":31,"context_line":"    base_path \u003d os.path.split(base_path)[0]"},{"line_number":32,"context_line":"    # Load local tempest tests"},{"line_number":33,"context_line":"    for test_dir in [\u0027./tempest/api\u0027, \u0027./tempest/scenario\u0027,"},{"line_number":34,"context_line":"                     \u0027./tempest/thirdparty\u0027]:"},{"line_number":35,"context_line":"    # Load local tempest tests"},{"line_number":36,"context_line":"    for test_dir in [\u0027tempest/api\u0027, \u0027tempest/scenario\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_ae4b4e86","line":33,"updated":"2015-07-08 13:54:10.000000000","message":"What this extra loop tries to do ?","commit_id":"65d35772bedc990d2d74454e607c8227cd8285c1"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"e92c45cf8f9f3f3823d6618dac3ab6a423ffe887","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    suite \u003d unittest.TestSuite()"},{"line_number":30,"context_line":"    base_path \u003d os.path.split(os.path.dirname(os.path.abspath(__file__)))[0]"},{"line_number":31,"context_line":"    base_path \u003d os.path.split(base_path)[0]ß"},{"line_number":32,"context_line":"    # Load local tempest tests"},{"line_number":33,"context_line":"    for test_dir in [\u0027tempest/api\u0027, \u0027tempest/scenario\u0027,"},{"line_number":34,"context_line":"                     \u0027tempest/thirdparty\u0027]:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_2c52e7de","line":31,"updated":"2015-07-08 14:00:22.000000000","message":"ß ?","commit_id":"3b0ecd32c69167bf2805f3ea3615817d35391909"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"0885d662cbca10e2601202ac8bca7cf1461dde7f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    # Load local tempest tests"},{"line_number":33,"context_line":"    for test_dir in [\u0027tempest/api\u0027, \u0027tempest/scenario\u0027,"},{"line_number":34,"context_line":"                     \u0027tempest/thirdparty\u0027]:"},{"line_number":35,"context_line":"        full_test_dir \u003d \u0027/\u0027.join([base_path, test_dir])"},{"line_number":36,"context_line":"        if not pattern:"},{"line_number":37,"context_line":"            suite.addTests(loader.discover(full_test_dir,"},{"line_number":38,"context_line":"                                           top_level_dir\u003dbase_path))"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_e74ded72","line":35,"updated":"2015-07-08 17:08:04.000000000","message":"Also why not just use os.path.join() that\u0027s kinda what that method is for.","commit_id":"360dccd70e15649514845baa0dc0305ad607c297"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"cc06ae05c882cb8fc4832d4ce87ac3bf2fd488cc","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    # Load local tempest tests"},{"line_number":33,"context_line":"    for test_dir in [\u0027tempest/api\u0027, \u0027tempest/scenario\u0027,"},{"line_number":34,"context_line":"                     \u0027tempest/thirdparty\u0027]:"},{"line_number":35,"context_line":"        full_test_dir \u003d \u0027/\u0027.join([base_path, test_dir])"},{"line_number":36,"context_line":"        if not pattern:"},{"line_number":37,"context_line":"            suite.addTests(loader.discover(full_test_dir,"},{"line_number":38,"context_line":"                                           top_level_dir\u003dbase_path))"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_6cd22f02","line":35,"updated":"2015-07-08 14:05:07.000000000","message":"You could use tuple instead of list here.","commit_id":"360dccd70e15649514845baa0dc0305ad607c297"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"2e1b330a80c5b272c5014160d47b4c5e05347340","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    # Load local tempest tests"},{"line_number":33,"context_line":"    for test_dir in [\u0027tempest/api\u0027, \u0027tempest/scenario\u0027,"},{"line_number":34,"context_line":"                     \u0027tempest/thirdparty\u0027]:"},{"line_number":35,"context_line":"        full_test_dir \u003d \u0027/\u0027.join([base_path, test_dir])"},{"line_number":36,"context_line":"        if not pattern:"},{"line_number":37,"context_line":"            suite.addTests(loader.discover(full_test_dir,"},{"line_number":38,"context_line":"                                           top_level_dir\u003dbase_path))"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_f2b28295","line":35,"in_reply_to":"ba3cc151_e74ded72","updated":"2015-07-08 20:30:56.000000000","message":"Done","commit_id":"360dccd70e15649514845baa0dc0305ad607c297"}]}