)]}'
{"tools/install_venv_common.py":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"acfa32d08a66da108aafcc479e782fc40e469276","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            print(\u0027done.\u0027)"},{"line_number":102,"context_line":"        else:"},{"line_number":103,"context_line":"            print(\"venv already exists...\")"},{"line_number":104,"context_line":"            pass"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def pip_install(self, *args):"},{"line_number":107,"context_line":"        self.run_command([\u0027tools/with_venv.sh\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_f2f22606","line":104,"updated":"2015-06-29 10:48:39.000000000","message":"Why do you add \"pass\" here?","commit_id":"76f44393fa461516ea107c731e5be699aabeb6fd"}],"tools/with_venv.sh":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"acfa32d08a66da108aafcc479e782fc40e469276","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"TOOLS_PATH\u003d${TOOLS_PATH:-$(dirname $0)}"},{"line_number":3,"context_line":"VENV_PATH\u003d${VENV_PATH:-${TOOLS_PATH}}"},{"line_number":4,"context_line":"VENV_DIR\u003d${VENV_NAME:-/../.venv}"},{"line_number":5,"context_line":"TOOLS\u003d${TOOLS_PATH}"},{"line_number":6,"context_line":"VENV\u003d${VENV:-${VENV_PATH}/${VENV_DIR}}"},{"line_number":7,"context_line":"source ${VENV}/bin/activate \u0026\u0026 \"$@\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"ba3cc151_72f2969c","line":4,"updated":"2015-06-29 10:48:39.000000000","message":"VENV_NAME -\u003e VENV_DIR","commit_id":"76f44393fa461516ea107c731e5be699aabeb6fd"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"31d88c26807e92eb89b403319c34dd9e08fc4470","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"TOOLS_PATH\u003d${TOOLS_PATH:-$(dirname $0)}"},{"line_number":3,"context_line":"VENV_PATH\u003d${VENV_PATH:-${TOOLS_PATH}}"},{"line_number":4,"context_line":"VENV_DIR\u003d${VENV_NAME:-/../.venv}"},{"line_number":5,"context_line":"TOOLS\u003d${TOOLS_PATH}"},{"line_number":6,"context_line":"VENV\u003d${VENV:-${VENV_PATH}/${VENV_DIR}}"},{"line_number":7,"context_line":"source ${VENV}/bin/activate \u0026\u0026 \"$@\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"ba3cc151_84f4465b","line":4,"in_reply_to":"ba3cc151_72f2969c","updated":"2015-07-08 02:18:59.000000000","message":"Nice catch. Those are just sync from oslo-incubator. But these should be fixed. I will fix those in oslo and then sync it again.","commit_id":"76f44393fa461516ea107c731e5be699aabeb6fd"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"acfa32d08a66da108aafcc479e782fc40e469276","unresolved":false,"context_lines":[{"line_number":2,"context_line":"TOOLS_PATH\u003d${TOOLS_PATH:-$(dirname $0)}"},{"line_number":3,"context_line":"VENV_PATH\u003d${VENV_PATH:-${TOOLS_PATH}}"},{"line_number":4,"context_line":"VENV_DIR\u003d${VENV_NAME:-/../.venv}"},{"line_number":5,"context_line":"TOOLS\u003d${TOOLS_PATH}"},{"line_number":6,"context_line":"VENV\u003d${VENV:-${VENV_PATH}/${VENV_DIR}}"},{"line_number":7,"context_line":"source ${VENV}/bin/activate \u0026\u0026 \"$@\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"ba3cc151_721a9619","line":5,"updated":"2015-06-29 10:48:39.000000000","message":"It looks like variable TOOLS is not used.","commit_id":"76f44393fa461516ea107c731e5be699aabeb6fd"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"31d88c26807e92eb89b403319c34dd9e08fc4470","unresolved":false,"context_lines":[{"line_number":2,"context_line":"TOOLS_PATH\u003d${TOOLS_PATH:-$(dirname $0)}"},{"line_number":3,"context_line":"VENV_PATH\u003d${VENV_PATH:-${TOOLS_PATH}}"},{"line_number":4,"context_line":"VENV_DIR\u003d${VENV_NAME:-/../.venv}"},{"line_number":5,"context_line":"TOOLS\u003d${TOOLS_PATH}"},{"line_number":6,"context_line":"VENV\u003d${VENV:-${VENV_PATH}/${VENV_DIR}}"},{"line_number":7,"context_line":"source ${VENV}/bin/activate \u0026\u0026 \"$@\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"ba3cc151_24e53aa3","line":5,"in_reply_to":"ba3cc151_721a9619","updated":"2015-07-08 02:18:59.000000000","message":"ditto","commit_id":"76f44393fa461516ea107c731e5be699aabeb6fd"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"9ed527b931320d7ad3acd046a2e791b7baa950e5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"TOOLS_PATH\u003d${TOOLS_PATH:-$(dirname $0)/../}"},{"line_number":3,"context_line":"VENV_PATH\u003d${VENV_PATH:-${TOOLS_PATH}}"},{"line_number":4,"context_line":"VENV_DIR\u003d${VENV_DIR:-/.venv}"},{"line_number":5,"context_line":"VENV\u003d${VENV:-${VENV_PATH}/${VENV_DIR}}"},{"line_number":6,"context_line":"source ${VENV}/bin/activate \u0026\u0026 \"$@\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"ba3cc151_462eb4fb","line":4,"updated":"2015-07-10 10:49:48.000000000","message":".venv in root directory?\n\n${VENV_DIR:-/.venv} -\u003e ${VENV_DIR:-.venv}","commit_id":"f5360ff14fc5d14714d603250ddfebb4304a144d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e6386ca894ea5515db49daaec4c485d34b026ec5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"TOOLS_PATH\u003d${TOOLS_PATH:-$(dirname $0)/../}"},{"line_number":3,"context_line":"VENV_PATH\u003d${VENV_PATH:-${TOOLS_PATH}}"},{"line_number":4,"context_line":"VENV_DIR\u003d${VENV_DIR:-/.venv}"},{"line_number":5,"context_line":"VENV\u003d${VENV:-${VENV_PATH}/${VENV_DIR}}"},{"line_number":6,"context_line":"source ${VENV}/bin/activate \u0026\u0026 \"$@\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"9a41bdd9_44ec5bc7","line":4,"in_reply_to":"9a41bdd9_3a2b83ed","updated":"2015-07-13 01:04:43.000000000","message":"Yes, that should not be any issue as it is not used independently anywhere. It worked fine.\n\nThis script is just sync from oslo-incubator. We can always do such cosmetic changes in oslo and then sync again if needed.","commit_id":"f5360ff14fc5d14714d603250ddfebb4304a144d"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"6f0f452dc47e14ea7862ee267e85c3d53451b04f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"TOOLS_PATH\u003d${TOOLS_PATH:-$(dirname $0)/../}"},{"line_number":3,"context_line":"VENV_PATH\u003d${VENV_PATH:-${TOOLS_PATH}}"},{"line_number":4,"context_line":"VENV_DIR\u003d${VENV_DIR:-/.venv}"},{"line_number":5,"context_line":"VENV\u003d${VENV:-${VENV_PATH}/${VENV_DIR}}"},{"line_number":6,"context_line":"source ${VENV}/bin/activate \u0026\u0026 \"$@\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"9a41bdd9_c7ef0daf","line":4,"in_reply_to":"9a41bdd9_44ec5bc7","updated":"2015-07-13 02:17:40.000000000","message":"Hm, OK.","commit_id":"f5360ff14fc5d14714d603250ddfebb4304a144d"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"5a997c1296450505215d31b34174861e86f2f55b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"TOOLS_PATH\u003d${TOOLS_PATH:-$(dirname $0)/../}"},{"line_number":3,"context_line":"VENV_PATH\u003d${VENV_PATH:-${TOOLS_PATH}}"},{"line_number":4,"context_line":"VENV_DIR\u003d${VENV_DIR:-/.venv}"},{"line_number":5,"context_line":"VENV\u003d${VENV:-${VENV_PATH}/${VENV_DIR}}"},{"line_number":6,"context_line":"source ${VENV}/bin/activate \u0026\u0026 \"$@\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"9a41bdd9_3a2b83ed","line":4,"in_reply_to":"9a41bdd9_b286e1b7","updated":"2015-07-12 11:44:21.000000000","message":"Ghanshyam, I meant you used a slash in front of .venv in L4. So if VENV_DIR accepts the default value (/.venv), VENV will be the following\n\n    VENV\u003d${VENV_PATH}//.venv","commit_id":"f5360ff14fc5d14714d603250ddfebb4304a144d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"87cbd424a7e1ff647ec5fcda58e270eabdda333e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"TOOLS_PATH\u003d${TOOLS_PATH:-$(dirname $0)/../}"},{"line_number":3,"context_line":"VENV_PATH\u003d${VENV_PATH:-${TOOLS_PATH}}"},{"line_number":4,"context_line":"VENV_DIR\u003d${VENV_DIR:-/.venv}"},{"line_number":5,"context_line":"VENV\u003d${VENV:-${VENV_PATH}/${VENV_DIR}}"},{"line_number":6,"context_line":"source ${VENV}/bin/activate \u0026\u0026 \"$@\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"9a41bdd9_b286e1b7","line":4,"in_reply_to":"ba3cc151_462eb4fb","updated":"2015-07-12 02:56:01.000000000","message":"it not mentioning it as under root dir. VENV_DIR is just being used as virtual env name.\n\n@L5- VENV is constructed with VENV_PATH and VENV_DIR.","commit_id":"f5360ff14fc5d14714d603250ddfebb4304a144d"}]}