)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"787e0b24cb55502c095bf2d57301a47f7c4cf5ea","unresolved":false,"context_lines":[{"line_number":11,"context_line":"several unit test failures when running with that release. This commit"},{"line_number":12,"context_line":"addresses this by removing all the uses of this call straightup as it"},{"line_number":13,"context_line":"turns out it was unecessary, or changing the tests to not rely on it"},{"line_number":14,"context_line":"anymore."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I24f6e20cc8e310ba69fb23510795e235218abb2d"},{"line_number":17,"context_line":"Closes-Bug: #1469825"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba3cc151_4b9f8d03","line":14,"updated":"2015-06-29 18:38:57.000000000","message":"So its totally fine to call cleanUp when you own the fixture. useFixture hands-off the fixture setUp and cleanUp responsibility to the framework. *That* is why calling cleanUp by hand is a mistake. So I\u0027d like to either see this explain in more nuance rather than \u0027bad idea\u0027 or perhaps just say...\n\n\u0027Fixtures 1.3.0 started erroring when a cleaned-up fixture was cleaned-up a second time. We were causing that by calling cleanUp on a fixture we had registered with useFixture.\u0027 or something.","commit_id":"890e09eab257091e587f5d08f7ee7e0116a4c60e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dca310446b6d971f52accd34df86615e9a48d243","unresolved":false,"context_lines":[{"line_number":11,"context_line":"to fixtures cleanUp(). Normally we don\u0027t want to do this and should"},{"line_number":12,"context_line":"have only 1 fix per patch. However, because they are both breaking the"},{"line_number":13,"context_line":"tempest gate at the same time and preventing anything from landing if"},{"line_number":14,"context_line":"we don\u0027t land them in a single patch neither fix will be able to land."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The fixtures 1.3.0 release started enforcing that manually calling the"},{"line_number":17,"context_line":"cleanUp() function for a fixture that was created using useFixture()"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba3cc151_37d143ce","line":14,"updated":"2015-06-29 21:19:37.000000000","message":"We might need to call Tom Cruise in to fix the situation, Cougar.","commit_id":"be15b877ca0d802778ffae8c75031db3d7bdb958"}],"tempest/tests/common/test_accounts.py":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"f93fdce361887885364e3a69b467dc54f8f05103","unresolved":false,"context_lines":[{"line_number":291,"context_line":"            {\u0027username\u0027: \u0027test_user14\u0027, \u0027tenant_name\u0027: \u0027test_tenant14\u0027,"},{"line_number":292,"context_line":"             \u0027password\u0027: \u0027p\u0027, \u0027roles\u0027: [\u0027role-7\u0027, \u0027role-11\u0027],"},{"line_number":293,"context_line":"             \u0027resources\u0027: {\u0027network\u0027: \u0027network-2\u0027}}]"},{"line_number":294,"context_line":"        # Clear previous mock using self.test_accounts"},{"line_number":295,"context_line":"        self.useFixture(mockpatch.Patch("},{"line_number":296,"context_line":"            \u0027tempest.common.accounts.read_accounts_yaml\u0027,"},{"line_number":297,"context_line":"            return_value\u003dtest_accounts))"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_1669a8be","line":294,"updated":"2015-06-29 18:47:37.000000000","message":"As far as I understand this comment was intended for the removed line. Shouldn\u0027t we remove this comment as well? Or am I missing something?","commit_id":"4003bf983e6338b11e210d015c18541b8b277a01"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"69de71ae8063e2c97fe860e161e7f7218d131083","unresolved":false,"context_lines":[{"line_number":291,"context_line":"            {\u0027username\u0027: \u0027test_user14\u0027, \u0027tenant_name\u0027: \u0027test_tenant14\u0027,"},{"line_number":292,"context_line":"             \u0027password\u0027: \u0027p\u0027, \u0027roles\u0027: [\u0027role-7\u0027, \u0027role-11\u0027],"},{"line_number":293,"context_line":"             \u0027resources\u0027: {\u0027network\u0027: \u0027network-2\u0027}}]"},{"line_number":294,"context_line":"        # Clear previous mock using self.test_accounts"},{"line_number":295,"context_line":"        self.useFixture(mockpatch.Patch("},{"line_number":296,"context_line":"            \u0027tempest.common.accounts.read_accounts_yaml\u0027,"},{"line_number":297,"context_line":"            return_value\u003dtest_accounts))"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_b6d8fc54","line":294,"in_reply_to":"ba3cc151_1669a8be","updated":"2015-06-29 18:53:39.000000000","message":"No, you\u0027re correct I missed this line (and similar comments from other tests) However, given that everything is broken in the tempest queue because of this I\u0027m inclined to leave it as is and just push this through asap.\n\nIf you don\u0027t mind could you push a follow-up patch based on top of this one to remove the unecessary comments.","commit_id":"4003bf983e6338b11e210d015c18541b8b277a01"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"60363fbea71f1636881a437fcceba01c5cc51779","unresolved":false,"context_lines":[{"line_number":291,"context_line":"            {\u0027username\u0027: \u0027test_user14\u0027, \u0027tenant_name\u0027: \u0027test_tenant14\u0027,"},{"line_number":292,"context_line":"             \u0027password\u0027: \u0027p\u0027, \u0027roles\u0027: [\u0027role-7\u0027, \u0027role-11\u0027],"},{"line_number":293,"context_line":"             \u0027resources\u0027: {\u0027network\u0027: \u0027network-2\u0027}}]"},{"line_number":294,"context_line":"        # Clear previous mock using self.test_accounts"},{"line_number":295,"context_line":"        self.useFixture(mockpatch.Patch("},{"line_number":296,"context_line":"            \u0027tempest.common.accounts.read_accounts_yaml\u0027,"},{"line_number":297,"context_line":"            return_value\u003dtest_accounts))"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_168a08c0","line":294,"in_reply_to":"ba3cc151_b6d8fc54","updated":"2015-06-29 19:01:02.000000000","message":"Yes, sure. I will do it.","commit_id":"4003bf983e6338b11e210d015c18541b8b277a01"}]}