)]}'
{"tempest/api/compute/test_quotas.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"671d0bbf50244e48c97c690cc78643182aaf6e4f","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    @classmethod"},{"line_number":24,"context_line":"    def skip_checks(cls):"},{"line_number":25,"context_line":"        super(QuotasTestJSON, cls).skip_checks()"},{"line_number":26,"context_line":"        if not test.is_extension_enabled(\u0027Quotas\u0027, \u0027compute\u0027):"},{"line_number":27,"context_line":"            msg \u003d \"quotas extension not enabled.\""},{"line_number":28,"context_line":"            raise cls.skipException(msg)"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_03f1c594","line":26,"updated":"2015-07-09 07:14:25.000000000","message":"\u0027Quotas\u0027 -\u003e \"os-quota-sets\" \n\napi_extensions config option use Alias name not extension names.","commit_id":"2ca746ca4a93969ead8fc5a21b6b55f1c09ee952"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3602801334ed8aca8ce5b34aeec3bcda787978dd","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    @classmethod"},{"line_number":24,"context_line":"    def skip_checks(cls):"},{"line_number":25,"context_line":"        super(QuotasTestJSON, cls).skip_checks()"},{"line_number":26,"context_line":"        if not test.is_extension_enabled(\u0027Quotas\u0027, \u0027compute\u0027):"},{"line_number":27,"context_line":"            msg \u003d \"quotas extension not enabled.\""},{"line_number":28,"context_line":"            raise cls.skipException(msg)"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_72a31d50","line":26,"in_reply_to":"ba3cc151_03f1c594","updated":"2015-07-14 05:25:31.000000000","message":"Done","commit_id":"2ca746ca4a93969ead8fc5a21b6b55f1c09ee952"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"671d0bbf50244e48c97c690cc78643182aaf6e4f","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        super(QuotasTestJSON, cls).skip_checks()"},{"line_number":26,"context_line":"        if not test.is_extension_enabled(\u0027Quotas\u0027, \u0027compute\u0027):"},{"line_number":27,"context_line":"            msg \u003d \"quotas extension not enabled.\""},{"line_number":28,"context_line":"            raise cls.skipException(msg)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def setUp(self):"},{"line_number":31,"context_line":"        # NOTE(mriedem): Avoid conflicts with os-quota-class-sets tests."}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_a3a01943","line":28,"updated":"2015-07-09 07:14:25.000000000","message":"But this way, it will skip tests based on extension available or not. As you mentioned in bug that issue is that if user do not have permission of features then it fails, which is not going to be fixed by this. \n\n2 points here-\n1. Nova has read only quotas permission not only for admin, but for owner too which this test does. So there should not be any issue with default Nova deployment.\n\nhttps://github.com/openstack/nova/blob/master/etc/nova/policy.json#L107 \n\n\n2. If policy and features permission has been changed then, many tests can fail. For example if create server policy/permission has been changed from all to admin only then all non admin server tests will be fail.\n\nWe can only achieve that if we load policy file at runtime and check each feature permission and skip/run tests based on that but I do not think Tempest should do that.","commit_id":"2ca746ca4a93969ead8fc5a21b6b55f1c09ee952"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4b51fefd2d9951f22b0683725566aa80afa91be5","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        super(QuotasTestJSON, cls).skip_checks()"},{"line_number":26,"context_line":"        if not test.is_extension_enabled(\u0027Quotas\u0027, \u0027compute\u0027):"},{"line_number":27,"context_line":"            msg \u003d \"quotas extension not enabled.\""},{"line_number":28,"context_line":"            raise cls.skipException(msg)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def setUp(self):"},{"line_number":31,"context_line":"        # NOTE(mriedem): Avoid conflicts with os-quota-class-sets tests."}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_c6782b92","line":28,"in_reply_to":"ba3cc151_3e0f3e38","updated":"2015-07-14 07:51:04.000000000","message":"Agree. I think we should go with option 1. User has to fill extension based on used policy.json","commit_id":"2ca746ca4a93969ead8fc5a21b6b55f1c09ee952"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8034f3d0c5601dd62e8859feb6ebebc776fe68c5","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        super(QuotasTestJSON, cls).skip_checks()"},{"line_number":26,"context_line":"        if not test.is_extension_enabled(\u0027Quotas\u0027, \u0027compute\u0027):"},{"line_number":27,"context_line":"            msg \u003d \"quotas extension not enabled.\""},{"line_number":28,"context_line":"            raise cls.skipException(msg)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def setUp(self):"},{"line_number":31,"context_line":"        # NOTE(mriedem): Avoid conflicts with os-quota-class-sets tests."}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_3e0f3e38","line":28,"in_reply_to":"ba3cc151_a3a01943","updated":"2015-07-09 07:40:15.000000000","message":"You are totally right, but I see no other way than:\n\n1) fill the extension list correctly before test run, based on policy.json\n\n2) Show only the extensions that are available for the user/tenant (seems nova issue, or generally for any openstack component\u0027s issue)\nand check runtime and skip if the extension is not available.","commit_id":"2ca746ca4a93969ead8fc5a21b6b55f1c09ee952"}]}
