)]}'
{"tempest/api/volume/test_volumes_extend.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"741c46767450d58e786015141e35399140774e3e","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        self.client.wait_for_volume_status(volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":51,"context_line":"        resized_volume \u003d self.client.show_volume(volume[\u0027id\u0027])"},{"line_number":52,"context_line":"        self.assertEqual(resized_volume[\u0027size\u0027], extend_size)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class VolumesV1ExtendTest(VolumesV2ExtendTest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_f3ad7684","line":52,"updated":"2015-07-09 14:32:59.000000000","message":"Cool, thanks Jordan.  I hadn\u0027t seen the resource cleanup in the base class before... so that auto-cleans the test resources?  Way cool!!","commit_id":"25a68a6c7c92f511a867a4fe23aeecfe7b263514"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"e719affb3481bb334ead1f0eacb076f985aa3d9f","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        self.client.wait_for_volume_status(volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":51,"context_line":"        resized_volume \u003d self.client.show_volume(volume[\u0027id\u0027])"},{"line_number":52,"context_line":"        self.assertEqual(resized_volume[\u0027size\u0027], extend_size)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class VolumesV1ExtendTest(VolumesV2ExtendTest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_4b010aae","line":52,"in_reply_to":"ba3cc151_f3ad7684","updated":"2015-07-09 15:10:50.000000000","message":"Yep. The base class defines create_* methods that keep track of the created resources to clean them up in the end. So you don\"t have to worry about it :)","commit_id":"25a68a6c7c92f511a867a4fe23aeecfe7b263514"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"75355842c6141b6821005104fce900c194d7a01f","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        resized_volume \u003d self.volumes_client.show_volume("},{"line_number":53,"context_line":"            volume[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":54,"context_line":"        self.assertEqual(extend_size, resized_volume[\u0027size\u0027])"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class VolumesV1ExtendTest(VolumesV2ExtendTest):"},{"line_number":58,"context_line":"    _api_version \u003d 1"}],"source_content_type":"text/x-python","patch_set":6,"id":"da36d5c6_d27cc322","line":55,"updated":"2017-02-21 03:41:28.000000000","message":"Does it need to check whether the snapshot\u0027s size is equal to volume[\u0027size\u0027] or extend_size?","commit_id":"5634cba5c71254f236a10875e3d15e338d13fd4a"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"035f3eaf86ea5e2ae792f23e3fc3d643d772c059","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        resized_volume \u003d self.volumes_client.show_volume("},{"line_number":53,"context_line":"            volume[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":54,"context_line":"        self.assertEqual(extend_size, resized_volume[\u0027size\u0027])"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class VolumesV1ExtendTest(VolumesV2ExtendTest):"},{"line_number":58,"context_line":"    _api_version \u003d 1"}],"source_content_type":"text/x-python","patch_set":6,"id":"da36d5c6_414e0870","line":55,"in_reply_to":"da36d5c6_d27cc322","updated":"2017-02-22 13:18:45.000000000","message":"That is not what is being tested here. Furthermore, it is not performing any operation in the snapshot.","commit_id":"5634cba5c71254f236a10875e3d15e338d13fd4a"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"82f06f3d3a8e7e5820e162bbf59018de34cdd4bc","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        extend_size \u003d volume[\u0027size\u0027] + 1"},{"line_number":48,"context_line":"        self.volumes_client.extend_volume(volume[\u0027id\u0027], new_size\u003dextend_size)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        waiters.wait_for_volume_status(self.volumes_client,"},{"line_number":51,"context_line":"                                       volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":52,"context_line":"        resized_volume \u003d self.volumes_client.show_volume("},{"line_number":53,"context_line":"            volume[\u0027id\u0027])[\u0027volume\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a1ff146_c434ecfc","line":50,"range":{"start_line":50,"start_character":16,"end_line":50,"end_character":38},"updated":"2017-03-16 05:55:30.000000000","message":"Hi, Jordan! The function \u0027wait_for_volume_status\u0027 is deprecated now, here should use \u0027wait_for_volume_resource_status\u0027.","commit_id":"4146f89c935a17d39d3e9ef19ec77d4b86fde808"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"e43c62ecc54e6420ebff1afec57098b864c3c8ec","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    @decorators.idempotent_id(\u002786be1cba-2640-11e5-9c82-635fb964c912\u0027)"},{"line_number":41,"context_line":"    @testtools.skipUnless(CONF.volume_feature_enabled.snapshot,"},{"line_number":42,"context_line":"                          \"Cinder volume snapshots are disabled\")"},{"line_number":43,"context_line":"    def test_volume_extend_when_vol_has_snapshot(self):"},{"line_number":44,"context_line":"        volume \u003d self.create_volume()"},{"line_number":45,"context_line":"        self.create_snapshot(volume[\u0027id\u0027])"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5ff73747_8f288134","line":43,"range":{"start_line":43,"start_character":32,"end_line":43,"end_character":35},"updated":"2017-04-25 13:55:40.000000000","message":"NIT: There\u0027s no value in vol vs volume here, please use the full name.","commit_id":"8fa12110e5346a3023efa005a2fdae0129f76f7a"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"9cdc0813f1dcd49709b2eed3d520d218c6b8ff63","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    @decorators.idempotent_id(\u002786be1cba-2640-11e5-9c82-635fb964c912\u0027)"},{"line_number":41,"context_line":"    @testtools.skipUnless(CONF.volume_feature_enabled.snapshot,"},{"line_number":42,"context_line":"                          \"Cinder volume snapshots are disabled\")"},{"line_number":43,"context_line":"    def test_volume_extend_when_vol_has_snapshot(self):"},{"line_number":44,"context_line":"        volume \u003d self.create_volume()"},{"line_number":45,"context_line":"        self.create_snapshot(volume[\u0027id\u0027])"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5ff73747_aa920b4a","line":43,"range":{"start_line":43,"start_character":32,"end_line":43,"end_character":35},"in_reply_to":"5ff73747_8f288134","updated":"2017-04-25 14:13:56.000000000","message":"True, will do.\n\nI think that feature is either too race-prone or completely bogus accros releases. I doubt I will manage to have a stable test.","commit_id":"8fa12110e5346a3023efa005a2fdae0129f76f7a"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"25548c8ea09414d9a9a1f7e37f801bea9249e077","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @decorators.idempotent_id(\u002786be1cba-2640-11e5-9c82-635fb964c912\u0027)"},{"line_number":41,"context_line":"    @testtools.skipUnless(CONF.volume_feature_enabled.snapshot,"},{"line_number":42,"context_line":"                          \"Cinder volume snapshots are disabled\")"},{"line_number":43,"context_line":"    def test_volume_extend_when_volume_has_snapshot(self):"},{"line_number":44,"context_line":"        volume \u003d self.create_volume()"},{"line_number":45,"context_line":"        self.create_snapshot(volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"5ff73747_c91c3b6c","line":42,"updated":"2017-04-25 18:06:23.000000000","message":"We can add here @related_bug(1470558) later.","commit_id":"1189dd15c6d06fb87e44fd10e37da5d5f6f5653b"}]}
