)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"842ac3c2882c0688f105f3fb89a1caed6e3fc1e5","unresolved":false,"context_lines":[{"line_number":1026,"context_line":"    def create_server(self, name\u003dNone, image\u003dNone, flavor\u003dNone,"},{"line_number":1027,"context_line":"                      wait_on_boot\u003dTrue, wait_on_delete\u003dTrue,"},{"line_number":1028,"context_line":"                      create_kwargs\u003dNone):"},{"line_number":1029,"context_line":"        vnic_type \u003d CONF.network.port_vnic_type"},{"line_number":1030,"context_line":""},{"line_number":1031,"context_line":"        # If vnic_type is configured create port for"},{"line_number":1032,"context_line":"        # every network"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_de02946f","side":"PARENT","line":1029,"updated":"2015-07-11 13:34:29.000000000","message":"I liked your changes. Jenkins check gave you +1 and thus it looks like this code block is not used anywhere. BTW you can remove this method at all.","commit_id":"a21251e03ba0465abb9c27ac63f8d2527eac3a16"},{"author":{"_account_id":16986,"name":"Shuquan Huang","email":"shuquan.huang@live.com","username":"shuquan"},"change_message_id":"5c5d21c394ca16e7e4069c696131f268e3092642","unresolved":false,"context_lines":[{"line_number":1026,"context_line":"    def create_server(self, name\u003dNone, image\u003dNone, flavor\u003dNone,"},{"line_number":1027,"context_line":"                      wait_on_boot\u003dTrue, wait_on_delete\u003dTrue,"},{"line_number":1028,"context_line":"                      create_kwargs\u003dNone):"},{"line_number":1029,"context_line":"        vnic_type \u003d CONF.network.port_vnic_type"},{"line_number":1030,"context_line":""},{"line_number":1031,"context_line":"        # If vnic_type is configured create port for"},{"line_number":1032,"context_line":"        # every network"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_1e7ebce4","side":"PARENT","line":1029,"in_reply_to":"9a41bdd9_de02946f","updated":"2015-07-11 13:52:50.000000000","message":"You\u0027re right. This signature is the same as its parent\u0027s. We can remove it.","commit_id":"a21251e03ba0465abb9c27ac63f8d2527eac3a16"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"5e6cb1f1673b1c2caedad65b55d0d168afa9b2fb","unresolved":false,"context_lines":[{"line_number":1029,"context_line":"        vnic_type \u003d CONF.network.port_vnic_type"},{"line_number":1030,"context_line":""},{"line_number":1031,"context_line":"        # If vnic_type is configured create port for"},{"line_number":1032,"context_line":"        # every network"},{"line_number":1033,"context_line":"        if vnic_type:"},{"line_number":1034,"context_line":"            ports \u003d []"},{"line_number":1035,"context_line":"            networks \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_8bb6033c","side":"PARENT","line":1032,"updated":"2015-07-12 13:00:30.000000000","message":"If vnic_type is defined in the config file, we always create server with pre-configured port in accordance with this code block. It looks like vnic_type is a kind of a flag. If vnic_type is None, we simply create server. If defined, we create server with pre-configured port. I don\u0027t know whether or not it is right. I am not familiar with this. Perhaps, we shouldn\u0027t remove this code. Guys, who is familiar with this, please, clarify a little bit regarding the vnic_type option. Thanks!","commit_id":"a21251e03ba0465abb9c27ac63f8d2527eac3a16"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"c7ad6190ddff973b55dcdd9cc32d447494f05a21","unresolved":false,"context_lines":[{"line_number":1029,"context_line":"        vnic_type \u003d CONF.network.port_vnic_type"},{"line_number":1030,"context_line":""},{"line_number":1031,"context_line":"        # If vnic_type is configured create port for"},{"line_number":1032,"context_line":"        # every network"},{"line_number":1033,"context_line":"        if vnic_type:"},{"line_number":1034,"context_line":"            ports \u003d []"},{"line_number":1035,"context_line":"            networks \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_c81ae87c","side":"PARENT","line":1032,"in_reply_to":"9a41bdd9_0508cdd8","updated":"2015-07-16 13:57:59.000000000","message":"OK. Let\u0027s start with the beginning. What is the port_vnic_type option intended for? \nAs far as I understand when this option is defined, according to this method we\n \n    1. create a port with binding:vnic_type specified;\n    2. create a server with this pre-configured port.\n\nI think we should have two different options:\n\n    1. port_vnic_type that will be used only when creating a port.\n    2. Some option that will be used for creating servers with pre-configured ports when we run network scenario tests.","commit_id":"a21251e03ba0465abb9c27ac63f8d2527eac3a16"},{"author":{"_account_id":16986,"name":"Shuquan Huang","email":"shuquan.huang@live.com","username":"shuquan"},"change_message_id":"a216e3e69870a1b13e0aba79ec9de70dd23a0718","unresolved":false,"context_lines":[{"line_number":1029,"context_line":"        vnic_type \u003d CONF.network.port_vnic_type"},{"line_number":1030,"context_line":""},{"line_number":1031,"context_line":"        # If vnic_type is configured create port for"},{"line_number":1032,"context_line":"        # every network"},{"line_number":1033,"context_line":"        if vnic_type:"},{"line_number":1034,"context_line":"            ports \u003d []"},{"line_number":1035,"context_line":"            networks \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_0508cdd8","side":"PARENT","line":1032,"in_reply_to":"9a41bdd9_268fee24","updated":"2015-07-16 08:16:14.000000000","message":"Should we change the upstream CI about this?? I test it locally. All tests work correctly.","commit_id":"a21251e03ba0465abb9c27ac63f8d2527eac3a16"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"51addd9fdfe9ec3dde35ac1063cf0fa7f931a659","unresolved":false,"context_lines":[{"line_number":1029,"context_line":"        vnic_type \u003d CONF.network.port_vnic_type"},{"line_number":1030,"context_line":""},{"line_number":1031,"context_line":"        # If vnic_type is configured create port for"},{"line_number":1032,"context_line":"        # every network"},{"line_number":1033,"context_line":"        if vnic_type:"},{"line_number":1034,"context_line":"            ports \u003d []"},{"line_number":1035,"context_line":"            networks \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_aababcdf","side":"PARENT","line":1032,"in_reply_to":"9a41bdd9_268fee24","updated":"2015-07-13 11:17:19.000000000","message":"Yaroslav - you are correct. When using vnic_type the server is launched with a pre-configured port with the vnic_type configured. \n\nShuquan, the default vnic_type is None so the upstream CI won\u0027t break but the ones that use it will probably fail.\nIf a port should not be created by create_server we need to give another  option to run the tests with a pre-created port.","commit_id":"a21251e03ba0465abb9c27ac63f8d2527eac3a16"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"00490254a376d7e14f5c901362a8e8d8078c5054","unresolved":false,"context_lines":[{"line_number":1029,"context_line":"        vnic_type \u003d CONF.network.port_vnic_type"},{"line_number":1030,"context_line":""},{"line_number":1031,"context_line":"        # If vnic_type is configured create port for"},{"line_number":1032,"context_line":"        # every network"},{"line_number":1033,"context_line":"        if vnic_type:"},{"line_number":1034,"context_line":"            ports \u003d []"},{"line_number":1035,"context_line":"            networks \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_268fee24","side":"PARENT","line":1032,"in_reply_to":"9a41bdd9_4b36bb04","updated":"2015-07-12 13:35:46.000000000","message":"Shuquan, but if we define vnic_type, will all tests, that use this method, work correctly?","commit_id":"a21251e03ba0465abb9c27ac63f8d2527eac3a16"},{"author":{"_account_id":16986,"name":"Shuquan Huang","email":"shuquan.huang@live.com","username":"shuquan"},"change_message_id":"8fab8fe57b46d7eb0cbd89a73b061319dca483d5","unresolved":false,"context_lines":[{"line_number":1029,"context_line":"        vnic_type \u003d CONF.network.port_vnic_type"},{"line_number":1030,"context_line":""},{"line_number":1031,"context_line":"        # If vnic_type is configured create port for"},{"line_number":1032,"context_line":"        # every network"},{"line_number":1033,"context_line":"        if vnic_type:"},{"line_number":1034,"context_line":"            ports \u003d []"},{"line_number":1035,"context_line":"            networks \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_ed09fe95","side":"PARENT","line":1032,"in_reply_to":"9a41bdd9_5798b977","updated":"2015-07-16 13:26:56.000000000","message":"Sure. I verified it from the tempest.log.\nThe setting is \"port_vnic_type \u003d normal\". And I can get the following log.\nBody: {\"port\": {\"status\": \"DOWN\", \"name\": \"tempest-port-quotatest-1027076731\", \"allowed_address_pairs\": [], \"admin_state_up\": true, \"network_id\"      : \"5b1ecefb-f78a-40c3-a0b2-13ed61b5a85a\", \"tenant_id\": \"0ab54e358aa341eb9922a05bf367fa96\", \"binding:vnic_type\": \"normal\", \"device_owner\": \"\", \"mac_addre      ss\": \"fa:16:3e:f6:a7:06\", \"port_security_enabled\": true, \"fixed_ips\": [{\"subnet_id\": \"d7cebe60-94ab-417d-9eff-242bf74ce7ed\", \"ip_address\": \"10.100.0.3\"}      ], \"id\": \"a161ce49-1cd7-4bcb-b4fb-de9291f6b677\", \"security_groups\": [\"2a1ffd3b-4261-4a9a-b733-35eae2d220d0\"], \"device_id\": \"\"}} _log_request_full /usr/l      ocal/lib/python2.7/dist-packages/tempest_lib/common/rest_client.py:411","commit_id":"a21251e03ba0465abb9c27ac63f8d2527eac3a16"},{"author":{"_account_id":16986,"name":"Shuquan Huang","email":"shuquan.huang@live.com","username":"shuquan"},"change_message_id":"b22fcc9ef89333b8c0dd2f793dc807c144c8f193","unresolved":false,"context_lines":[{"line_number":1029,"context_line":"        vnic_type \u003d CONF.network.port_vnic_type"},{"line_number":1030,"context_line":""},{"line_number":1031,"context_line":"        # If vnic_type is configured create port for"},{"line_number":1032,"context_line":"        # every network"},{"line_number":1033,"context_line":"        if vnic_type:"},{"line_number":1034,"context_line":"            ports \u003d []"},{"line_number":1035,"context_line":"            networks \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_4b36bb04","side":"PARENT","line":1032,"in_reply_to":"9a41bdd9_8bb6033c","updated":"2015-07-12 13:18:23.000000000","message":"We don\u0027t break the CI now. And we should not create port in this create_server function.","commit_id":"a21251e03ba0465abb9c27ac63f8d2527eac3a16"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"9146f6a8e37f0c570749bbcedc82260c6b9cb5b2","unresolved":false,"context_lines":[{"line_number":1029,"context_line":"        vnic_type \u003d CONF.network.port_vnic_type"},{"line_number":1030,"context_line":""},{"line_number":1031,"context_line":"        # If vnic_type is configured create port for"},{"line_number":1032,"context_line":"        # every network"},{"line_number":1033,"context_line":"        if vnic_type:"},{"line_number":1034,"context_line":"            ports \u003d []"},{"line_number":1035,"context_line":"            networks \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_5798b977","side":"PARENT","line":1032,"in_reply_to":"9a41bdd9_a5cfa154","updated":"2015-07-16 12:51:39.000000000","message":"Shuquan, When you running the tests is the port pre-created with vnic_type set?","commit_id":"a21251e03ba0465abb9c27ac63f8d2527eac3a16"},{"author":{"_account_id":16986,"name":"Shuquan Huang","email":"shuquan.huang@live.com","username":"shuquan"},"change_message_id":"a216e3e69870a1b13e0aba79ec9de70dd23a0718","unresolved":false,"context_lines":[{"line_number":1029,"context_line":"        vnic_type \u003d CONF.network.port_vnic_type"},{"line_number":1030,"context_line":""},{"line_number":1031,"context_line":"        # If vnic_type is configured create port for"},{"line_number":1032,"context_line":"        # every network"},{"line_number":1033,"context_line":"        if vnic_type:"},{"line_number":1034,"context_line":"            ports \u003d []"},{"line_number":1035,"context_line":"            networks \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_a5cfa154","side":"PARENT","line":1032,"in_reply_to":"9a41bdd9_aababcdf","updated":"2015-07-16 08:16:14.000000000","message":"@Itzik I test it locally with vnic_type set. All tests work correctly. what do you mean by giving another option to run the tests with pre-created port? Change the upstream CI test?","commit_id":"a21251e03ba0465abb9c27ac63f8d2527eac3a16"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"0bc9279a0afe253afdb7a053e943a35cf081b8f3","unresolved":false,"context_lines":[{"line_number":1029,"context_line":"        vnic_type \u003d CONF.network.port_vnic_type"},{"line_number":1030,"context_line":""},{"line_number":1031,"context_line":"        # If vnic_type is configured create port for"},{"line_number":1032,"context_line":"        # every network"},{"line_number":1033,"context_line":"        if vnic_type:"},{"line_number":1034,"context_line":"            ports \u003d []"},{"line_number":1035,"context_line":"            networks \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_d70b247c","side":"PARENT","line":1032,"in_reply_to":"9a41bdd9_bb330bf6","updated":"2015-07-17 15:28:30.000000000","message":"It seems that we have _setup_network_and_servers(boot_with_port\u003dTrue) only in one test \"test_preserve_preexisting_port\" (file test_network_basic_ops.py). But the idea of this test is to create a server with a pre-configured port, delete the server and check that the pre-configured port is not deleted. In accordance with your changes, now servers with pre-configured ports will be created only in test \"test_preserve_preexisting_port\". But this deleted method allows to create servers with pre-configured ports in all tests where this method is used if vnic_type is specified. I am OK with your change, but we lose possibility to create servers with pre-configured ports in other network scenario tests.","commit_id":"a21251e03ba0465abb9c27ac63f8d2527eac3a16"},{"author":{"_account_id":16986,"name":"Shuquan Huang","email":"shuquan.huang@live.com","username":"shuquan"},"change_message_id":"464b0ed38f59580295bc932ab13cb2096e80a1ff","unresolved":false,"context_lines":[{"line_number":1029,"context_line":"        vnic_type \u003d CONF.network.port_vnic_type"},{"line_number":1030,"context_line":""},{"line_number":1031,"context_line":"        # If vnic_type is configured create port for"},{"line_number":1032,"context_line":"        # every network"},{"line_number":1033,"context_line":"        if vnic_type:"},{"line_number":1034,"context_line":"            ports \u003d []"},{"line_number":1035,"context_line":"            networks \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_bb330bf6","side":"PARENT","line":1032,"in_reply_to":"9a41bdd9_c81ae87c","updated":"2015-07-17 03:03:08.000000000","message":"The port_vnic_type is intended to specify vnic type(sriov for example) for an instance.\nhttps://review.openstack.org/#/c/138808/7/specs/liberty/approved/api-specify-vnic-type.rst\nhttp://specs.openstack.org/openstack/nova-specs/specs/juno/implemented/pci-passthrough-sriov.html\nhttps://wiki.openstack.org/wiki/Nova-neutron-sriov\n\nI don\u0027t think we need 2 different options. \n1.When you create a port by method _create_port, if port_vnic_type is set, some type port will be created.\n2. For the scenario tests, if the case need a pre-configured port, it will call the method _setup_network_and_servers(boot_with_port\u003dTrue), which will call the _create_port.\n\nIn a word, there will be only one place to handle port creation which is in method _create_port","commit_id":"a21251e03ba0465abb9c27ac63f8d2527eac3a16"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"8222475201ae2b16253228c4f9234ebf28e96913","unresolved":false,"context_lines":[{"line_number":1029,"context_line":"        vnic_type \u003d CONF.network.port_vnic_type"},{"line_number":1030,"context_line":""},{"line_number":1031,"context_line":"        # If vnic_type is configured create port for"},{"line_number":1032,"context_line":"        # every network"},{"line_number":1033,"context_line":"        if vnic_type:"},{"line_number":1034,"context_line":"            ports \u003d []"},{"line_number":1035,"context_line":"            networks \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_fd9ba764","side":"PARENT","line":1032,"in_reply_to":"9a41bdd9_d70b247c","updated":"2015-07-17 15:52:17.000000000","message":"If servers with pre-configured ports should be created only in test \"test_preserve_preexisting_port\", this patch is correct for me.","commit_id":"a21251e03ba0465abb9c27ac63f8d2527eac3a16"},{"author":{"_account_id":16986,"name":"Shuquan Huang","email":"shuquan.huang@live.com","username":"shuquan"},"change_message_id":"3efb263e055f40d8c78ec1311e38bce79b172646","unresolved":false,"context_lines":[{"line_number":1029,"context_line":"        vnic_type \u003d CONF.network.port_vnic_type"},{"line_number":1030,"context_line":""},{"line_number":1031,"context_line":"        # If vnic_type is configured create port for"},{"line_number":1032,"context_line":"        # every network"},{"line_number":1033,"context_line":"        if vnic_type:"},{"line_number":1034,"context_line":"            ports \u003d []"},{"line_number":1035,"context_line":"            networks \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_5e207749","side":"PARENT","line":1032,"in_reply_to":"9a41bdd9_fd9ba764","updated":"2015-07-18 03:04:27.000000000","message":"I think the purpose of this case is to create servers with pre-configured ports and other cases don\u0027t mean to test with pre-configured ports. :)","commit_id":"a21251e03ba0465abb9c27ac63f8d2527eac3a16"}]}