)]}'
{"tempest/common/isolated_creds.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"5af39c16ddf6b91aaedc715823b36a11f0d5f4e2","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        # it must beassigned a role on the project. So we need to ensure that"},{"line_number":204,"context_line":"        # our newly created user has a role on the newly created project."},{"line_number":205,"context_line":"        if self.identity_version \u003d\u003d \u0027v3\u0027:"},{"line_number":206,"context_line":"            self.creds_client.assign_user_role(user, project, \u0027Member\u0027)"},{"line_number":207,"context_line":"        # Add roles specified in config file"},{"line_number":208,"context_line":"        for conf_role in CONF.auth.tempest_roles:"},{"line_number":209,"context_line":"            self.creds_client.assign_user_role(user, project, conf_role)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a41bdd9_50347a48","line":206,"updated":"2015-07-15 14:36:21.000000000","message":"\"Member\" role might not exist here.\n\nAlso we could optimise this by adding Member only if \"tempest_roles\" is empty","commit_id":"adf85332f884dffbd7b18a2d88656900bf5ce6d5"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"6c772cf0fa3e83669b1a9ea09dea781eccb6ddcc","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        # it must beassigned a role on the project. So we need to ensure that"},{"line_number":204,"context_line":"        # our newly created user has a role on the newly created project."},{"line_number":205,"context_line":"        if self.identity_version \u003d\u003d \u0027v3\u0027:"},{"line_number":206,"context_line":"            self.creds_client.assign_user_role(user, project, \u0027Member\u0027)"},{"line_number":207,"context_line":"        # Add roles specified in config file"},{"line_number":208,"context_line":"        for conf_role in CONF.auth.tempest_roles:"},{"line_number":209,"context_line":"            self.creds_client.assign_user_role(user, project, conf_role)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a41bdd9_c1e3ded7","line":206,"in_reply_to":"9a41bdd9_50347a48","updated":"2015-07-15 15:18:00.000000000","message":"Done","commit_id":"adf85332f884dffbd7b18a2d88656900bf5ce6d5"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"28f8e19f8ea230431a90d01ed11c255dcb142ff8","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            role \u003d next(r for r in roles if r[\u0027name\u0027] \u003d\u003d role_name)"},{"line_number":58,"context_line":"        except StopIteration:"},{"line_number":59,"context_line":"            return None"},{"line_number":60,"context_line":"        return role"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def create_user_role(self, role_name):"},{"line_number":63,"context_line":"        if not self._check_role_exists(role_name):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a41bdd9_c7c2f752","line":60,"updated":"2015-07-16 00:48:36.000000000","message":"How about returning True/False as the method name?\n\nFrom the usages of this method, True/False is enough and simple.","commit_id":"32f98a43d313bac1b657c2e0525003a8657b36a1"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"b67cbd9aab362a066bcea96136b1bd2cbd001bf0","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            role \u003d next(r for r in roles if r[\u0027name\u0027] \u003d\u003d role_name)"},{"line_number":58,"context_line":"        except StopIteration:"},{"line_number":59,"context_line":"            return None"},{"line_number":60,"context_line":"        return role"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def create_user_role(self, role_name):"},{"line_number":63,"context_line":"        if not self._check_role_exists(role_name):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a41bdd9_83d5c2e5","line":60,"in_reply_to":"9a41bdd9_a776d303","updated":"2015-07-16 01:35:20.000000000","message":"Oops, I got it now.\nOK, that is reasonable.","commit_id":"32f98a43d313bac1b657c2e0525003a8657b36a1"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"fd385658bcba2866e3f2f0db74e50ce288c3f79f","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            role \u003d next(r for r in roles if r[\u0027name\u0027] \u003d\u003d role_name)"},{"line_number":58,"context_line":"        except StopIteration:"},{"line_number":59,"context_line":"            return None"},{"line_number":60,"context_line":"        return role"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def create_user_role(self, role_name):"},{"line_number":63,"context_line":"        if not self._check_role_exists(role_name):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a41bdd9_a776d303","line":60,"in_reply_to":"9a41bdd9_c7c2f752","updated":"2015-07-16 00:56:34.000000000","message":"Heh,  take a look at the previous revision that\u0027s what I did there. The problem is while that\u0027s fine for create_user_role() , but assign_user_role() needs the actual role dictionary to get the id for the assign.","commit_id":"32f98a43d313bac1b657c2e0525003a8657b36a1"}]}