)]}'
{"tempest/tests/services/compute/test_aggregates_client.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"0a131645f498e1f9318c5ca445f1b35f2873feb6","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from tempest.tests import fake_auth_provider"},{"line_number":23,"context_line":"from tempest.tests import fake_config"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class TestAggregatesClient(base.TestCase):"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_2334f6f9","line":25,"updated":"2015-07-16 01:47:13.000000000","message":"too many blank lines.\n\n2 blank lines between \"import\" section and \"class\".","commit_id":"55889f826ca9f9910369edd9c76a0f6df435b6b1"},{"author":{"_account_id":17104,"name":"Kenji Yasui","email":"k-yasui@ti.jp.nec.com","username":"yasui"},"change_message_id":"27f9cdcd2d4e7f58995bb60a362671bd95914fdd","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from tempest.tests import fake_auth_provider"},{"line_number":23,"context_line":"from tempest.tests import fake_config"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class TestAggregatesClient(base.TestCase):"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_d71e200b","line":25,"in_reply_to":"9a41bdd9_2334f6f9","updated":"2015-07-16 04:06:43.000000000","message":"Thank you for your comment.\nI had fixed, please check again.","commit_id":"55889f826ca9f9910369edd9c76a0f6df435b6b1"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f9811e1779dfd691c260ce690d4b1ec0e6c591c4","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        self.useFixture(fake_config.ConfigFixture())"},{"line_number":31,"context_line":"        fake_auth \u003d fake_auth_provider.FakeAuthProvider()"},{"line_number":32,"context_line":"        self.client \u003d aggregates_client.AggregatesClient(fake_auth,"},{"line_number":33,"context_line":"                                                 \u0027compute\u0027, \u0027regionOne\u0027)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def _test_list_aggregates(self, bytes_body\u003dFalse):"},{"line_number":36,"context_line":"        if bytes_body:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_dbdba24d","line":33,"updated":"2015-07-16 08:53:51.000000000","message":"This indent is wrong and this patch cannot pass pep8 check.\n\nCan you check console.html like\n\nhttp://logs.openstack.org/78/201978/2/check/gate-tempest-pep8/48a0c81/console.html#_2015-07-16_04_07_59_215\n\n?","commit_id":"0c14709a7a615258d4d7ce7dae25405a77bac61f"},{"author":{"_account_id":17104,"name":"Kenji Yasui","email":"k-yasui@ti.jp.nec.com","username":"yasui"},"change_message_id":"4de499f66f2853ff5789deaf660de83f52654df8","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        self.useFixture(fake_config.ConfigFixture())"},{"line_number":31,"context_line":"        fake_auth \u003d fake_auth_provider.FakeAuthProvider()"},{"line_number":32,"context_line":"        self.client \u003d aggregates_client.AggregatesClient(fake_auth,"},{"line_number":33,"context_line":"                                                 \u0027compute\u0027, \u0027regionOne\u0027)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def _test_list_aggregates(self, bytes_body\u003dFalse):"},{"line_number":36,"context_line":"        if bytes_body:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_b1703f73","line":33,"in_reply_to":"9a41bdd9_dbdba24d","updated":"2015-07-16 09:32:25.000000000","message":"Tnank you.\nI\u0027ll fix it.","commit_id":"0c14709a7a615258d4d7ce7dae25405a77bac61f"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"cc0ecaaec4f721f2816c621252fe66d9f0a0ae53","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import httplib2"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslotest import mockpatch"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_1f39c441","line":15,"updated":"2015-07-17 02:45:06.000000000","message":"nit: one blank line is enough here.","commit_id":"cecd209d268f02fc55448f95daaa800c54364421"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"cc0ecaaec4f721f2816c621252fe66d9f0a0ae53","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        if bytes_body:"},{"line_number":37,"context_line":"            body \u003d bytes(b\u0027{\"aggregates\": []}\u0027)"},{"line_number":38,"context_line":"        else:"},{"line_number":39,"context_line":"            body \u003d \u0027{\"aggregates\": []}\u0027"},{"line_number":40,"context_line":"        expected \u003d []"},{"line_number":41,"context_line":"        response \u003d (httplib2.Response({\u0027status\u0027: 200}), body)"},{"line_number":42,"context_line":"        self.useFixture(mockpatch.Patch("}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_dff4bc88","line":39,"updated":"2015-07-17 02:45:06.000000000","message":"That is my bad but current code seems a little redundant.\n\nSo can you check https://review.openstack.org/#/c/202852 and apply the change to here also?","commit_id":"cecd209d268f02fc55448f95daaa800c54364421"},{"author":{"_account_id":17104,"name":"Kenji Yasui","email":"k-yasui@ti.jp.nec.com","username":"yasui"},"change_message_id":"52326b3be7b3361079fde23f561cb757a4c71017","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        if bytes_body:"},{"line_number":37,"context_line":"            body \u003d bytes(b\u0027{\"aggregates\": []}\u0027)"},{"line_number":38,"context_line":"        else:"},{"line_number":39,"context_line":"            body \u003d \u0027{\"aggregates\": []}\u0027"},{"line_number":40,"context_line":"        expected \u003d []"},{"line_number":41,"context_line":"        response \u003d (httplib2.Response({\u0027status\u0027: 200}), body)"},{"line_number":42,"context_line":"        self.useFixture(mockpatch.Patch("}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_5b5bdf2e","line":39,"in_reply_to":"9a41bdd9_dff4bc88","updated":"2015-07-17 10:57:16.000000000","message":"thank you. I\u0027ll refer to your pach and fix here.","commit_id":"cecd209d268f02fc55448f95daaa800c54364421"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"563c4f60c8bcbab42be70c70506d9a3a2242d268","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def setUp(self):"},{"line_number":28,"context_line":"        super(TestAggregatesClient, self).setUp()"},{"line_number":29,"context_line":"        self.useFixture(fake_config.ConfigFixture())"},{"line_number":30,"context_line":"        fake_auth \u003d fake_auth_provider.FakeAuthProvider()"},{"line_number":31,"context_line":"        self.client \u003d aggregates_client.AggregatesClient("},{"line_number":32,"context_line":"            fake_auth, \u0027compute\u0027, \u0027regionOne\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_f6ba2071","line":29,"updated":"2015-07-23 22:10:48.000000000","message":"Sorry for missing this point on my previous review.\nThis self.useFixture call(line29) is unnecessary.","commit_id":"655e42d4fb04472b4351eac4e99f199d8905ffe7"},{"author":{"_account_id":17104,"name":"Kenji Yasui","email":"k-yasui@ti.jp.nec.com","username":"yasui"},"change_message_id":"9a7a9b447464b56e413cae64e33232fb2f89c0c2","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def setUp(self):"},{"line_number":28,"context_line":"        super(TestAggregatesClient, self).setUp()"},{"line_number":29,"context_line":"        self.useFixture(fake_config.ConfigFixture())"},{"line_number":30,"context_line":"        fake_auth \u003d fake_auth_provider.FakeAuthProvider()"},{"line_number":31,"context_line":"        self.client \u003d aggregates_client.AggregatesClient("},{"line_number":32,"context_line":"            fake_auth, \u0027compute\u0027, \u0027regionOne\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_94306aea","line":29,"in_reply_to":"3a50d1a3_f6ba2071","updated":"2015-07-27 02:47:42.000000000","message":"Thank you for your comment. I\u0027ll fix here.","commit_id":"655e42d4fb04472b4351eac4e99f199d8905ffe7"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"de3dd09b6c23c299f2ea99bda99ede7f7de47abe","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    def _test_list_aggregates(self, bytes_body\u003dFalse):"},{"line_number":35,"context_line":"        body \u003d \u0027{\"aggregates\": []}\u0027"},{"line_number":36,"context_line":"        if bytes_body:"},{"line_number":37,"context_line":"            body \u003d bytes(body.encode(\u0027utf-8\u0027))"},{"line_number":38,"context_line":"        expected \u003d []"},{"line_number":39,"context_line":"        response \u003d (httplib2.Response({\u0027status\u0027: 200}), body)"},{"line_number":40,"context_line":"        self.useFixture(mockpatch.Patch("}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_e2235ebb","line":37,"updated":"2015-07-23 12:47:41.000000000","message":"The cast to \"bytes\" seems redundant. I think, but I am not an expert, that encode will always return \"bytes\".\n\nAlso, you sure you need to use encode(\u0027utf-8\u0027) ? You don\"t have any non-ascii chars...","commit_id":"655e42d4fb04472b4351eac4e99f199d8905ffe7"},{"author":{"_account_id":17104,"name":"Kenji Yasui","email":"k-yasui@ti.jp.nec.com","username":"yasui"},"change_message_id":"9a7a9b447464b56e413cae64e33232fb2f89c0c2","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    def _test_list_aggregates(self, bytes_body\u003dFalse):"},{"line_number":35,"context_line":"        body \u003d \u0027{\"aggregates\": []}\u0027"},{"line_number":36,"context_line":"        if bytes_body:"},{"line_number":37,"context_line":"            body \u003d bytes(body.encode(\u0027utf-8\u0027))"},{"line_number":38,"context_line":"        expected \u003d []"},{"line_number":39,"context_line":"        response \u003d (httplib2.Response({\u0027status\u0027: 200}), body)"},{"line_number":40,"context_line":"        self.useFixture(mockpatch.Patch("}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_37b958ed","line":37,"in_reply_to":"3a50d1a3_e2235ebb","updated":"2015-07-27 02:47:42.000000000","message":"Thank you for your comment. \"bytes\" is redundant, I\u0027ll fix it. \n\nI think, in this case, I can use any non-ascii characters. Because the encode is necessary only to use \"httplib2\".","commit_id":"655e42d4fb04472b4351eac4e99f199d8905ffe7"}]}