)]}'
{"tempest/tests/services/compute/test_availability_zone_client.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"069a9676469c5a02ede59f6d1fd57131ba879c27","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def setUp(self):"},{"line_number":28,"context_line":"        super(TestAvailabilityZoneClient, self).setUp()"},{"line_number":29,"context_line":"        self.useFixture(fake_config.ConfigFixture())"},{"line_number":30,"context_line":"        fake_auth \u003d fake_auth_provider.FakeAuthProvider()"},{"line_number":31,"context_line":"        self.client \u003d availability_zone_client.AvailabilityZoneClient("},{"line_number":32,"context_line":"            fake_auth, \u0027compute\u0027, \u0027regionOne\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_99d74cbf","line":29,"updated":"2015-07-24 00:42:13.000000000","message":"self.useFixture(fake_config.ConfigFixture()) is not needed of these tests.","commit_id":"afc1cebd20cf6ca0115dbaf9ac4d21e16312998d"},{"author":{"_account_id":17104,"name":"Kenji Yasui","email":"k-yasui@ti.jp.nec.com","username":"yasui"},"change_message_id":"6f1d4a399e416c52834c640756c9b9cb2b94d2c5","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def setUp(self):"},{"line_number":28,"context_line":"        super(TestAvailabilityZoneClient, self).setUp()"},{"line_number":29,"context_line":"        self.useFixture(fake_config.ConfigFixture())"},{"line_number":30,"context_line":"        fake_auth \u003d fake_auth_provider.FakeAuthProvider()"},{"line_number":31,"context_line":"        self.client \u003d availability_zone_client.AvailabilityZoneClient("},{"line_number":32,"context_line":"            fake_auth, \u0027compute\u0027, \u0027regionOne\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_0148e5b1","line":29,"in_reply_to":"3a50d1a3_99d74cbf","updated":"2015-07-29 02:55:49.000000000","message":"Thank you for your review. I had fixed here, please check again.","commit_id":"afc1cebd20cf6ca0115dbaf9ac4d21e16312998d"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"5082c17704f3e20443c00a743ab2cae3dca7f539","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def _test_list_availability_zones(self, bytes_body\u003dFalse):"},{"line_number":33,"context_line":"        body \u003d \u0027{\"availabilityZoneInfo\": []}\u0027"},{"line_number":34,"context_line":"        if bytes_body:"},{"line_number":35,"context_line":"            body \u003d body.encode(\u0027utf-8\u0027)"},{"line_number":36,"context_line":"        expected \u003d []"},{"line_number":37,"context_line":"        response \u003d (httplib2.Response({\u0027status\u0027: 200}), body)"},{"line_number":38,"context_line":"        self.useFixture(mockpatch.Patch("}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_d7c49b60","line":35,"updated":"2015-08-10 06:29:15.000000000","message":"On which (supported) platform and code page does it makes a difference ?\n\nAll code-point in the body \u003c 128.","commit_id":"42e1b8b20364cef4b96a4ef75570b0426133b5e5"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"273532ade8a53cc0ae46ef8716076b02e9e9070e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def _test_list_availability_zones(self, bytes_body\u003dFalse):"},{"line_number":33,"context_line":"        body \u003d \u0027{\"availabilityZoneInfo\": []}\u0027"},{"line_number":34,"context_line":"        if bytes_body:"},{"line_number":35,"context_line":"            body \u003d body.encode(\u0027utf-8\u0027)"},{"line_number":36,"context_line":"        expected \u003d []"},{"line_number":37,"context_line":"        response \u003d (httplib2.Response({\u0027status\u0027: 200}), body)"},{"line_number":38,"context_line":"        self.useFixture(mockpatch.Patch("}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_df7d3b1d","line":35,"in_reply_to":"1a4dcd0f_d7c49b60","updated":"2015-08-11 14:33:16.000000000","message":"I agree with afazekas. It\u0027s not so great to give the impression that the clients are tested to handle properly Unicode vs bytes, whilst it\u0027s not the case.\n\nSo you should either remove one of the 2 test (test_list_availability_zones_with_str_body or test_list_availability_zones_with_bytes_body) because it\u0027s the exact same test. Or add some elements in your \"availabilityZoneInfo\" dict, elements with some funny Unicode characters.","commit_id":"42e1b8b20364cef4b96a4ef75570b0426133b5e5"},{"author":{"_account_id":17104,"name":"Kenji Yasui","email":"k-yasui@ti.jp.nec.com","username":"yasui"},"change_message_id":"6440ad4cd597ee2e76e8b6c7234154fc26fa9444","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def _test_list_availability_zones(self, bytes_body\u003dFalse):"},{"line_number":33,"context_line":"        body \u003d \u0027{\"availabilityZoneInfo\": []}\u0027"},{"line_number":34,"context_line":"        if bytes_body:"},{"line_number":35,"context_line":"            body \u003d body.encode(\u0027utf-8\u0027)"},{"line_number":36,"context_line":"        expected \u003d []"},{"line_number":37,"context_line":"        response \u003d (httplib2.Response({\u0027status\u0027: 200}), body)"},{"line_number":38,"context_line":"        self.useFixture(mockpatch.Patch("}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_d672557c","line":35,"in_reply_to":"1a4dcd0f_df7d3b1d","updated":"2015-08-18 04:45:48.000000000","message":"Thank you for your review.\nI had removed the 2 tests, and fixed problems.\n\nPlease check here again.","commit_id":"42e1b8b20364cef4b96a4ef75570b0426133b5e5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9e51ddf3231ea7e29b8c60ae47596790c903ef42","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        self.useFixture(mockpatch.Patch("},{"line_number":37,"context_line":"            \u0027tempest.common.service_client.ServiceClient.get\u0027,"},{"line_number":38,"context_line":"            return_value\u003dresponse))"},{"line_number":39,"context_line":"        self.assertEqual(expected, self.client.list_availability_zones())"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa1b9901_15afb87d","line":39,"updated":"2015-08-21 01:09:24.000000000","message":"I am much in favor of testing with bytes_body\u003dTrue.\n\nI agree that as we do not have much smarty unicode string there but that still tests the case of Byte type for py3 for which below changes were done.\nOn python 3 httplib2 returns a bytes type for the response body not string.\n\n- https://review.openstack.org/#/c/201155/\n\nWith current tests actually we are not testing anything much valuable.","commit_id":"414417b8222300f6b0b2f66b1e59d3a47c3ae98b"},{"author":{"_account_id":17104,"name":"Kenji Yasui","email":"k-yasui@ti.jp.nec.com","username":"yasui"},"change_message_id":"ec55475353835d355e2e890b17780655247b5cb2","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        self.useFixture(mockpatch.Patch("},{"line_number":37,"context_line":"            \u0027tempest.common.service_client.ServiceClient.get\u0027,"},{"line_number":38,"context_line":"            return_value\u003dresponse))"},{"line_number":39,"context_line":"        self.assertEqual(expected, self.client.list_availability_zones())"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa1b9901_bd4a7253","line":39,"updated":"2015-08-21 02:41:21.000000000","message":"Thank you for your review. \n\nI had fixed here. It is good if I modify as your comments, but I think I\u0027m mistaken about your comments. Please review here again.","commit_id":"414417b8222300f6b0b2f66b1e59d3a47c3ae98b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5eeb8eb7690da28864d8cb60a505b2e12559bc63","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        self.client \u003d availability_zone_client.AvailabilityZoneClient("},{"line_number":30,"context_line":"            fake_auth, \u0027compute\u0027, \u0027regionOne\u0027)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def test_list_availability_zones(self, bytes_body\u003dTrue):"},{"line_number":33,"context_line":"        body \u003d \u0027{\"availabilityZoneInfo\": []}\u0027"},{"line_number":34,"context_line":"        expected \u003d []"},{"line_number":35,"context_line":"        response \u003d (httplib2.Response({\u0027status\u0027: 200}), body)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa1b9901_6353cc17","line":32,"updated":"2015-08-21 08:23:04.000000000","message":"where we are using bytes_body ?\n\nI mean we should have both tests with bytes_body true and false as in PS4","commit_id":"37504aa97d3ed5ad2e7c4dd02ebed285081fda66"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f40aa273932ca017ee462d103db5579e3d522053","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            \u0027tempest.common.service_client.ServiceClient.get\u0027,"},{"line_number":52,"context_line":"            return_value\u003dmocked_resp))"},{"line_number":53,"context_line":"        resp \u003d self.client.list_availability_zones()"},{"line_number":54,"context_line":"        self.assertEqual(self.FAKE_AVAILABIRITY_ZONE_INFO, resp)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test_list_availability_zones_with_str_body(self):"},{"line_number":57,"context_line":"        self._test_list_availability_zones()"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa1b9901_a37da16e","line":54,"updated":"2015-08-26 07:40:23.000000000","message":"https://review.openstack.org/#/c/208821/ is merged and client start returning full response. please update here too-\n\nself.FAKE_AVAILABIRITY_ZONE_INFO -\u003e {\t\n            \"availabilityZoneInfo\": self.FAKE_AVAILABIRITY_ZONE_INFO}","commit_id":"af9bf82153c2aa451190d90dd7b3431ba8e6f503"},{"author":{"_account_id":17104,"name":"Kenji Yasui","email":"k-yasui@ti.jp.nec.com","username":"yasui"},"change_message_id":"35bcb1dcc65a8f79d32c8f3e6989719b43530fb2","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            \u0027tempest.common.service_client.ServiceClient.get\u0027,"},{"line_number":52,"context_line":"            return_value\u003dmocked_resp))"},{"line_number":53,"context_line":"        resp \u003d self.client.list_availability_zones()"},{"line_number":54,"context_line":"        self.assertEqual(self.FAKE_AVAILABIRITY_ZONE_INFO, resp)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test_list_availability_zones_with_str_body(self):"},{"line_number":57,"context_line":"        self._test_list_availability_zones()"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa1b9901_c3b695db","line":54,"in_reply_to":"fa1b9901_a37da16e","updated":"2015-08-26 07:44:12.000000000","message":"Thank you for your comment. I\u0027ll modify here.","commit_id":"af9bf82153c2aa451190d90dd7b3431ba8e6f503"}]}