)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":8001,"name":"John Warren","email":"jswarren@us.ibm.com","username":"jswarren"},"change_message_id":"f6d89f255cb56fb4ba5ff735c5ba7783fbaa9469","unresolved":false,"context_lines":[{"line_number":487,"context_line":"                    }"},{"line_number":488,"context_line":"                )"},{"line_number":489,"context_line":"            return (proc.returncode \u003d\u003d 0) \u003d\u003d should_succeed"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"        return tempest.test.call_until_true(ping, timeout, 1)"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    def check_vm_connectivity(self, ip_address,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_44220903","line":490,"updated":"2015-08-14 17:30:07.000000000","message":"I\u0027m thinking in order to make this less verbose the logging should be removed from the ping method and be put around the call to call_until_true.  A log message before the call indicating the caller, ip address, the timeout and the expected outcome and a log message after the call indicating that the ping was successful or failed (relative to should_succeed), once again providing the caller and ip address.  This would limit the output to two log messages, regardless of how many times the ping command is executed.","commit_id":"6b65155feba1503fc3b35308b5e00ee157fac877"},{"author":{"_account_id":16986,"name":"Shuquan Huang","email":"shuquan.huang@live.com","username":"shuquan"},"change_message_id":"a6d7869c2cab72b0f3e9c88a25c3801bb94b7498","unresolved":false,"context_lines":[{"line_number":487,"context_line":"                    }"},{"line_number":488,"context_line":"                )"},{"line_number":489,"context_line":"            return (proc.returncode \u003d\u003d 0) \u003d\u003d should_succeed"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"        return tempest.test.call_until_true(ping, timeout, 1)"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    def check_vm_connectivity(self, ip_address,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_53ca654f","line":490,"in_reply_to":"1a4dcd0f_44220903","updated":"2015-08-20 05:54:17.000000000","message":"Your suggestion is very constructive. :)","commit_id":"6b65155feba1503fc3b35308b5e00ee157fac877"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"61db2c4939040052fb9df54cdeeef764377e98dd","unresolved":false,"context_lines":[{"line_number":458,"context_line":"                                    stdout\u003dsubprocess.PIPE,"},{"line_number":459,"context_line":"                                    stderr\u003dsubprocess.PIPE)"},{"line_number":460,"context_line":"            proc.communicate()"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"            return (proc.returncode \u003d\u003d 0) \u003d\u003d should_succeed"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"        caller \u003d misc_utils.find_test_caller()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_a25c9b7d","line":461,"updated":"2015-09-30 12:35:03.000000000","message":"unexpected white-space change.","commit_id":"527c29ff0329c93cf28f658091f8c624d2a29596"}]}