)]}'
{"tempest/tests/services/compute/test_extensions_client.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"de537aeab5b1c7117d70cad47a4f691082d99661","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def setUp(self):"},{"line_number":28,"context_line":"        super(TestExtensionsClient, self).setUp()"},{"line_number":29,"context_line":"        self.useFixture(fake_config.ConfigFixture())"},{"line_number":30,"context_line":"        fake_auth \u003d fake_auth_provider.FakeAuthProvider()"},{"line_number":31,"context_line":"        self.client \u003d extensions_client.ExtensionsClient("},{"line_number":32,"context_line":"            fake_auth, \u0027compute\u0027, \u0027regionOne\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_995aec4f","line":29,"updated":"2015-07-24 00:47:57.000000000","message":"ConfigFixture not needed for these tests","commit_id":"712660d5ad8b9fef690e0ce82aa5c1a619ba904d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"de537aeab5b1c7117d70cad47a4f691082d99661","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            \"http://docs.openstack.org/compute/ext/multinic/api/v1.1\","},{"line_number":78,"context_line":"            \"alias\": \"NMN\","},{"line_number":79,"context_line":"            \"description\": \"Multiple network support.\""},{"line_number":80,"context_line":"        }"},{"line_number":81,"context_line":"        response \u003d (httplib2.Response({\u0027status\u0027: 200}), body)"},{"line_number":82,"context_line":"        self.useFixture(mockpatch.Patch("},{"line_number":83,"context_line":"            \u0027tempest.common.service_client.ServiceClient.get\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_d9471476","line":80,"updated":"2015-07-24 00:47:57.000000000","message":"we can share like below-\n\n      NMN_extension \u003d {\n            \"updated\": \"2011-06-09T00:00:00Z\",\n            \"name\": \"Multinic\",\n            \"links\": [],\n            \"namespace\":\n            \"http://docs.openstack.org/compute/ext/multinic/api/v1.1\",\n            \"alias\": \"NMN\",\n            \"description\": \"Multiple network support.\"\n        }\n\tif bytes_body:\t\n            body \u003d bytes(b\u0027\u0027\u0027{\"extension\": NMN_extension}\u0027\u0027\u0027)\n        else:\t\n            body \u003d (\u0027\u0027\u0027{\"extension\": NMN_extension}\u0027\u0027\u0027)\t\n        expected \u003d  NMN_extension","commit_id":"712660d5ad8b9fef690e0ce82aa5c1a619ba904d"},{"author":{"_account_id":17104,"name":"Kenji Yasui","email":"k-yasui@ti.jp.nec.com","username":"yasui"},"change_message_id":"8a8decfcc68f6db011b12923cd898d28992b7d8a","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            \"http://docs.openstack.org/compute/ext/multinic/api/v1.1\","},{"line_number":78,"context_line":"            \"alias\": \"NMN\","},{"line_number":79,"context_line":"            \"description\": \"Multiple network support.\""},{"line_number":80,"context_line":"        }"},{"line_number":81,"context_line":"        response \u003d (httplib2.Response({\u0027status\u0027: 200}), body)"},{"line_number":82,"context_line":"        self.useFixture(mockpatch.Patch("},{"line_number":83,"context_line":"            \u0027tempest.common.service_client.ServiceClient.get\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_44111b51","line":80,"in_reply_to":"3a50d1a3_1c51ea0e","updated":"2015-07-29 03:07:55.000000000","message":"Thank you for your comment. I had fixed by your comment and other pathc\u0027s comments.Please check here again.","commit_id":"712660d5ad8b9fef690e0ce82aa5c1a619ba904d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3f6538dd6da04af779921f36b1d50e2b12845c85","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            \"http://docs.openstack.org/compute/ext/multinic/api/v1.1\","},{"line_number":78,"context_line":"            \"alias\": \"NMN\","},{"line_number":79,"context_line":"            \"description\": \"Multiple network support.\""},{"line_number":80,"context_line":"        }"},{"line_number":81,"context_line":"        response \u003d (httplib2.Response({\u0027status\u0027: 200}), body)"},{"line_number":82,"context_line":"        self.useFixture(mockpatch.Patch("},{"line_number":83,"context_line":"            \u0027tempest.common.service_client.ServiceClient.get\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_1c51ea0e","line":80,"in_reply_to":"3a50d1a3_d9471476","updated":"2015-07-24 00:52:12.000000000","message":"or just\n      expected \u003d {\n            \"updated\": \"2011-06-09T00:00:00Z\",\n            \"name\": \"Multinic\",\n            \"links\": [],\n            \"namespace\":\n            \"http://docs.openstack.org/compute/ext/multinic/api/v1.1\",\n            \"alias\": \"NMN\",\n            \"description\": \"Multiple network support.\"\n        }\n\tif bytes_body:\t\n            body \u003d bytes(b\u0027\u0027\u0027{\"extension\": expected}\u0027\u0027\u0027)\n        else:\t\n            body \u003d (\u0027\u0027\u0027{\"extension\": expected}\u0027\u0027\u0027)","commit_id":"712660d5ad8b9fef690e0ce82aa5c1a619ba904d"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"2e4dd3664ac142536a5e46de48db6715739f64da","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            \"namespace\":"},{"line_number":56,"context_line":"            \"http://docs.openstack.org/compute/ext/multinic/api/v1.1\","},{"line_number":57,"context_line":"            \"alias\": \"NMN\","},{"line_number":58,"context_line":"            \"description\": \"Multiple network support.\""},{"line_number":59,"context_line":"        }"},{"line_number":60,"context_line":"        serialized_body \u003d json.dumps({\"extension\": expected})"},{"line_number":61,"context_line":"        if bytes_body:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_afb3e109","line":58,"updated":"2015-08-03 15:02:51.000000000","message":"Could you add some unicode char in the description ?\n\nIf you want to actually test that Tempest clients properly handle string manipulation, you need to add some Unicode char in the tests.\n\nHere\u0027s why: let\u0027s assume you run python2. If you do:\n\n var\u003d\u0027a\u0027\n print var.encode(\"utf-8\")\n\nAn \u0027a\u0027 will be printed. So you would thing this code is correct. But it\u0027s wrong. Because in Python2, the type of \u0027var\u0027 would be \u0027bytes\u0027 and it doesn\"t make sense to encode \u0027bytes\u0027 into utf-8. You can test this code is wrong because now if you run (in Python):\n\n var\u003d\u0027û\u0027\n print var.encode(\"utf-8\")\n\nYou get \"UnicodeDecodeError: \u0027ascii\u0027 codec can\u0027t decode byte 0xc3 in position 0: ordinal not in range(128)\"\n\nThat\u0027s why I recommend that here, and everywhere you want to test proper Unicode handling, you replace\n\n \"description\": \"Multiple network support.\"\n\nwith\n\n \"description\": u\u0027\\u2740(*\\xb4\\u25e1`*)\\u2740\u0027","commit_id":"67bd6b25e8da240a0845985b31c1cb7ed6aaecd1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0aae4b8eff00edec4f17a70db77595f3f83fab90","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            \"namespace\":"},{"line_number":56,"context_line":"            \"http://docs.openstack.org/compute/ext/multinic/api/v1.1\","},{"line_number":57,"context_line":"            \"alias\": \"NMN\","},{"line_number":58,"context_line":"            \"description\": \"Multiple network support.\""},{"line_number":59,"context_line":"        }"},{"line_number":60,"context_line":"        serialized_body \u003d json.dumps({\"extension\": expected})"},{"line_number":61,"context_line":"        if bytes_body:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_8366274f","line":58,"in_reply_to":"1a4dcd0f_afb3e109","updated":"2015-08-07 06:24:10.000000000","message":"Actually as we convert it to JSON object using json.dumps, unicode string will be converted to string and .encode(\"utf-8\") will return the byte object without actually doing the encoding with utf-8 unlike the case of byte string as shown below-\n\n\u003e\u003e\u003e d \u003d \"{ \u0027as\u0027: u\u0027\\u00c3\u0027}\"\n\u003e\u003e\u003e d.encode(\"utf-8\")\nb\"{ \u0027as\u0027: u\u0027\\xc3\\x83\u0027}\"\n\u003e\u003e\u003e \n\n\u003e\u003e\u003e d \u003d { \u0027as\u0027: u\u0027\\u00c3\u0027}\n\u003e\u003e\u003e d \u003d json.dumps(d)\n\u003e\u003e\u003e d.encode(\"utf-8\")\nb\u0027{\"as\": \"\\\\u00c3\"}\u0027\n\u003e\u003e\u003e \n\nBut it does not harm with Unicode also so m ok for both way.","commit_id":"67bd6b25e8da240a0845985b31c1cb7ed6aaecd1"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"2e4dd3664ac142536a5e46de48db6715739f64da","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        }"},{"line_number":60,"context_line":"        serialized_body \u003d json.dumps({\"extension\": expected})"},{"line_number":61,"context_line":"        if bytes_body:"},{"line_number":62,"context_line":"            serialized_body \u003d bytes(serialized_body.encode(\u0027utf-8\u0027))"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        mocked_resp \u003d (httplib2.Response({\u0027status\u0027: 200}), serialized_body)"},{"line_number":65,"context_line":"        self.useFixture(mockpatch.Patch("}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_6fe71913","line":62,"updated":"2015-08-03 15:02:51.000000000","message":"The cast to \"bytes\" is unneeded.","commit_id":"67bd6b25e8da240a0845985b31c1cb7ed6aaecd1"}]}