)]}'
{"tempest/tests/services/compute/test_keypairs_client.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"2eb37133afa8c942bba28b094e5c2ceb9da8c551","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                       \"fingerprint\":"},{"line_number":73,"context_line":"                       \"76:24:66:49:d7:ca:6e:5c:77:ea:8e:bb:9c:15:5f:98\","},{"line_number":74,"context_line":"                       \"deleted_at\": null,"},{"line_number":75,"context_line":"                       \"id\": 1}}\u0027\u0027\u0027)"},{"line_number":76,"context_line":"        expected \u003d {\"public_key\": \"ssh-rsa foo Generated-by-Nova\","},{"line_number":77,"context_line":"                    \"user_id\":"},{"line_number":78,"context_line":"                    \"525d55f98980415ba98e634972fa4a10\","}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_51ff5eaa","line":75,"updated":"2015-07-23 22:24:28.000000000","message":"it is better to share this body between bytes_body for avoiding redundant code.","commit_id":"99eded97fac9e1bcf5cf86c9bdb29bafe2aecac5"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"721c78ecd8c3007d3db5588da632771573715e4f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from tempest.tests import fake_auth_provider"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TestKeyPairsClient(base.TestCase):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def setUp(self):"},{"line_number":28,"context_line":"        super(TestKeyPairsClient, self).setUp()"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_95095434","line":25,"updated":"2015-08-03 15:28:21.000000000","message":"You are duplicating the keypair dict twice here. What I would do is define a base dict here:\n\n  FAKE_KEYPAIR \u003d {\n\"public_key\": \"ssh-rsa foo Generated-by-Nova\",\n\"name\":  u\u0027\\u2740(*\\xb4\\u25e1`*)\\u2740\u0027,\n\"user_id\": \"525d55f98980415ba98e634972fa4a10\",\n\"fingerprint\":              \"76:24:66:49:d7:ca:6e:5c:77:ea:8e:bb:9c:15:5f:98\"\n}\n\nAnd then in _test_show_keypair and _test_create_keypair I would copy FAKE_KEYPAIR and add the additional key/value in the copied dict.\n\nFor a good example, take a look at: https://github.com/openstack/tempest/blob/master/tempest/tests/fake_identity.py","commit_id":"1e5be457006e9eed067c5e07b64abd9ada25d74c"},{"author":{"_account_id":17104,"name":"Kenji Yasui","email":"k-yasui@ti.jp.nec.com","username":"yasui"},"change_message_id":"8b23f5d5b7558e7881a40e9bcb4f2faf0c3fb8a1","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from tempest.tests import fake_auth_provider"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TestKeyPairsClient(base.TestCase):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def setUp(self):"},{"line_number":28,"context_line":"        super(TestKeyPairsClient, self).setUp()"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_cba281ae","line":25,"in_reply_to":"1a4dcd0f_95095434","updated":"2015-08-05 03:08:39.000000000","message":"Thank you for your detailed comment.\n\nBased on a sample that you gave me , I will fix here .","commit_id":"1e5be457006e9eed067c5e07b64abd9ada25d74c"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"721c78ecd8c3007d3db5588da632771573715e4f","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        expected \u003d {\"public_key\": \"ssh-rsa foo Generated-by-Nova\","},{"line_number":52,"context_line":"                    \"user_id\":"},{"line_number":53,"context_line":"                    \"525d55f98980415ba98e634972fa4a10\","},{"line_number":54,"context_line":"                    \"name\": \"test\","},{"line_number":55,"context_line":"                    \"deleted\": False,"},{"line_number":56,"context_line":"                    \"created_at\": \"2015-07-22T04:53:52.000000\","},{"line_number":57,"context_line":"                    \"updated_at\": None,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_7520484a","line":54,"range":{"start_line":54,"start_character":19,"end_line":54,"end_character":23},"updated":"2015-08-03 15:28:21.000000000","message":"This should be a \"Unicode string\", for instance u\u0027\\u2740(*\\xb4\\u25e1`*)\\u2740\u0027","commit_id":"1e5be457006e9eed067c5e07b64abd9ada25d74c"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"721c78ecd8c3007d3db5588da632771573715e4f","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        expected \u003d {\"public_key\": \"ssh-rsa foo Generated-by-Nova\","},{"line_number":81,"context_line":"                    \"private_key\": \"foo\","},{"line_number":82,"context_line":"                    \"user_id\": \"525d55f98980415ba98e634972fa4a10\","},{"line_number":83,"context_line":"                    \"name\": \"test\","},{"line_number":84,"context_line":"                    \"fingerprint\":"},{"line_number":85,"context_line":"                    \"76:24:66:49:d7:ca:6e:5c:77:ea:8e:bb:9c:15:5f:98\"}"},{"line_number":86,"context_line":"        serialized_body \u003d json.dumps({\"keypair\": expected})"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_f5c69815","line":83,"updated":"2015-08-03 15:28:21.000000000","message":"Same here.","commit_id":"1e5be457006e9eed067c5e07b64abd9ada25d74c"}]}