)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"8095aefccfbc973a415e22f89ac7fe3852ec4218","unresolved":false,"context_lines":[{"line_number":9,"context_line":"1. Use common _check_remote_connectivity method to verify connectivity between"},{"line_number":10,"context_line":"servers"},{"line_number":11,"context_line":"Old code was a single try expecting 0% packet loss. Common method is resistant"},{"line_number":12,"context_line":"to packet loss and has retries."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"2. Verify connectivity against default v6 gateway."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a50d1a3_53b6cd3e","line":12,"updated":"2015-07-28 20:26:16.000000000","message":"Is this solving a known gate issue or is this just a pre-emptive safety thing?","commit_id":"16713e74f1d80f9fe5ced37b0083eae8798b9bb0"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"882c59d40d4b46523f70adbd02847b6ee5c0aef6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"1. Use common _check_remote_connectivity method to verify connectivity between"},{"line_number":10,"context_line":"servers"},{"line_number":11,"context_line":"Old code was a single try expecting 0% packet loss. Common method is resistant"},{"line_number":12,"context_line":"to packet loss and has retries."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"2. Verify connectivity against default v6 gateway."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a50d1a3_2f092e95","line":12,"in_reply_to":"3a50d1a3_53b6cd3e","updated":"2015-07-29 14:48:11.000000000","message":"I don\u0027t think it is a known gate issue. More refactoring to use existing code which happens to check connectivity with fewer performance assumptions.","commit_id":"16713e74f1d80f9fe5ced37b0083eae8798b9bb0"}],"tempest/scenario/test_network_v6.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"8095aefccfbc973a415e22f89ac7fe3852ec4218","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        sub4.add_to_router(router_id\u003drouter[\u0027id\u0027])"},{"line_number":85,"context_line":"        self.addCleanup(sub4.delete)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        self.subnets_v6 \u003d []"},{"line_number":88,"context_line":"        for _ in range(n_subnets6):"},{"line_number":89,"context_line":"            sub6 \u003d self._create_subnet(network\u003dself.network,"},{"line_number":90,"context_line":"                                       namestart\u003d\u0027sub6\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_93fa15bc","line":87,"updated":"2015-07-28 20:26:16.000000000","message":"I always advise against keeping state in the class when you don\u0027t need it, because it makes the tests less readable. I would rather call get_subnets with a v6 filter in line 159 but that\u0027s just me :)","commit_id":"16713e74f1d80f9fe5ced37b0083eae8798b9bb0"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"5e538a6a62dc5414b6373ed125fded7145a7961d","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        is_ping6 \u003d False if result \u003d\u003d \u0027ping6:\\n\u0027 else True"},{"line_number":160,"context_line":"        if is_ping6:"},{"line_number":161,"context_line":"            for i in range(n_subnets6):"},{"line_number":162,"context_line":"                self._check_remote_connectivity(sshv4_1,"},{"line_number":163,"context_line":"                                                ips_from_api_2[\u00276\u0027][i])"},{"line_number":164,"context_line":"                self._check_remote_connectivity(sshv4_1,"},{"line_number":165,"context_line":"                                                self.subnets_v6[i].gateway_ip)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_65135167","line":162,"updated":"2015-08-05 08:43:22.000000000","message":"_check_remote_connectivity is not an exception thrower,\nthe return value MUST be checked and a relevant message needs to be used in the assertTrue or in similar method.","commit_id":"16713e74f1d80f9fe5ced37b0083eae8798b9bb0"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f1420d38fccc168f1eed5a54bb55fdaa17a0e465","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        self.network \u003d self._create_network(tenant_id\u003dself.tenant_id)"},{"line_number":75,"context_line":"        sub4 \u003d self._create_subnet(network\u003dself.network,"},{"line_number":76,"context_line":"                                   namestart\u003d\u0027sub4\u0027,"},{"line_number":77,"context_line":"                                   ip_version\u003d4,)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        router \u003d self._get_router(tenant_id\u003dself.tenant_id)"},{"line_number":80,"context_line":"        sub4.add_to_router(router_id\u003drouter[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a4dcd0f_d28516cf","side":"PARENT","line":77,"updated":"2015-08-06 03:39:06.000000000","message":"nice catch","commit_id":"74647862be3b87687b27628d64da733ce8ad488c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f1420d38fccc168f1eed5a54bb55fdaa17a0e465","unresolved":false,"context_lines":[{"line_number":173,"context_line":"    def _check_connectivity(self, source, dest):"},{"line_number":174,"context_line":"        self.assertTrue("},{"line_number":175,"context_line":"            self._check_remote_connectivity(source, dest),"},{"line_number":176,"context_line":"            \"Timed out waiting for %s to become reachable\" % dest"},{"line_number":177,"context_line":"        )"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    @test.idempotent_id(\u00272c92df61-29f0-4eaa-bee3-7c65bef62a43\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a4dcd0f_9288eec6","line":176,"updated":"2015-08-06 03:39:06.000000000","message":"Can we add \"source\" address in the above message?\nI guess this kind of check will detect problems(that is good thing) and the gate will fail.\nSo maybe we will want some information to know the situation of problem. In addition, this scenario test contain 4 addresses ([ipv4, ipv6] * 2VMs). So the \"source\" will help us, I feel.","commit_id":"f960a8994069424351f67e65f4392ea49d2e621d"}]}