)]}'
{"tempest/tests/services/compute/test_quotas_client.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"87acf539a1265d6e10dc1659ccf555e56f6e4875","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from tempest.tests import fake_auth_provider"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TestQuotasClient(base.TestCase):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def setUp(self):"},{"line_number":28,"context_line":"        super(TestQuotasClient, self).setUp()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_e430a0eb","line":25,"updated":"2015-08-03 07:55:31.000000000","message":"The 3 dictionaries in test_show_quota, test_show_default_quota and test_update_quota are the same. We should have to copy/paste the dict in all tests.\n\nI suggest you define a class or module variable named, for example, \"FAKE_QUOTA_SET\" \u003d {the dictionary} and reuse that dict in the 3 tests.","commit_id":"162bb2f94091ccd19d877ac980718c81fb80f775"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"c868fed528d91f66ab8dfdbf44c79da399995411","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from tempest.tests import fake_auth_provider"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TestQuotasClient(base.TestCase):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def setUp(self):"},{"line_number":28,"context_line":"        super(TestQuotasClient, self).setUp()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_048a6c64","line":25,"in_reply_to":"3a50d1a3_e430a0eb","updated":"2015-08-03 07:56:43.000000000","message":"I meant \u0027we shouldn\u0027t have to...\u0027","commit_id":"162bb2f94091ccd19d877ac980718c81fb80f775"},{"author":{"_account_id":17104,"name":"Kenji Yasui","email":"k-yasui@ti.jp.nec.com","username":"yasui"},"change_message_id":"b0c5d2d80da574f1e1e49552c1b22647b4d7ca2a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from tempest.tests import fake_auth_provider"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TestQuotasClient(base.TestCase):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def setUp(self):"},{"line_number":28,"context_line":"        super(TestQuotasClient, self).setUp()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_a437f8ae","line":25,"in_reply_to":"3a50d1a3_e430a0eb","updated":"2015-08-03 08:07:09.000000000","message":"Thank you for your comment. I did not notice the dict is duplicated.  I\u0027ll fix this problem.","commit_id":"162bb2f94091ccd19d877ac980718c81fb80f775"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"09f479514a23eab6a41219f075f2c6892eed767d","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    def test_show_default_quota_set_with_bytes_body(self):"},{"line_number":84,"context_line":"        self._test_show_quota_set(bytes_body\u003dTrue)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def test_update_quota_set(self, bytes_body\u003dFalse):"},{"line_number":87,"context_line":"        fake_quota_set \u003d copy.deepcopy(self.FAKE_QUOTA_SET)"},{"line_number":88,"context_line":"        fake_quota_set.pop(\"id\")"},{"line_number":89,"context_line":"        serialized_body \u003d json.dumps({\"quota_set\": fake_quota_set})"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_31530f3b","line":86,"updated":"2015-08-06 08:40:45.000000000","message":"The bytes_body parameter is not used here.","commit_id":"daddbfb2b33b6bb78ed8d577df12aac4f4bbb129"},{"author":{"_account_id":17104,"name":"Kenji Yasui","email":"k-yasui@ti.jp.nec.com","username":"yasui"},"change_message_id":"826bf3834bea9803725af34419d341d1e9d54ea8","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    def test_show_default_quota_set_with_bytes_body(self):"},{"line_number":84,"context_line":"        self._test_show_quota_set(bytes_body\u003dTrue)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def test_update_quota_set(self, bytes_body\u003dFalse):"},{"line_number":87,"context_line":"        fake_quota_set \u003d copy.deepcopy(self.FAKE_QUOTA_SET)"},{"line_number":88,"context_line":"        fake_quota_set.pop(\"id\")"},{"line_number":89,"context_line":"        serialized_body \u003d json.dumps({\"quota_set\": fake_quota_set})"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_8c40ca35","line":86,"in_reply_to":"1a4dcd0f_31530f3b","updated":"2015-08-06 08:49:14.000000000","message":"Thank you for your review. I overlooked it.\n\nI\u0027ll fix it.","commit_id":"daddbfb2b33b6bb78ed8d577df12aac4f4bbb129"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ca3a7443f53449f03487706db9210966a51af006","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                      \"ram\": 51200,"},{"line_number":33,"context_line":"                      \"floating_ips\": 10,"},{"line_number":34,"context_line":"                      \"key_pairs\": 100,"},{"line_number":35,"context_line":"                      \"id\": \"8421f7be61064f50b680465c07f334af\","},{"line_number":36,"context_line":"                      \"instances\": 10,"},{"line_number":37,"context_line":"                      \"security_group_rules\": 20,"},{"line_number":38,"context_line":"                      \"injected_files\": 5,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_7e07f6c9","line":35,"updated":"2015-08-13 00:39:15.000000000","message":"In quota_sets APIs, the \"id\" means a project id.\nThat should be uuid without hyphens like this because keystone generates it with uuid4().hex.\n\nSo this \"id\" is valid, but the following \"id\"s which are included in tests are integer and that is invalid as input.\n\nSo how about defining\n\n project_id \u003d \"8421f7be61064f50b680465c07f334af\"\n\nand reusing it on each test?","commit_id":"227a78364eb86e9205eb40756646c6c89787acdc"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ca3a7443f53449f03487706db9210966a51af006","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        self.useFixture(mockpatch.Patch("},{"line_number":57,"context_line":"            \u0027tempest.common.service_client.ServiceClient.get\u0027,"},{"line_number":58,"context_line":"            return_value\u003dmocked_resp))"},{"line_number":59,"context_line":"        resp \u003d self.client.show_quota_set(1)"},{"line_number":60,"context_line":"        self.assertEqual(self.FAKE_QUOTA_SET, resp)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def test_show_quota_set_with_str_body(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_9e31a2a4","line":59,"updated":"2015-08-13 00:39:15.000000000","message":"here should be\n\n resp \u003d self.client.show_quota_set(self.project_id)","commit_id":"227a78364eb86e9205eb40756646c6c89787acdc"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ca3a7443f53449f03487706db9210966a51af006","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        self.useFixture(mockpatch.Patch("},{"line_number":75,"context_line":"            \u0027tempest.common.service_client.ServiceClient.get\u0027,"},{"line_number":76,"context_line":"            return_value\u003dmocked_resp))"},{"line_number":77,"context_line":"        resp \u003d self.client.show_default_quota_set(1)"},{"line_number":78,"context_line":"        self.assertEqual(self.FAKE_QUOTA_SET, resp)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def test_show_default_quota_set_with_str_body(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_1e1ef20b","line":77,"updated":"2015-08-13 00:39:15.000000000","message":"ditto:\n\n resp \u003d self.client.show_default_quota_set(self.project_id)","commit_id":"227a78364eb86e9205eb40756646c6c89787acdc"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ca3a7443f53449f03487706db9210966a51af006","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        self.useFixture(mockpatch.Patch("},{"line_number":92,"context_line":"            \u0027tempest.common.service_client.ServiceClient.put\u0027,"},{"line_number":93,"context_line":"            return_value\u003dmocked_resp))"},{"line_number":94,"context_line":"        resp \u003d self.client.update_quota_set(1)"},{"line_number":95,"context_line":"        self.assertEqual(fake_quota_set, resp)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def test_delete_quota_set(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_3ea96e90","line":94,"updated":"2015-08-13 00:39:15.000000000","message":"ditto: resp \u003d self.client.update_quota_set(self.project_id)","commit_id":"227a78364eb86e9205eb40756646c6c89787acdc"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ca3a7443f53449f03487706db9210966a51af006","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        self.useFixture(mockpatch.Patch("},{"line_number":101,"context_line":"            \u0027tempest.common.service_client.ServiceClient.delete\u0027,"},{"line_number":102,"context_line":"            return_value\u003dmocked_resp))"},{"line_number":103,"context_line":"        resp \u003d self.client.delete_quota_set(\"1\")"},{"line_number":104,"context_line":"        self.assertEqual(expected, resp)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_fe978645","line":103,"updated":"2015-08-13 00:39:15.000000000","message":"ditto: resp \u003d self.client.delete_quota_set(self.project_id)","commit_id":"227a78364eb86e9205eb40756646c6c89787acdc"}]}