)]}'
{"tempest/tests/services/compute/test_networks_client.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"184e95aff6627e44ed0fc03178a1b54d6037a95e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"            fake_auth, \u0027compute\u0027, \u0027regionOne\u0027)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def _test_list_networks(self, bytes_body\u003dFalse):"},{"line_number":34,"context_line":"        expected \u003d []"},{"line_number":35,"context_line":"        serialized_body \u003d json.dumps({\"networks\": expected})"},{"line_number":36,"context_line":"        if bytes_body:"},{"line_number":37,"context_line":"            serialized_body \u003d serialized_body.encode(\u0027utf-8\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_c19d8b0b","line":34,"updated":"2015-07-31 15:49:05.000000000","message":"See my comment below. You should return a fake list of networks, not an empty list. One of the network should have a name with a weird unicode char.","commit_id":"39c2150407414311b07d864143f25c0a784d43f6"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"184e95aff6627e44ed0fc03178a1b54d6037a95e","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        self._test_list_networks(bytes_body\u003dTrue)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def _test_show_network(self, bytes_body\u003dFalse):"},{"line_number":53,"context_line":"        expected \u003d {}"},{"line_number":54,"context_line":"        serialized_body \u003d json.dumps({\"network\": expected})"},{"line_number":55,"context_line":"        if bytes_body:"},{"line_number":56,"context_line":"            serialized_body \u003d serialized_body.encode(\u0027utf-8\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_419e5b64","line":53,"updated":"2015-07-31 15:49:05.000000000","message":"Could you fill this dict with the data of an actual network. Doing so would increase the test coverage for a minimum addition of code.","commit_id":"39c2150407414311b07d864143f25c0a784d43f6"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"184e95aff6627e44ed0fc03178a1b54d6037a95e","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            \u0027tempest.common.service_client.ServiceClient.get\u0027,"},{"line_number":61,"context_line":"            return_value\u003dmocked_resp))"},{"line_number":62,"context_line":"        resp \u003d self.client.show_network(\"private\")"},{"line_number":63,"context_line":"        self.assertEqual(expected, resp)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def test_show_network_with_str_body(self):"},{"line_number":66,"context_line":"        self._test_show_network()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_212d4ffd","line":63,"updated":"2015-07-31 15:49:05.000000000","message":"If the return value of your mock is more than just {} (as it is now), you should assert that the dict returned by \u0027show_network\u0027 has the correct keys and values.","commit_id":"39c2150407414311b07d864143f25c0a784d43f6"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"d7fce995c94187325cfff3577f2751edb3acae82","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        self.useFixture(mockpatch.Patch("},{"line_number":95,"context_line":"            \u0027tempest.common.service_client.ServiceClient.get\u0027,"},{"line_number":96,"context_line":"            return_value\u003dmocked_resp))"},{"line_number":97,"context_line":"        resp \u003d self.client.show_network(\"private\")"},{"line_number":98,"context_line":"        self.assertEqual(self.FAKE_NETWORK, resp)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def test_show_network_with_str_body(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_7fef471e","line":97,"updated":"2015-08-11 14:27:38.000000000","message":"It would have been better if you asserted that the parameter \"private\" was actually passed to service_client.ServiceClient.get","commit_id":"742dd3f1f00f26e4979b47c8fd677b60746734dc"},{"author":{"_account_id":17104,"name":"Kenji Yasui","email":"k-yasui@ti.jp.nec.com","username":"yasui"},"change_message_id":"6d01dbfcbaba0682140e93250111b743ddbc8518","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        self.useFixture(mockpatch.Patch("},{"line_number":95,"context_line":"            \u0027tempest.common.service_client.ServiceClient.get\u0027,"},{"line_number":96,"context_line":"            return_value\u003dmocked_resp))"},{"line_number":97,"context_line":"        resp \u003d self.client.show_network(\"private\")"},{"line_number":98,"context_line":"        self.assertEqual(self.FAKE_NETWORK, resp)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def test_show_network_with_str_body(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_ecd1c8fc","line":97,"in_reply_to":"1a4dcd0f_4f024674","updated":"2015-08-18 06:10:12.000000000","message":"Thank you for your comments. I had fixed here.\n\nPlease check it again.","commit_id":"742dd3f1f00f26e4979b47c8fd677b60746734dc"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"2feca0f110dec1f79fe8924daaab6154811b0eab","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        self.useFixture(mockpatch.Patch("},{"line_number":95,"context_line":"            \u0027tempest.common.service_client.ServiceClient.get\u0027,"},{"line_number":96,"context_line":"            return_value\u003dmocked_resp))"},{"line_number":97,"context_line":"        resp \u003d self.client.show_network(\"private\")"},{"line_number":98,"context_line":"        self.assertEqual(self.FAKE_NETWORK, resp)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def test_show_network_with_str_body(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_4f024674","line":97,"in_reply_to":"1a4dcd0f_7fef471e","updated":"2015-08-14 04:19:12.000000000","message":"We cannot specify the name like \"private\" on this API, and we need to specify the network id like \"34d5ae1e-5659-49cf-af80-73bccd7d7ad3\".\n\nIf specifying the name, the API returns an error response like:\n\n $ curl -g -i -X GET http://192.168.11.65:8774/v2/3e45d151d4224aeaaa0751fb58a1cc33/os-networks/private -H \"User-Agent: python-novaclient\" -H \"Accept: application/json\" -H \"X-Auth-Token: b97982bc610e4907b0309e34ad960db2\"\n HTTP/1.1 500 Internal Server Error\n Content-Length: 128\n Content-Type: application/json; charset\u003dUTF-8\n X-Compute-Request-Id: req-eab6e77e-a5cc-4152-aec7-21e512b50235\n Date: Fri, 14 Aug 2015 04:14:52 GMT\n\n {\"computeFault\": {\"message\": \"The server has either erred or is incapable of performing the requested operation.\", \"code\": 500}}\n $\n\nSo here should be\n\n resp \u003d self.client.show_network(\"34d5ae1e-5659-49cf-af80-73bccd7d7ad3\")\n\nps. This internal error is another problem, anyway..","commit_id":"742dd3f1f00f26e4979b47c8fd677b60746734dc"}]}