)]}'
{"tempest/api/telemetry/base.py":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"7211bf21225c3d5baeb63d45d4570aa4d5d48cc3","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    @classmethod"},{"line_number":44,"context_line":"    def setup_clients(cls):"},{"line_number":45,"context_line":"        super(BaseTelemetryTest, cls).setup_clients()"},{"line_number":46,"context_line":"        cls.telemetry_client \u003d cls.os.telemetry_client"},{"line_number":47,"context_line":"        cls.servers_client \u003d cls.os.servers_client"},{"line_number":48,"context_line":"        cls.flavors_client \u003d cls.os.flavors_client"},{"line_number":49,"context_line":"        cls.image_client \u003d cls.os.image_client"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_5bf7ead2","line":46,"updated":"2015-08-03 11:25:44.000000000","message":"It looks like this line is not needed anymore.","commit_id":"5072cfc94f37c2a14025eb28839900e6e8752508"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"2ecc040d343ed6898b22b24d0bcbc4c835e297a6","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    @classmethod"},{"line_number":44,"context_line":"    def setup_clients(cls):"},{"line_number":45,"context_line":"        super(BaseTelemetryTest, cls).setup_clients()"},{"line_number":46,"context_line":"        cls.telemetry_client \u003d cls.os.telemetry_client"},{"line_number":47,"context_line":"        cls.servers_client \u003d cls.os.servers_client"},{"line_number":48,"context_line":"        cls.flavors_client \u003d cls.os.flavors_client"},{"line_number":49,"context_line":"        cls.image_client \u003d cls.os.image_client"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_c4aacf85","line":46,"in_reply_to":"1a4dcd0f_a46543e2","updated":"2015-08-03 15:50:05.000000000","message":"Yes, you are right.","commit_id":"5072cfc94f37c2a14025eb28839900e6e8752508"},{"author":{"_account_id":10016,"name":"Joseph Lanoux","email":"joseph.lanoux@hpe.com","username":"lanoux"},"change_message_id":"7d6f620994f12e5077886380e198f0cc58c734ef","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    @classmethod"},{"line_number":44,"context_line":"    def setup_clients(cls):"},{"line_number":45,"context_line":"        super(BaseTelemetryTest, cls).setup_clients()"},{"line_number":46,"context_line":"        cls.telemetry_client \u003d cls.os.telemetry_client"},{"line_number":47,"context_line":"        cls.servers_client \u003d cls.os.servers_client"},{"line_number":48,"context_line":"        cls.flavors_client \u003d cls.os.flavors_client"},{"line_number":49,"context_line":"        cls.image_client \u003d cls.os.image_client"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_a46543e2","line":46,"in_reply_to":"3a50d1a3_5bf7ead2","updated":"2015-08-03 15:41:50.000000000","message":"Well spotted but we still need this one for the cleanup in the test class.","commit_id":"5072cfc94f37c2a14025eb28839900e6e8752508"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"7211bf21225c3d5baeb63d45d4570aa4d5d48cc3","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        cls.glance_notifications \u003d [\u0027image.size\u0027]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        cls.glance_v2_notifications \u003d [\u0027image.download\u0027, \u0027image.serve\u0027]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        cls.server_ids \u003d []"},{"line_number":63,"context_line":"        cls.alarm_ids \u003d []"},{"line_number":64,"context_line":"        cls.image_ids \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_5b704a72","line":61,"updated":"2015-08-03 11:25:44.000000000","message":"ditto","commit_id":"5072cfc94f37c2a14025eb28839900e6e8752508"},{"author":{"_account_id":10016,"name":"Joseph Lanoux","email":"joseph.lanoux@hpe.com","username":"lanoux"},"change_message_id":"7d6f620994f12e5077886380e198f0cc58c734ef","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        cls.glance_notifications \u003d [\u0027image.size\u0027]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        cls.glance_v2_notifications \u003d [\u0027image.download\u0027, \u0027image.serve\u0027]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        cls.server_ids \u003d []"},{"line_number":63,"context_line":"        cls.alarm_ids \u003d []"},{"line_number":64,"context_line":"        cls.image_ids \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_64489b5c","line":61,"in_reply_to":"3a50d1a3_5b704a72","updated":"2015-08-03 15:41:50.000000000","message":"Done","commit_id":"5072cfc94f37c2a14025eb28839900e6e8752508"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"7211bf21225c3d5baeb63d45d4570aa4d5d48cc3","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @classmethod"},{"line_number":91,"context_line":"    def resource_cleanup(cls):"},{"line_number":92,"context_line":"        cls.cleanup_resources(cls.telemetry_client.delete_alarm, cls.alarm_ids)"},{"line_number":93,"context_line":"        cls.cleanup_resources(cls.servers_client.delete_server, cls.server_ids)"},{"line_number":94,"context_line":"        cls.cleanup_resources(cls.image_client.delete_image, cls.image_ids)"},{"line_number":95,"context_line":"        super(BaseTelemetryTest, cls).resource_cleanup()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_1b6642bb","line":92,"updated":"2015-08-03 11:25:44.000000000","message":"ditto","commit_id":"5072cfc94f37c2a14025eb28839900e6e8752508"},{"author":{"_account_id":10016,"name":"Joseph Lanoux","email":"joseph.lanoux@hpe.com","username":"lanoux"},"change_message_id":"7d6f620994f12e5077886380e198f0cc58c734ef","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @classmethod"},{"line_number":91,"context_line":"    def resource_cleanup(cls):"},{"line_number":92,"context_line":"        cls.cleanup_resources(cls.telemetry_client.delete_alarm, cls.alarm_ids)"},{"line_number":93,"context_line":"        cls.cleanup_resources(cls.servers_client.delete_server, cls.server_ids)"},{"line_number":94,"context_line":"        cls.cleanup_resources(cls.image_client.delete_image, cls.image_ids)"},{"line_number":95,"context_line":"        super(BaseTelemetryTest, cls).resource_cleanup()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_0474379a","line":92,"in_reply_to":"3a50d1a3_1b6642bb","updated":"2015-08-03 15:41:50.000000000","message":"Done","commit_id":"5072cfc94f37c2a14025eb28839900e6e8752508"}],"tempest/api/telemetry/test_telemetry_notification_api.py":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a47031cce1634ac2cd83e614492fc1825b79ec67","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        body, server \u003d compute.create_test_server("},{"line_number":40,"context_line":"            self.os,"},{"line_number":41,"context_line":"            validatable\u003dFalse,"},{"line_number":42,"context_line":"            validation_resources\u003dNone,"},{"line_number":43,"context_line":"            tenant_network\u003dtenant_network,"},{"line_number":44,"context_line":"            name\u003ddata_utils.rand_name(\u0027ceilometer-instance\u0027),"},{"line_number":45,"context_line":"            wait_until\u003d\u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_ae6f5a91","line":42,"updated":"2015-08-03 17:53:47.000000000","message":"You can remove this line because validation_resources\u003dNone by default in create_test_server(...)","commit_id":"c8c16bc65fe64e95773e095112e3fc9d1b540964"},{"author":{"_account_id":10016,"name":"Joseph Lanoux","email":"joseph.lanoux@hpe.com","username":"lanoux"},"change_message_id":"862b088e5e463df323051370ce95b2aff01843da","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        body, server \u003d compute.create_test_server("},{"line_number":40,"context_line":"            self.os,"},{"line_number":41,"context_line":"            validatable\u003dFalse,"},{"line_number":42,"context_line":"            validation_resources\u003dNone,"},{"line_number":43,"context_line":"            tenant_network\u003dtenant_network,"},{"line_number":44,"context_line":"            name\u003ddata_utils.rand_name(\u0027ceilometer-instance\u0027),"},{"line_number":45,"context_line":"            wait_until\u003d\u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_19d23f01","line":42,"in_reply_to":"1a4dcd0f_ae6f5a91","updated":"2015-08-04 07:16:11.000000000","message":"Done","commit_id":"c8c16bc65fe64e95773e095112e3fc9d1b540964"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a47031cce1634ac2cd83e614492fc1825b79ec67","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            tenant_network\u003dtenant_network,"},{"line_number":44,"context_line":"            name\u003ddata_utils.rand_name(\u0027ceilometer-instance\u0027),"},{"line_number":45,"context_line":"            wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":46,"context_line":"        self.addCleanup(self.servers_client.delete_server, body[\u0027id\u0027])"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        query \u003d (\u0027resource\u0027, \u0027eq\u0027, body[\u0027id\u0027])"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_8ece1e82","line":46,"updated":"2015-08-03 17:53:47.000000000","message":"Probably, it would be better to use here something like this:\n\n    server_id \u003d body[\u0027id\u0027]\n    self.addCleanup(self.cleanup_resources, \n                    self.servers_client.delete_server, [server_id])","commit_id":"c8c16bc65fe64e95773e095112e3fc9d1b540964"},{"author":{"_account_id":10016,"name":"Joseph Lanoux","email":"joseph.lanoux@hpe.com","username":"lanoux"},"change_message_id":"862b088e5e463df323051370ce95b2aff01843da","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            tenant_network\u003dtenant_network,"},{"line_number":44,"context_line":"            name\u003ddata_utils.rand_name(\u0027ceilometer-instance\u0027),"},{"line_number":45,"context_line":"            wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":46,"context_line":"        self.addCleanup(self.servers_client.delete_server, body[\u0027id\u0027])"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        query \u003d (\u0027resource\u0027, \u0027eq\u0027, body[\u0027id\u0027])"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_d9f2979a","line":46,"in_reply_to":"1a4dcd0f_8ece1e82","updated":"2015-08-04 07:16:11.000000000","message":"Hmm, I don\u0027t think this is necessary.","commit_id":"c8c16bc65fe64e95773e095112e3fc9d1b540964"}]}