)]}'
{"tempest/scenario/test_network_basic_ops.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"58af310c229374f872b525f6f51b00aacc6e68f6","unresolved":false,"context_lines":[{"line_number":656,"context_line":""},{"line_number":657,"context_line":"    @test.idempotent_id(\u00272e788c46-fb3f-4ac9-8f82-0561555bea73\u0027)"},{"line_number":658,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":659,"context_line":"    def test_router_rescheduling(self):"},{"line_number":660,"context_line":"        \"\"\"Tests that router can be removed from agent and add to a new agent."},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"        1. Verify connectivity"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_2db84b29","line":659,"updated":"2015-08-07 13:47:25.000000000","message":"So I like this test a lot. This is a good scenario.\n\nBut the fact you are preparing to also test dhcp agent rescheduling, forces you to use a lot of \u0027getattr\u0027 calls which make the code overall not so easy to read or debug.\n\nI think you should not try to make this code too generic but instead accept some code duplication when you will actually add the test that tests dhcp agent rescheduling","commit_id":"a7c430d3bcfb158e27d5af8e1287e15e5f5aaa06"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"58af310c229374f872b525f6f51b00aacc6e68f6","unresolved":false,"context_lines":[{"line_number":686,"context_line":"        hosting_agents \u003d set(a[\"id\"] for a in"},{"line_number":687,"context_line":"                             getattr(self.admin_manager.network_client,"},{"line_number":688,"context_line":"                                     hosting_method)(resource.id)[\u0027agents\u0027])"},{"line_number":689,"context_line":"        no_migration \u003d agent_list \u003d\u003d hosting_agents"},{"line_number":690,"context_line":"        for hosting_agent in hosting_agents:"},{"line_number":691,"context_line":"            getattr(self.admin_manager.network_client,"},{"line_number":692,"context_line":"                    remove_method)(hosting_agent, resource.id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_4de11729","line":689,"updated":"2015-08-07 13:47:25.000000000","message":"You should LOG the value of \"no_migration\" to easily see which jobs in the gate actually exercise a \"real\" migration.","commit_id":"a7c430d3bcfb158e27d5af8e1287e15e5f5aaa06"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"4b8e4171fca20ea48e597edd037f1f04b2a9f9a4","unresolved":false,"context_lines":[{"line_number":653,"context_line":""},{"line_number":654,"context_line":"    @test.idempotent_id(\u00272e788c46-fb3f-4ac9-8f82-0561555bea73\u0027)"},{"line_number":655,"context_line":"    @testtools.skipIf(\"dvr\" in CONF.network_feature_enabled.api_extensions,"},{"line_number":656,"context_line":"                      \"Router rescheduling not supported on DVR\")"},{"line_number":657,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":658,"context_line":"    def test_router_rescheduling(self):"},{"line_number":659,"context_line":"        \"\"\"Tests that router can be removed from agent and add to a new agent."}],"source_content_type":"text/x-python","patch_set":6,"id":"1a4dcd0f_46971548","line":656,"updated":"2015-08-11 20:30:12.000000000","message":"Maybe you can reference https://bugs.launchpad.net/neutron/+bug/1369721 here. Once that is solved you can add a test that tests DVR SNAT rescheduling. It\u0027s only relevant to VMs without a floating IP though, that might hinder your ability to test it in Tempest (But we can test it just fine via Neutron\u0027s integration tests ;-)","commit_id":"564d89d4a215ece2af840b64ad3963550bff4767"}]}