)]}'
{"tempest/scenario/test_network_v6.py":[{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"532e811e9488df0aa0dfadebabcb137ed1e27302","unresolved":false,"context_lines":[{"line_number":70,"context_line":"         given number of IPv6 subnets in the given mode and"},{"line_number":71,"context_line":"         one IPv4 subnet"},{"line_number":72,"context_line":"         Creates router with ports on all subnets"},{"line_number":73,"context_line":"         if dualstack - create IPv6 subnets on a differnt network"},{"line_number":74,"context_line":"         :return: list of created networks"},{"line_number":75,"context_line":"        \"\"\""},{"line_number":76,"context_line":"        self.network \u003d self._create_network(tenant_id\u003dself.tenant_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_1b37d74d","line":73,"updated":"2015-08-07 08:40:49.000000000","message":"In the commit message you explained about Dual Networks (i.e., dual NICs). Since dualstack could also mean having IPv4 and IPv6 subnets as part of the same network, it would be good to choose some other name which is more suitable.","commit_id":"921a5b0fe9724c5aa7bd9c111be21bde29a3bb64"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"532e811e9488df0aa0dfadebabcb137ed1e27302","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            return addr in ssh.get_ip_list()"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        # Turn on 2nd NIC for Cirros when dualstack"},{"line_number":141,"context_line":"        if dualstack:"},{"line_number":142,"context_line":"            sshv4_1.turn_nic_on(\u0027eth1\u0027)"},{"line_number":143,"context_line":"            sshv4_2.turn_nic_on(\u0027eth1\u0027)"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_9b8d27d5","line":141,"updated":"2015-08-07 08:40:49.000000000","message":"IMHO, hardcoding the interface name is not a good idea because we can run tempest against any image by changing the image_id in the tempest configuration. As you know, some images do not use the eth[x] convention (i.e., like Fedora). \n\nPlease check if there is a way to identify the second interface name before using it, so that this test case can be run against any VM image.","commit_id":"921a5b0fe9724c5aa7bd9c111be21bde29a3bb64"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"7bc069a26ccaafa96d5dfcb8e61d49cfa18595ef","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            return addr in ssh.get_ip_list()"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        # Turn on 2nd NIC for Cirros when dualstack"},{"line_number":141,"context_line":"        if dualstack:"},{"line_number":142,"context_line":"            sshv4_1.turn_nic_on(\u0027eth1\u0027)"},{"line_number":143,"context_line":"            sshv4_2.turn_nic_on(\u0027eth1\u0027)"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_d53933f3","line":141,"in_reply_to":"1a4dcd0f_9b8d27d5","updated":"2015-08-07 12:35:25.000000000","message":"I would suggest comparing the MAC of the ipv6 port to the output of `ip a`","commit_id":"921a5b0fe9724c5aa7bd9c111be21bde29a3bb64"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"c3ab8b5cee543825a651ab7229bfbdd340732ef0","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        \"\"\"Turns the IPv6 vNIC on"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        Required because guest images usually set only the first vNIC on boot."},{"line_number":133,"context_line":"        Will search for the IPv6 vNIC\u0027s MAC and bring it up."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        @param ssh: RemoteClient ssh instance to server"},{"line_number":136,"context_line":"        @param sid: server uuid"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_26e785e5","line":133,"updated":"2015-08-11 13:14:53.000000000","message":"The subject is missing from the sentence.","commit_id":"a6cb0b0c5fd73abcb6a801a908dce93565afcae0"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"c3ab8b5cee543825a651ab7229bfbdd340732ef0","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                         % self.network_v6)"},{"line_number":144,"context_line":"        mac6 \u003d ports[0]"},{"line_number":145,"context_line":"        nic_name \u003d ssh.get_nic_name(mac6)"},{"line_number":146,"context_line":"        ssh.turn_nic_on(nic_name.strip().strip(\":\").lower())"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def _prepare_and_test(self, address6_mode, n_subnets6\u003d1, dualnet\u003dFalse):"},{"line_number":149,"context_line":"        net_list \u003d self.prepare_network(address6_mode\u003daddress6_mode,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_66634d1b","line":146,"updated":"2015-08-11 13:14:53.000000000","message":"The get_nic_name already got an extra strip, it is enough to strip only in one place. (-1) .","commit_id":"a6cb0b0c5fd73abcb6a801a908dce93565afcae0"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"1dcc1d2ac2c1869d3ee9adc923074b112292d8ba","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            server_or_ip\u003dfip.floating_ip_address,"},{"line_number":124,"context_line":"            username\u003dusername)"},{"line_number":125,"context_line":"        # if len(networks) \u003e 1:"},{"line_number":126,"context_line":"        #     ssh.renew_lease()"},{"line_number":127,"context_line":"        return ssh, ips, srv[\"id\"]"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def turn_nic6_on(self, ssh, sid):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_d12c2b4c","line":126,"updated":"2015-08-12 08:20:26.000000000","message":"Can we remove this dead code?","commit_id":"8a10865fc9ae6d62a57bf03e47da98636ea0121a"}]}