)]}'
{"tempest/common/utils/linux/remote_client.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"c1ae4a2986414db27949359c78d6e98fa856c020","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    def hostname_equals_servername(self, expected_hostname):"},{"line_number":65,"context_line":"        # Get host name using command \"hostname\""},{"line_number":66,"context_line":"        actual_hostname \u003d self.exec_command(\"hostname\").rstrip()"},{"line_number":67,"context_line":"        LOG.debug(\"Expected hostname: %s\" % expected_hostname)"},{"line_number":68,"context_line":"        LOG.debug(\"Actual hostname: %s\" % actual_hostname)"},{"line_number":69,"context_line":"        return expected_hostname \u003d\u003d actual_hostname"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_4ebb330f","line":67,"updated":"2015-08-17 11:47:57.000000000","message":"Could you log this info if and only if \"expected_hostname !\u003d actual_hostname\". I think we should not log this assertion if everything goes according to plan.","commit_id":"8b82e4157d24fbb8cc503b8f202becd73a2c724c"},{"author":{"_account_id":10234,"name":"Andrey Pavlov","email":"andrey.mp@gmail.com","username":"andrey-mp"},"change_message_id":"33b5b2a5aee62ada10fd656f369a85658f4d2c50","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        \"\"\""},{"line_number":62,"context_line":"        self.ssh_client.test_connection_auth()"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def hostname_equals_servername(self, expected_hostname):"},{"line_number":65,"context_line":"        # Get host name using command \"hostname\""},{"line_number":66,"context_line":"        actual_hostname \u003d self.exec_command(\"hostname\").rstrip()"},{"line_number":67,"context_line":"        if expected_hostname !\u003d actual_hostname:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_12584487","line":64,"updated":"2015-10-22 06:16:22.000000000","message":"I i would have done in another way. i would change this function to return the actual hostname. and in the calling function I would change \u0027assertTrue\u0027 to \u0027assertEqual\u0027. In this case logger will print both names.\n\nFor me - this is a bad idea to use \u0027assertTrue(A \u003d\u003d B)\u0027 when we have assertEqual.","commit_id":"22f3888096d0e5e48061561fefaaa5e7719dd44b"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"faaf899ab93fa10bd2ac99dc0e7214439039d119","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        \"\"\""},{"line_number":62,"context_line":"        self.ssh_client.test_connection_auth()"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def hostname_equals_servername(self, expected_hostname):"},{"line_number":65,"context_line":"        # Get host name using command \"hostname\""},{"line_number":66,"context_line":"        actual_hostname \u003d self.exec_command(\"hostname\").rstrip()"},{"line_number":67,"context_line":"        if expected_hostname !\u003d actual_hostname:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_1660d8cd","line":64,"in_reply_to":"1a26ad4f_0779a693","updated":"2016-01-12 16:41:53.000000000","message":"yeh, get_hostname seems better","commit_id":"22f3888096d0e5e48061561fefaaa5e7719dd44b"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"447c323dc28d52f660cbc7b79012b0550d0aa342","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        \"\"\""},{"line_number":62,"context_line":"        self.ssh_client.test_connection_auth()"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def hostname_equals_servername(self, expected_hostname):"},{"line_number":65,"context_line":"        # Get host name using command \"hostname\""},{"line_number":66,"context_line":"        actual_hostname \u003d self.exec_command(\"hostname\").rstrip()"},{"line_number":67,"context_line":"        if expected_hostname !\u003d actual_hostname:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_0779a693","line":64,"in_reply_to":"3a29b11f_12584487","updated":"2015-10-27 09:06:43.000000000","message":"Andrey, I agree with you but I like the fact that this file remote_client.py doesn\u0027t use any assert* call but let the caller decide what to do.\n\nMaybe rename this function to be \u0027get_hostname\u0027 and return the hostname string. Let the caller do the assertEqual call.","commit_id":"22f3888096d0e5e48061561fefaaa5e7719dd44b"}]}